Activity dgfirmware/firmware/App/Modes

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	15
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 23 Aug 2023

11:55 am

James Walter Taylor <jtaylor@diality.com>

More
150a74d
changed 6 files
develop

Merge remote-tracking branch 'origin/DEN-16280-stuck-in-post-treatment-when-inlet-water-alarm-appears' into develop

- -3
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 5 more files in changeset.

10:32 am

Vinayakam Mani

More
d05ec20
changed 2 files
develop

DEN-16093-merge in to develop

- -5
- +5
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 1 more file in changeset.

10:21 am

Vinayakam Mani

More
2de5552
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more DG-DEN-16093-1

DEN-16093-changed prime Max time and conductivity poercent check

- -5
- +5
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

Tuesday 22 Aug 2023

11:04 am

Sean Nash

More
Re: DG-DEN-16093-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 am

Sean Nash

More
Re: DG-DEN-16093-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:07 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

More
Re: DG-DEN-16093-1
commented on review

Add a blank line between declarations and code.

Add a blank line between declarations and code.

9:57 am

Sean Nash

More
Re: DG-DEN-16093-1
commented on review

#includes are sorted. Put OperationModes.h in its proper place.

#includes are sorted. Put OperationModes.h in its proper place.

Monday 21 Aug 2023

6:05 pm

Vinayakam Mani

More
Re: DG-DEN-16093-1
replied to Sean Nash

required changes are done.

required changes are done.

1:55 pm

Sean Nash

More
Re: DG-DEN-16093-1
commented on review

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting...

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting). Function would also create and send the cmd response message and return TRUE/FALSE which would set local result here for the ack response message below.
We should reject cmd if pumps are busy/on and/or if current DG mode is fill or fault mode.

Friday 18 Aug 2023

1:50 pm

Dara Navaei

More
b766ff8
changed 3 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 75 more DG-DEN-16093-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 2 more files in changeset.

1:49 pm

Dara Navaei

More
DG-DEN-16250-1
Closed

1:48 pm

Sean Nash and wbracken (deleted user)

More
DG-DEN-16250-1
finished reviewing

1:45 pm

Dara Navaei

More
5bf4b57
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more DG-DEN-16250-1

DEN-16250 updated doxygen comment

- -2
- +1
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

Thursday 17 Aug 2023

2:51 pm

Dara Navaei

More
efba6ee
changed 1 file
develop

Merge branch 'DEN-16250-flow-check-alarm-207-when-filling-with-pause-state' into develop

- -5
- +13
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

2:50 pm

Dara Navaei

More
bcd5068
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more DG-DEN-16250-1

DEN-15250 addressed alarm 207

- -5
- +13
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

2:04 pm

Dara Navaei

More
DG-DEN-16093-1
started review

DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment

DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment

10:04 am

Dara Navaei

More
DG-DEN-16250-1
started review

DG-DEN-16250_Flow Check Alarm 207 When Filling With Pause State

DG-DEN-16250_Flow Check Alarm 207 When Filling With Pause State

9:49 am

Dara Navaei

More
61b6091
changed 2 files
develop

Merged DEN-16250

- -1
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 1 more file in changeset.

9:48 am

Dara Navaei

More
2c23724
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more DG-DEN-16250-1

DEN-16250 added the FMP check flag to state transition function in mode fill

- -1
- +2
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c

9:09 am

Sean Nash

More
DG-UCOMMITS-39
finished reviewing

Wednesday 16 Aug 2023

5:32 pm

Dara Navaei

More
d0536d7
changed 6 files
DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 78 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./ModeChemicalDisinfect.c
- History
- Source
- Diff
./ModeChemicalDisinfect.c
- -1
- +1
./ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
./ModeChemicalDisinfectFlush.c
- -1
- +1
./ModeFlush.c
- History
- Source
- Diff
./ModeFlush.c
- -1
- +1
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c
- -1
- +1
./ModeHeatDisinfectActiveCool.c
- History
- Source
- Diff
./ModeHeatDisinfectActiveCool.c
… 1 more file in changeset.

5:31 pm

Dara Navaei

More
DG-DEN-15974-1
Closed

5:30 pm

wbracken (deleted user) and Sean Nash

More
DG-DEN-15974-1
finished reviewing

5:27 pm

Dara Navaei

More
213c09d
changed 5 files
DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 79 more DG-DEN-15974-1

DEN-15974 updated the state of VPo in the cleaning modes' drain to be to fill

- -0
- +1
./ModeChemicalDisinfect.c
- History
- Source
- Diff
./ModeChemicalDisinfect.c
- -0
- +1
./ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
./ModeChemicalDisinfectFlush.c
- -0
- +1
./ModeFlush.c
- History
- Source
- Diff
./ModeFlush.c
- -0
- +1
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c
- -0
- +1
./ModeHeatDisinfectActiveCool.c
- History
- Source
- Diff
./ModeHeatDisinfectActiveCool.c

2:38 pm

Dara Navaei

2:37 pm

Dara Navaei

More
1c73626
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 79 more DG-DEN-15974-1

DEN-16222 updated the heat disinfect code

- -8
- +7
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c

2:32 pm

Dara Navaei

More
2bb5167
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 79 more DG-DEN-15974-1

DEN-16222 fixed the heat disinfect cancel water path drain R1

- -3
- +5
./ModeHeatDisinfect.c
- History
- Source
- Diff
./ModeHeatDisinfect.c

2:04 pm

Dara Navaei

More
DG-DEN-15974-1
started review

DG-DEN-15974_Alarm 187 Triggered During Consumables Check And During Treatment

DG-DEN-15974_Alarm 187 Triggered During Consumables Check And During Treatment

1:30 pm

Dara Navaei

More
87467f3
changed 5 files
develop

Merged DEN-15964

- -10
- +5
./ModeFill.c
- History
- Source
- Diff
./ModeFill.c
… 4 more files in changeset.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-24 02:46 -0700