dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Mar 2023
3:28 pm

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen' into develop

Options
    • -19
    • +33
    ./SystemComm.c
3:27 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./SystemComm.c
3:18 pm

Michael Garthwaite

3:10 pm

Sean Nash

1:45 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:44 pm

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:43 pm

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

1:42 pm

wbracken  (deleted user)

Corrected

Corrected

1:42 pm

wbracken  (deleted user)

Corrected

Corrected

1:42 pm

wbracken  (deleted user)

Corrected

Corrected

1:21 pm

Michael Garthwaite and Sean Nash

1:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:03 pm

dcox  (deleted user)

Does TODO need to be resolved?

Does TODO need to be resolved?

1:01 pm

jtaylor  (deleted user)

Extra space before the last paren.

Extra space before the last paren.

12:59 pm

jtaylor  (deleted user)

Missing space.

Missing space.

12:53 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:30 pm

James Walter Taylor <jtaylor@diality.com>

DG-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Update for code review.

Options
    • -1
    • +1
    ./SystemComm.c
12:29 pm

jtaylor  (deleted user)

Done.

Done.

10:07 am

wbracken  (deleted user)

Space between ((

Space between ((

9:14 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:03 am

Sean Nash

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

8:59 am

James Walter Taylor <jtaylor@diality.com>

HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Closing code review comments.

Options
    • -9
    • +7
    ./SystemComm.c
8:54 am

Michael Garthwaite

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

8:36 am

jtaylor  (deleted user)

Done. Does HD communicating always account for UI traffic as well?

Done. Does HD communicating always account for UI traffic as well?

8:35 am

jtaylor  (deleted user)

Done

Done

8:22 am

jtaylor  (deleted user)

Reverted.

Reverted.

Thursday 30 Mar 2023
9:18 pm

Sean Nash

DEN-14999: Small fix to DG WD POST.

Options
    • -0
    • +5
    ./WatchdogMgmt.c
7:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.