Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DG-DIAL-283_NO Moving Average Commands Conductivity
DG-DIAL-283_NO Moving Average Commands Conductivity
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Add blank line between this code and switch below.

Add blank line between this code and switch below.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

These fields have been moved to a different broadcast at some point, and were no longer being set by the reservoir data broadcast. The fields regularly contained "NAN" values, so I removed them.

These fields have been moved to a different broadcast at some point, and were no longer being set by the reservoir data broadcast. The fields regularly contained "NAN" values, so I removed them.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Why are these fields removed?

Why are these fields removed?

Done. Code updates pushed.

Done. Code updates pushed.

I don't see these being used anywhere.

I don't see these being used anywhere.

Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

We typically dont #define for 0. However, the logic has been reworked that we no longer need to compare by 0.

We typically dont #define for 0. However, the logic has been reworked that we no longer need to compare by 0.

DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low
DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This if doesn't appear to be doing anything. Remove.

This if doesn't appear to be doing anything. Remove.

This should be inverse of what you had before. I think this is too brief.

This should be inverse of what you had before. I think this is too brief.

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!