Activity dgfirmware/firmware/App

8:42 am

Dara Navaei

More
28b5f2e
changed 9 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 216 more DG-DEN-7568-1 DG-DEN-5963-1

DEN-5963 addressed code review comments

- -1
- +1
./Controllers/Heaters.c
- History
- Source
- Diff
./Controllers/Heaters.c
- -1
- +1
./Controllers/ROPump.c
- History
- Source
- Diff
./Controllers/ROPump.c
- -17
- +36
./Controllers/TemperatureSensors.c
- History
- Source
- Diff
./Controllers/TemperatureSensors.c
- -0
- +29
./Controllers/TemperatureSensors.h
- History
- Source
- Diff
./Controllers/TemperatureSensors.h
- -1
- +1
./Controllers/Thermistors.c
- History
- Source
- Diff
./Controllers/Thermistors.c
- -3
- +4
./Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
./Modes/ModeHeatDisinfect.c
- -5
- +4
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -2
- +3
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h
… 1 more file in changeset.

11:05 pm

Dara Navaei

More
DG-DEN-7568-1
added pmontazemi (deleted user) and qnguyen (deleted user)

8:45 pm

Dara Navaei

More
Re: DG-DEN-5963-1
replied to qnguyen (deleted user)

I removed the = sign.

2:00 pm

Dara Navaei

More
ebbb1f8
changed 23 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 216 more DG-DEN-5963-1 DG-UCOMMITS-37 DG-DEN-7568-1

DEN-5963 remerged staging

- -14
- +14
./Controllers/ConcentratePumps.c
- History
- Source
- Diff
./Controllers/ConcentratePumps.c
- -2
- +2
./Controllers/ConcentratePumps.h
- History
- Source
- Diff
./Controllers/ConcentratePumps.h
- -2
- +13
./Controllers/DrainPump.c
- History
- Source
- Diff
./Controllers/DrainPump.c
- -15
- +14
./Controllers/Heaters.c
- History
- Source
- Diff
./Controllers/Heaters.c
- -57
- +152
./Controllers/LoadCell.c
- History
- Source
- Diff
./Controllers/LoadCell.c
- -1
- +2
./Controllers/LoadCell.h
- History
- Source
- Diff
./Controllers/LoadCell.h
- -1
- +3
./Controllers/Pressures.c
- History
- Source
- Diff
./Controllers/Pressures.c
- -1
- +3
./Controllers/TemperatureSensors.c
- History
- Source
- Diff
./Controllers/TemperatureSensors.c
- -3
- +9
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h
- -1
- +1
./Modes/ModeDrain.c
- History
- Source
- Diff
./Modes/ModeDrain.c
- -3
- +7
./Modes/ModeRecirculate.c
- History
- Source
- Diff
./Modes/ModeRecirculate.c
- -32
- +168
./Modes/ModeStandby.c
- History
- Source
- Diff
./Modes/ModeStandby.c
- -1
- +1
./Modes/ModeStandby.h
- History
- Source
- Diff
./Modes/ModeStandby.h
- -5
- +5
./Modes/OperationModes.c
- History
- Source
- Diff
./Modes/OperationModes.c
- -1
- +2
./Services/AlarmMgmt.c
- History
- Source
- Diff
./Services/AlarmMgmt.c
… 8 more files in changeset.

11:57 am

qnguyen (deleted user)

More
Re: DG-DEN-5963-1
commented on review

Should we remove = so we only error when greater than?

11:46 am

Dara Navaei

More
Re: DG-DEN-5963-1
replied to pmontazemi (deleted user)

Done.

11:01 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

11:01 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

11:00 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

11:00 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:59 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:59 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:58 am

Dara Navaei

More
Re: DG-DEN-5963-1
replied to pmontazemi (deleted user)

Done.

10:58 am

Dara Navaei

More
Re: DG-DEN-5963-1
replied to pmontazemi (deleted user)

I uncommented it.

10:57 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:57 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:56 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:54 am

Dara Navaei

More
2326a38
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 216 more DG-DEN-5963-1

DEN-5963 addressed a code review comment

- -0
- +2
./Controllers/ROPump.c
- History
- Source
- Diff
./Controllers/ROPump.c
- -3
- +3
./Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
./Modes/ModeHeatDisinfect.c
- -7
- +7
./Services/AlarmMgmt.c
- History
- Source
- Diff
./Services/AlarmMgmt.c

10:54 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:54 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:54 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:50 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:48 am

qnguyen (deleted user)

More
Re: DG-DEN-5963-1
replied to qnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

10:46 am

Sean Nash

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:45 am

Sean Nash

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

App

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

qnguyen (deleted user)

Dara Navaei

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

Dara Navaei

Dara Navaei

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

Dara Navaei

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

qnguyen (deleted user)

Sean Nash

Sean Nash

Sean Nash

Sean Nash