Activity dgfirmware/firmware/App

4:09 pm

Dara Navaei

More
c48569a
changed 9 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 213 more DG-DEN-8030-1

DEN-8030 debugged and fixed UV reactors driver

- -11
- +11
./Controllers/UVReactors.c
- History
- Source
- Diff
./Controllers/UVReactors.c
… 8 more files in changeset.

11:20 am

Quang Nguyen <qnguyen@diality.com>

More
c76b192
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 209 more DG-DEN-7802-1

DEN-7802: Addressed code review

- -2
- +2
./Controllers/ConcentratePumps.c
- History
- Source
- Diff
./Controllers/ConcentratePumps.c

10:47 am

pmontazemi (deleted user)

More
Re: DG-DEN-7802-1
commented on review

The if should be < and the else if should be >= otherwise there is double-dipping in case the value equals.

10:01 am

Dara Navaei

More
DG-DEN-7568-1
Closed

5:43 pm

Dara Navaei

More
8b8b9bb
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 added reservoir check to heat disinfect

- -49
- +43
./Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
./Modes/ModeHeatDisinfect.c

4:33 pm

Dara Navaei

More
e86af65
changed 5 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 tested mode flush

- -3
- +7
./Modes/ModeFlush.c
- History
- Source
- Diff
./Modes/ModeFlush.c
- -0
- +3
./Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
./Modes/ModeHeatDisinfect.c
- -0
- +14
./Services/Reservoirs.c
- History
- Source
- Diff
./Services/Reservoirs.c
- -0
- +1
./Services/Reservoirs.h
- History
- Source
- Diff
./Services/Reservoirs.h
… 1 more file in changeset.

3:19 pm

Quang Nguyen <qnguyen@diality.com>

More
145a82b
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 209 more DG-DEN-7802-1

DEN-7802: Change flush line RO pump rate to 0.6

- -1
- +1
./Modes/ModeRecirculate.c
- History
- Source
- Diff
./Modes/ModeRecirculate.c

11:05 am

qnguyen (deleted user)

More
DG-DEN-7802-1
started review

DG-DEN-7802_DG-DEV Dialysate Generation

10:33 am

Sean Nash

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:17 am

Dara Navaei

More
34ed52c
changed 4 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 addressed code review comments

- -5
- +12
./Controllers/Heaters.c
- History
- Source
- Diff
./Controllers/Heaters.c
- -14
- +39
./Controllers/TemperatureSensors.c
- History
- Source
- Diff
./Controllers/TemperatureSensors.c
- -24
- +24
./Controllers/TemperatureSensors.h
- History
- Source
- Diff
./Controllers/TemperatureSensors.h
- -18
- +22
./Modes/ModeFlush.c
- History
- Source
- Diff
./Modes/ModeFlush.c

10:16 am

Dara Navaei

More
Re: DG-DEN-7568-1
replied to qnguyen (deleted user)

Done.

10:36 pm

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
commented on review

This struct needs doxygen comment on individual member.

9:00 am

Dara Navaei

More
1a7b3fd
changed 3 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 added more states to flush mode

- -1
- +1
./Controllers/ROPump.c
- History
- Source
- Diff
./Controllers/ROPump.c
- -1
- +1
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h
- -81
- +134
./Modes/ModeFlush.c
- History
- Source
- Diff
./Modes/ModeFlush.c

11:04 am

Dara Navaei

More
Re: DG-DEN-7568-1
replied to Sean Nash

Moved this function to the FaultMode.c.

11:04 am

Dara Navaei

More
d792668
changed 6 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 added more states to DG flush mode

- -0
- +1
./Controllers/Heaters.c
- History
- Source
- Diff
./Controllers/Heaters.c
- -1
- +40
./Modes/ModeFault.c
- History
- Source
- Diff
./Modes/ModeFault.c
- -0
- +2
./Modes/ModeFault.h
- History
- Source
- Diff
./Modes/ModeFault.h
- -80
- +121
./Modes/ModeFlush.c
- History
- Source
- Diff
./Modes/ModeFlush.c
- -0
- +1
./Modes/ModeFlush.h
- History
- Source
- Diff
./Modes/ModeFlush.h
- -1
- +0
./Modes/ModeRecirculate.c
- History
- Source
- Diff
./Modes/ModeRecirculate.c

3:59 pm

Quang Nguyen <qnguyen@diality.com>

More
25a1a0d
changed 2 files
develop_1-24

Merge branch 'DEN-7802-dg_dev-dialysate-generation' into develop

- -3
- +3
./Controllers/Heaters.c
- History
- Source
- Diff
./Controllers/Heaters.c
- -1
- +2
./Controllers/TemperatureSensors.c
- History
- Source
- Diff
./Controllers/TemperatureSensors.c

3:53 pm

Quang Nguyen <qnguyen@diality.com>

More
79970a6
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 209 more DG-DEN-7802-1

DEN-7802: Fixed heater running during off state

- -3
- +3
./Controllers/Heaters.c
- History
- Source
- Diff
./Controllers/Heaters.c

11:41 am

Sean Nash

More
4255fcb
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more DG-DEN-7605-1

DEN-7605: Removed heater start from recirculate mode.

- -1
- +0
./Modes/ModeRecirculate.c
- History
- Source
- Diff
./Modes/ModeRecirculate.c

10:36 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:34 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:34 am

Dara Navaei

More
eb6220e
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1

DEN-7568 addressed a code review comment

- -1
- +0
./Modes/ModeFlush.c
- History
- Source
- Diff
./Modes/ModeFlush.c

10:34 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:34 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in

10:17 am

Dara Navaei

More
24fd189
changed 7 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1

DEN-7568 addressed code review comments

- -19
- +25
./Modes/ModeFlush.c
- History
- Source
- Diff
./Modes/ModeFlush.c
- -1
- +1
./Modes/ModeFlush.h
- History
- Source
- Diff
./Modes/ModeFlush.h
- -3
- +0
./Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
./Modes/ModeHeatDisinfect.c
- -2
- +2
./Modes/ModeStandby.c
- History
- Source
- Diff
./Modes/ModeStandby.c
- -14
- +0
./Services/Reservoirs.c
- History
- Source
- Diff
./Services/Reservoirs.c
- -2
- +0
./Services/Reservoirs.h
- History
- Source
- Diff
./Services/Reservoirs.h
- -4
- +2
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c

10:16 am

Dara Navaei

More
Re: DG-DEN-7568-1
replied to qnguyen (deleted user)

Done.

App

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Quang Nguyen <qnguyen@diality.com>

pmontazemi (deleted user)

Dara Navaei

Dara Navaei

Dara Navaei

Quang Nguyen <qnguyen@diality.com>

qnguyen (deleted user)

Sean Nash

qnguyen (deleted user)

Dara Navaei

Dara Navaei

qnguyen (deleted user)

Dara Navaei

Dara Navaei

Dara Navaei

Quang Nguyen <qnguyen@diality.com>

Quang Nguyen <qnguyen@diality.com>

Sean Nash

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

Dara Navaei

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

Dara Navaei

Dara Navaei