dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 17 Jan 2023
3:28 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Code review correction

Options
    • -6
    • +1
    ./Controllers/Thermistors.c
3:08 pm

wbracken  (deleted user)

Seems like there are several variables missing.

Seems like there are several variables missing.

3:01 pm

Dara Navaei

DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9
DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9
2:43 pm

wbracken  (deleted user)

Updated comment

Updated comment

2:28 pm

wbracken  (deleted user)

Removed

Removed

2:27 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13676 Correction per code review

Options
    • -2
    • +0
    ./Modes/ModeDrain.c
2:13 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Corrections per code review

Options
    • -3
    • +3
    ./Controllers/LoadCell.c
    • -2
    • +2
    ./Controllers/Pressures.c
    • -6
    • +7
    ./Controllers/Pressures.h
    • -2
    • +2
    ./Controllers/TemperatureSensors.c
    • -22
    • +23
    ./Controllers/TemperatureSensors.h
    • -4
    • +4
    ./Controllers/Thermistors.c
    • -4
    • +5
    ./Controllers/Thermistors.h
1:49 pm

Sean Nash

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

1:43 pm

Sean Nash

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.

1:41 pm

Sean Nash

Does hasAlarmBeenTriggered need to be set here too? If not, need to clarify what that flag really means.

Does hasAlarmBeenTriggered need to be set here too? If not, need to clarify what that flag really means.

1:36 pm

Sean Nash

Need to be careful with these. These functions are currently resetting the POST functions to start at beginning, but also need to reset ANY variables that the POST functions use/set (not override v...

Need to be careful with these.
These functions are currently resetting the POST functions to start at beginning, but also need to reset ANY variables that the POST functions use/set (not override variables though).
Also, since we are not re-initializing everything like a true reset does, we need to make sure that these modules are setup to restart or resume (whichever is more appropriate for the module) after POST completes if the module is in any way interrupted/deferred by POST or competing with POST for a resource/driver (e.g. RTC or NV-Data).

1:24 pm

Sean Nash

Variable should already be a BOOL.

Variable should already be a BOOL.

1:24 pm

Sean Nash

Set to TRUE here.

Set to TRUE here.

1:23 pm

Sean Nash

Initialize to FALSE.

Initialize to FALSE.

1:23 pm

Sean Nash

Rename to isDGFaultActive.

Rename to isDGFaultActive.

1:22 pm

Sean Nash

Name is too broad and comment is too specific. Should probably be a BOOL flag that indicates there is an active DG fault.

Name is too broad and comment is too specific. Should probably be a BOOL flag that indicates there is an active DG fault.

1:17 pm

Sean Nash

This alarm does not appear to be available. Correct description in last column (trigger condition).

This alarm does not appear to be available. Correct description in last column (trigger condition).

1:08 pm

Sean Nash

Do we need to re-queue these reads? We've already done it at real POST. And if we do need to queue them, why does queue have to be empty? Shouldn't we always queue them if they're needed?

Do we need to re-queue these reads? We've already done it at real POST. And if we do need to queue them, why does queue have to be empty? Shouldn't we always queue them if they're needed?

1:05 pm

James Walter Taylor <jtaylor@diality.com>

HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug

Corrected _RELEASE_ logic, release build executes the same block as non debug selection

Options
    • -4
    • +4
    ./Controllers/ConcentratePumps.c
12:03 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:00 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:20 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Make monitor functions for pressure, temperature, thermistors and load cells consistent. Address code review comments.

Options
    • -24
    • +24
    ./Controllers/LoadCell.c
    • -7
    • +7
    ./Controllers/Pressures.c
    • -11
    • +11
    ./Controllers/TemperatureSensors.c
    • -6
    • +7
    ./Controllers/Thermistors.c
10:38 am

Dara Navaei

DEN-14559 added functions to reset the POST states of the drivers that have a POST state machine for the command to request POST again

Options
    • -2
    • +2
    ./Controllers/ConductivitySensors.c
    • -0
    • +12
    ./Controllers/Pressures.c
    • -1
    • +2
    ./Controllers/Pressures.h
    • -2
    • +2
    ./Controllers/TemperatureSensors.c
    • -3
    • +16
    ./Controllers/UVReactors.c
    • -0
    • +2
    ./Controllers/UVReactors.h
    • -0
    • +12
    ./Drivers/SafetyShutdown.c
    • -0
    • +1
    ./Drivers/SafetyShutdown.h
    • -1
    • +7
    ./Modes/ModeChemicalDisinfectFlush.c
    • -5
    • +13
    ./Modes/ModeInitPOST.c
    • -12
    • +14
    ./Modes/OperationModes.c
    • -0
    • +12
    ./Services/WatchdogMgmt.c
    • -0
    • +1
    ./Services/WatchdogMgmt.h
9:39 am

Sean Nash

Is this #define still used/needed?

Is this #define still used/needed?

Monday 16 Jan 2023
4:45 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Do not process thermistor alarms if in DG_INIT

Options
    • -1
    • +2
    ./Controllers/Thermistors.c
3:01 pm

Dara Navaei

DG-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug
DG-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug
1:57 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13676 Correct acid calculation

Options
    • -1
    • +1
    ./Modes/ModeDrain.c
1:42 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Code review correction

Options
    • -1
    • +0
    ./Controllers/Thermistors.c
12:11 pm

wbracken  (deleted user)

Alignment

Alignment

10:55 am

jtaylor  (deleted user)

Alignment

Alignment