Activity dgfirmware/firmware/App

4:50 pm

Dara Navaei

More
885c00a
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13972-flush-bubbles-ro-pump-state-does-not-match-srsdg-844 and 159 more DG-DEN-13972-1

DEN-13972 changed the code in the heaters to consider if the temperatures are negative and therefore the duty cycle is not set to positive artificially

- -4
- +6
./Controllers/Heaters.c
- History
- Source
- Diff
./Controllers/Heaters.c

3:01 pm

Dara Navaei

More
DG-DEN-13972-1
started review

DG-DEN-13972_Flush Bubbles RO Pump State Does Not Match Srsdg 844

1:37 pm

Dara Navaei

More
13ad8ae
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13972-flush-bubbles-ro-pump-state-does-not-match-srsdg-844 and 159 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h

1:37 pm

Dara Navaei

More
3603cf1
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13972-flush-bubbles-ro-pump-state-does-not-match-srsdg-844 and 159 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./Modes/OperationModes.c
- History
- Source
- Diff
./Modes/OperationModes.c

1:34 pm

Dara Navaei

More
5e87586
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13972-flush-bubbles-ro-pump-state-does-not-match-srsdg-844 and 159 more DG-DEN-13972-1

DEN-13972 changed the order of increment in the bubble fill to make sure to 0 index does not run twice

- -2
- +2
./Modes/ModeFill.c
- History
- Source
- Diff
./Modes/ModeFill.c

10:27 am

wbracken (deleted user)

More
DG-DEN-14547-1
finished reviewing

7:53 am

Michael Garthwaite

More
7b88c90
changed 3 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14316-chemical-disinfect and 156 more DG-DEN-14589-1

Merge branch 'staging' into DEN-14589-DIAL-211

- -1
- +7
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c
- -1
- +65
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -1
- +6
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h

2:14 pm

Sean Nash

More
DG-DEN-14547-1
finished reviewing

2:14 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

2:14 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

2:13 pm

Sean Nash

You're right. RESOLVED in CODE WALKTHROUGH.

You're right.
RESOLVED in CODE WALKTHROUGH.

2:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

2:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

1:47 pm

More
4bc08dc
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13972-flush-bubbles-ro-pump-state-does-not-match-srsdg-844 and 160 more DG-DEN-14547-1

DEN-14547: Addressing code review comments.

- -7
- +6
./Modes/OperationModes.c
- History
- Source
- Diff
./Modes/OperationModes.c

1:37 pm

Michael Garthwaite

More
Re: DG-DEN-14547-1
replied to Sean Nash

transitionToNewOperationMode() is currently void. This would have to change to returning the submode enum. This was an issue found in testing the events that we miss the event transition from going...

transitionToNewOperationMode() is currently void. This would have to change to returning the submode enum. This was an issue found in testing the events that we miss the event transition from going to new modes and needed the code change down at line ~380.

Do we want to change transitionToNewOperationMode() to return sub mode?

1:25 pm