dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 03 Mar 2023
2:34 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
2:34 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/Heaters.c
    • -2
    • +2
    ./Modes/ModeFlush.c
2:33 pm

Michael Garthwaite

2:32 pm

wbracken  (deleted user) and jtaylor  (deleted user)

Thursday 02 Mar 2023
10:29 am

Michael Garthwaite

I believe this MSG_ID is being removed in another branch

I believe this MSG_ID is being removed in another branch

10:28 am

Michael Garthwaite

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2 Ill reorganize ...

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2
Ill reorganize the review naming shortly.

10:21 am

Sean Nash

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

10:19 am

Sean Nash

Is this a response to request above or a data broadcast?

Is this a response to request above or a data broadcast?

10:18 am

Sean Nash

Should this have _REQUEST added to end?

Should this have _REQUEST added to end?

10:13 am

Sean Nash

10:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:23 am

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Wednesday 01 Mar 2023
2:50 pm

Michael Garthwaite

Merge branch 'staging' into DEN-14788-DIAL-222

Options
    • -5
    • +5
    ./Modes/ModeFlush.c
2:49 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:49 pm

Michael Garthwaite

DEN-14788: code review comments

Options
    • -1
    • +1
    ./Controllers/Heaters.c
2:33 pm

Dara Navaei

DEN-14834 updated the code to not check the rejection ratio and CPo if the target fill is less than 550 mL. Updated the heaters code to make sure the stop heaters command stops the heaters unless a new start command is issued

Options
    • -31
    • +39
    ./Controllers/Heaters.c
    • -11
    • +15
    ./Modes/ModeFill.c
1:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:10 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:10 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:09 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
10:00 am

Michael Garthwaite

Merge branch 'DEN-14689-messaging-bugs' into develop

Options
    • -1
    • +1
    ./Controllers/LoadCell.c
    • -4
    • +4
    ./Services/SystemComm.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
10:00 am

Michael Garthwaite

Merge branch 'staging' into DEN-14689-messaging-bugs

Options
    • -3
    • +3
    ./Services/SystemComm.c
    • -7
    • +2
    ./Services/SystemCommMessages.c
9:59 am

Michael Garthwaite

DEN-14689: message naming synchronization.

Options
    • -1
    • +1
    ./Controllers/FluidLeak.c
    • -1
    • +1
    ./Controllers/LoadCell.c
    • -1
    • +1
    ./Controllers/Valves.c
    • -1
    • +1
    ./Modes/ModeStandby.c
    • -1
    • +1
    ./Modes/OperationModes.c
    • -4
    • +4
    ./Services/SystemComm.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
9:53 am

Dara Navaei

DEN-14763 updated the cleaning modes

Options
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
Monday 27 Feb 2023
3:15 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
3:15 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    ./Modes/ModeFlush.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
3:15 pm

Dara Navaei

3:12 pm

wbracken  (deleted user) , Michael Garthwaite and Sean Nash

3:12 pm

dcox  (deleted user)

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.