dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Jul 2023
4:16 pm

Darren Cox <darren_m@cox.net>

DEN-15702 Code review update - remove spaces.

Options
    • -1
    • +1
    ./Controllers/ConductivitySensors.c
    • -1
    • +1
    ./Controllers/Pressures.c
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
4:02 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
3:55 pm

Sean Nash and jtaylor  (deleted user)

3:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:52 pm

Sean Nash

But you can be "not in safe state" and not have the heater on (e.g. in standby mode). Is this voltage always 24V even when the heater is off?

But you can be "not in safe state" and not have the heater on (e.g. in standby mode). Is this voltage always 24V even when the heater is off?

3:50 pm

wbracken  (deleted user)

It is only monitored when not in safe state. Reviewed with Blaine.

It is only monitored when not in safe state. Reviewed with Blaine.

3:44 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:41 pm

Sean Nash

Remove gap before "=" as alignment no longer relevant.

Remove gap before "=" as alignment no longer relevant.

3:41 pm

Sean Nash

Remove gap before "=" as alignment no longer relevant.

Remove gap before "=" as alignment no longer relevant.

3:41 pm

Sean Nash

Remove gap before "=" as alignment no longer relevant.

Remove gap before "=" as alignment no longer relevant.

3:34 pm

Darren Cox <darren_m@cox.net>

DEN-15702 Indent for code review comments.

Options
    • -57
    • +57
    ./Controllers/ConductivitySensors.c
    • -44
    • +44
    ./Controllers/Pressures.c
    • -49
    • +49
    ./Controllers/TemperatureSensors.c
3:32 pm

Sean Nash

Won't this voltage go to zero when heater is off?

Won't this voltage go to zero when heater is off?

2:30 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
2:26 pm

Dara Navaei

Changed the heat disinfect transfer rate from 800 mL/min to 500 mL/min

Options
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
2:08 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
2:02 pm

Dara Navaei

DG-DEN-15608_Alarm 77 Failing TO Trigger For Lower Bound Values
DG-DEN-15608_Alarm 77 Failing TO Trigger For Lower Bound Values
2:00 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15608 Correct monitoring of voltages

Options
    • -2
    • +2
    ./Controllers/Voltages.c
1:32 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:30 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:28 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:27 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:27 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:26 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:19 pm

Dara Navaei

Merge branch 'staging' into DEN-15660-test_configuration_treatment_recovery

Options
    • -22
    • +54
    ./Controllers/ConcentratePumps.c
    • -6
    • +11
    ./Modes/ModeFlush.c
    • -3
    • +3
    ./Modes/ModeHeatDisinfect.c
    • -2
    • +9
    ./Modes/ModeHeatDisinfectActiveCool.c
    • -3
    • +6
    ./Services/SystemCommMessages.c
11:15 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
11:15 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/ROPump.c
11:12 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
11:07 am

wbracken  (deleted user)

11:04 am

Dara Navaei

Merge branch 'DEN-15660-test_configuration_treatment_recovery' into develop

Options
    • -12
    • +2
    ./Modes/ModeFill.c
11:00 am

Dara Navaei

DEN-15660 addressed the code review comments

Options
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
    • -4
    • +7
    ./Modes/ModeGenIdle.c