dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 29 Sep 2023
11:16 am

jtaylor  (deleted user)

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

11:14 am

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH. (with nausea)

RESOLVED in CODE WALKTHROUGH. (with nausea)

11:11 am

jtaylor  (deleted user)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

Thursday 28 Sep 2023
8:56 am

Dara Navaei

Done

Done

8:33 am

Dara Navaei

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

8:31 am

Dara Navaei

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp o...

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

Wednesday 27 Sep 2023
4:40 pm

jtaylor  (deleted user)

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5). I would suggest using the ifdef within the body of the default clause, even ...

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

1:07 pm

Sean Nash

What's left? When would this code ever become reachable?

What's left? When would this code ever become reachable?

8:30 am

jtaylor  (deleted user)

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

Wednesday 20 Sep 2023
1:30 pm

Dara Navaei

1:26 pm

wbracken  (deleted user) and Sean Nash

Tuesday 19 Sep 2023
4:18 pm

Michael Garthwaite

2:07 pm

Dara Navaei

DG-DEN-16446_DG Dev Test Clean UP
DG-DEN-16446_DG Dev Test Clean UP
1:18 pm

Dara Navaei

11:40 am

Sean Nash

11:33 am

Dara Navaei

11:33 am

Dara Navaei

9:03 am

Dara Navaei

DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low 2
DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low 2
9:03 am

Dara Navaei

DG-DEN-16382_Alarm 207 DG Flow Meter Check Failure Triggers After Alarm 282 Bicarbonate Volume
DG-DEN-16382_Alarm 207 DG Flow Meter Check Failure Triggers After Alarm 282 Bicarbonate Volume
Monday 18 Sep 2023
10:49 am

Michael Garthwaite

10:42 am

wbracken  (deleted user) and Dara Navaei

Friday 15 Sep 2023
4:39 pm

jtaylor  (deleted user)

4:36 pm

Dara Navaei , Sean Nash and wbracken  (deleted user)

4:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:55 pm

jtaylor  (deleted user)

Dara suggested removing this, as the feature was incomplete and appears to cause odd timer/alarm behavior.

Dara suggested removing this, as the feature was incomplete and appears to cause odd timer/alarm behavior.

3:31 pm

Dara Navaei

2:43 pm

jtaylor  (deleted user) , wbracken  (deleted user) and Sean Nash

Thursday 14 Sep 2023
4:23 pm

Sean Nash

You are removing recover treatment test config functionality? Is this moving somewhere else or we've decided not to implement?

You are removing recover treatment test config functionality? Is this moving somewhere else or we've decided not to implement?

4:05 pm

Dara Navaei

DG-DIAL-285_Event Log 15 Missing Fill Prime Concentrate State
DG-DIAL-285_Event Log 15 Missing Fill Prime Concentrate State
10:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.