dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Apr 2021
6:25 pm

Sean Nash

DEN-7605: Integrated DG voltage monitor into DG f/w.

Options
    • -1
    • +5
    ./App/Tasks/TaskGeneral.c
    • -0
    • +2
    ./source/sys_main.c
6:22 pm

Sean Nash

DEN-7605: Added new DG voltages monitor module. Updated internal ADC driver.

Options
    • -0
    • +454
    ./App/Controllers/Voltages.c
    • -0
    • +89
    ./App/Controllers/Voltages.h
    • -2
    • +56
    ./App/Drivers/InternalADC.c
    • -4
    • +6
    ./App/Drivers/InternalADC.h
    • -0
    • +8
    ./App/Services/SystemComm.c
    • -0
    • +92
    ./App/Services/SystemCommMessages.c
    • -0
    • +10
    ./App/Services/SystemCommMessages.h
    • -11
    • +11
    ./DG.dil
    • -1
    • +1
    ./include/adc.h
    • -5
    • +5
    ./source/adc.c
4:24 pm

qnguyen  (deleted user)

Only two places call this function. Should we inline and remove this function?

Only two places call this function. Should we inline and remove this function?

3:08 pm

Dara Navaei

DEN-7568 merged staging and resolved merge conflicts

Options
    • -0
    • +8
    ./.launches/DG.launch
    • -27
    • +21
    ./App/Controllers/ROPump.c
    • -82
    • +85
    ./App/Controllers/TemperatureSensors.c
    • -35
    • +191
    ./App/Modes/ModeStandby.c
    • -1
    • +3
    ./App/Modes/ModeStandby.h
    • -0
    • +8
    ./App/Services/AlarmMgmt.h
    • -91
    • +87
    ./App/Services/Reservoirs.c
    • -23
    • +36
    ./App/Services/Reservoirs.h
    • -5
    • +46
    ./App/Services/SystemComm.c
    • -55
    • +533
    ./App/Services/SystemCommMessages.c
    • -5
    • +57
    ./App/Services/SystemCommMessages.h
12:19 pm

qnguyen  (deleted user)

Check and remove unused include (ConductivitySensors.h, TemperatureSensors.h, etc.)

Check and remove unused include (ConductivitySensors.h, TemperatureSensors.h, etc.)

12:17 pm

qnguyen  (deleted user)

Remove unused defines

Remove unused defines

12:15 pm

qnguyen  (deleted user)

Align or remove extra space.

Align or remove extra space.

12:12 pm

qnguyen  (deleted user)

Should result be set the the return of startDGFlush() and stopDGFlush() functions?

Should result be set the the return of startDGFlush() and stopDGFlush() functions?

12:11 pm

qnguyen  (deleted user)

Update to latest revision. This function should be deleted.

Update to latest revision. This function should be deleted.

12:05 pm

Dara Navaei

DEN-7568 work in progress

Options
    • -44
    • +39
    ./App/Modes/ModeFlush.c
12:05 pm

qnguyen  (deleted user)

DG_MODE_SOLO does not have DG_STANDBY_MODE_STATE_IDLE.

DG_MODE_SOLO does not have DG_STANDBY_MODE_STATE_IDLE.

12:03 pm

Dara Navaei

12:01 pm

qnguyen  (deleted user)

Revert the deleted comment.

Revert the deleted comment.

11:35 am

qnguyen  (deleted user) , pmontazemi  (deleted user) and Sean Nash

10:55 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Dara Navaei

DEN-5963 addressed a code review comment

Options
    • -1
    • +1
    ./App/Controllers/Thermistors.c
10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:42 am

Dara Navaei

DEN-5963 addressed code review comments

Options
    • -21
    • +0
    ./.launches/DG.launch
    • -1
    • +1
    ./App/Controllers/Heaters.c
    • -1
    • +1
    ./App/Controllers/ROPump.c
    • -17
    • +36
    ./App/Controllers/TemperatureSensors.c
    • -0
    • +29
    ./App/Controllers/TemperatureSensors.h
    • -1
    • +1
    ./App/Controllers/Thermistors.c
    • -3
    • +4
    ./App/Modes/ModeHeatDisinfect.c
    • -5
    • +4
    ./App/Services/SystemCommMessages.c
    • -2
    • +3
    ./App/Services/SystemCommMessages.h
Tuesday 20 Apr 2021
11:05 pm

Dara Navaei

Monday 19 Apr 2021
8:45 pm

Dara Navaei

I removed the = sign.

I removed the = sign.

2:00 pm

Dara Navaei

DEN-5963 remerged staging

Options
    • -0
    • +16
    ./.launches/DG.launch
    • -14
    • +14
    ./App/Controllers/ConcentratePumps.c
    • -2
    • +2
    ./App/Controllers/ConcentratePumps.h
    • -2
    • +13
    ./App/Controllers/DrainPump.c
    • -15
    • +14
    ./App/Controllers/Heaters.c
    • -57
    • +152
    ./App/Controllers/LoadCell.c
    • -1
    • +2
    ./App/Controllers/LoadCell.h
    • -1
    • +3
    ./App/Controllers/Pressures.c
    • -1
    • +3
    ./App/Controllers/TemperatureSensors.c
    • -3
    • +9
    ./App/DGCommon.h
    • -1
    • +1
    ./App/Modes/ModeDrain.c
    • -3
    • +7
    ./App/Modes/ModeRecirculate.c
    • -32
    • +168
    ./App/Modes/ModeStandby.c
    • -1
    • +1
    ./App/Modes/ModeStandby.h
    • -5
    • +5
    ./App/Modes/OperationModes.c
  16. … 8 more files in changeset.
11:57 am

qnguyen  (deleted user)

Should we remove = so we only error when greater than?

Should we remove = so we only error when greater than?

11:46 am

Dara Navaei

Done.

Done.

11:01 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:01 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:00 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:00 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:59 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:59 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.