dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 03 Feb 2023
9:02 am

Dara Navaei

Merge branch 'staging' into DEN-14604-dg_hd_dev-hd_dg_dvt-update-part-9

Options
    • -4
    • +5
    ./App/Controllers/Pressures.c
    • -6
    • +4
    ./App/Modes/ModeFill.c
    • -3
    • +6
    ./App/Modes/ModeStandby.c
8:59 am

Dara Navaei

DEN-14604 added comments

Options
    • -0
    • +4
    ./App/Modes/ModeChemicalDisinfect.c
    • -0
    • +4
    ./App/Modes/ModeHeatDisinfect.c
8:51 am

Dara Navaei

DEN-14604 added Nelson labs heat disinfect positive control mode

Options
    • -2
    • +2
    ./App/Controllers/Heaters.c
    • -0
    • +7
    ./App/Modes/ModeFault.c
    • -32
    • +57
    ./App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    ./App/Modes/ModeHeatDisinfect.h
    • -1
    • +4
    ./App/Modes/ModeStandby.c
    • -4
    • +10
    ./App/Services/SystemCommMessages.c
8:36 am

Dara Navaei

Done.

Done.

8:35 am

Dara Navaei

Let's keep this broadcast until this project is finished.

Let's keep this broadcast until this project is finished.

8:34 am

Dara Navaei

Done.

Done.

8:31 am

Dara Navaei

Removed the code.

Removed the code.

8:27 am

Dara Navaei

Done

Done

8:25 am

Dara Navaei

Done.

Done.

8:25 am

Dara Navaei

Done

Done

8:24 am

Dara Navaei

This include is no longer needed.

This include is no longer needed.

8:23 am

Dara Navaei

These values are temporary and only when we build a debug code. So I prefer not to have a #define for them.

These values are temporary and only when we build a debug code. So I prefer not to have a #define for them.

Thursday 02 Feb 2023
6:29 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
5:43 pm

wbracken  (deleted user)

Maybe #define?

Maybe #define?

4:20 pm

Dara Navaei

DEN-14604, DEN-14761 updated the Nelson labs support code and added inlet water pressure high in the fill mode

Options
    • -2
    • +1
    ./App/Modes/ModeChemicalDisinfect.c
    • -1
    • +0
    ./App/Modes/ModeChemicalDisinfect.h
    • -0
    • +1
    ./App/Modes/ModeFill.c
    • -13
    • +0
    ./App/Modes/ModeHeatDisinfect.h
    • -1
    • +5
    ./App/Modes/ModeStandby.c
2:13 pm

wbracken  (deleted user)

Remove blank line

Remove blank line

1:42 pm

Michael Garthwaite

DEN-14547: fixed dg events to be called in transition op mode.

Options
    • -0
    • +7
    ./App/Modes/OperationModes.c
9:01 am

Sean Nash

#ifndef RELEASE.

#ifndef RELEASE.

8:53 am

Sean Nash

This is an input.

This is an input.

8:44 am

Sean Nash

Just include HDCommon.h and it will include things like this.

Just include HDCommon.h and it will include things like this.

8:41 am

Dara Navaei

DEN-14604 work in progress. Tested and updated the Nelson support

Options
    • -5
    • +21
    ./App/Controllers/ConductivitySensors.c
    • -1
    • +13
    ./App/Controllers/Heaters.c
    • -0
    • +2
    ./App/Controllers/Heaters.h
    • -22
    • +50
    ./App/Modes/ModeChemicalDisinfect.c
    • -0
    • +5
    ./App/Modes/ModeChemicalDisinfect.h
    • -79
    • +98
    ./App/Modes/ModeHeatDisinfect.c
    • -6
    • +6
    ./App/Services/SystemCommMessages.c
8:31 am

Sean Nash

Declarations at top of scope.

Declarations at top of scope.

8:28 am

Sean Nash

For a blank case like this, we should add a comment making it clear no action is intended.

For a blank case like this, we should add a comment making it clear no action is intended.

8:27 am

Sean Nash

Even in release build?

Even in release build?

8:27 am

Sean Nash

Not fault mode?

Not fault mode?

8:22 am

Sean Nash

Alignment. Do we even need this. Will get reset on transition back to heat disinfect.

Alignment. Do we even need this. Will get reset on transition back to heat disinfect.

8:17 am

Sean Nash

Even in release build?

Even in release build?

8:17 am

Sean Nash

Is this necessary? We're faulting. Won't be coming back. Even if we did come back, wouldn't init set this?

Is this necessary? We're faulting. Won't be coming back. Even if we did come back, wouldn't init set this?

8:07 am

Sean Nash

Temporary?

Temporary?

8:07 am

Sean Nash

Is this temporary? Should it have #ifndef RELEASE?

Is this temporary? Should it have #ifndef RELEASE?