firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-14689-messaging-bugs' into develop

Merge branch 'staging' into DEN-14689-messaging-bugs

DEN-14689: message naming synchronization.

DEN-14763 updated the cleaning modes

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    ./App/Modes/ModeChemicalDisinfectFlush.c
Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

Remove old function call.

Remove old function call.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DEN-14859 addressed a code review comment

Removed one. Thanks.

Removed one. Thanks.

This variable is assigned twice in this init function

This variable is assigned twice in this init function

DEN-14859 addressed a code review comment

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

Removed the variables.

Removed the variables.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

I removed the variable from the documentation.

I removed the variable from the documentation.

rsrvrFillStableTimeCounter is no longer used in getRsrvrDrainStatus()

rsrvrFillStableTimeCounter is no longer used in getRsrvrDrainStatus()

targetDisinfectTime is only used in publishing. Documentation says its used in getHeatDisinfectStatus but its not used. Is it still needed?

targetDisinfectTime is only used in publishing. Documentation says its used in getHeatDisinfectStatus but its not used. Is it still needed?

DEN-14859 updated the code

DG-DEN-14859_Cleaning Modes State Timer Reset
DG-DEN-14859_Cleaning Modes State Timer Reset
DEN-14859 updated the state timers of the cleaning modes

    • -1
    • +1
    ./App/Modes/ModeChemicalDisinfectFlush.c
Add space between ( and TRUE.

Add space between ( and TRUE.

I don't see DG changes using new ENUM names.

I don't see DG changes using new ENUM names.

Remove "endif" at end of comment?

Remove "endif" at end of comment?

What is this setting and why did it change?

What is this setting and why did it change?

extra CR/LF deleted; two statements on one line.

extra CR/LF deleted; two statements on one line.