dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Jul 2023
11:04 am

Dara Navaei

Merge branch 'DEN-15660-test_configuration_treatment_recovery' into develop

Options
    • -12
    • +2
    ./App/Modes/ModeFill.c
11:00 am

Dara Navaei

DEN-15660 addressed the code review comments

Options
    • -1
    • +1
    ./App/Controllers/TemperatureSensors.c
    • -4
    • +7
    ./App/Modes/ModeGenIdle.c
10:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:53 am

Michael Garthwaite and jtaylor  (deleted user)

10:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:51 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:51 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:50 am

Sean Nash

TRo needs comment for doxygen.

TRo needs comment for doxygen.

10:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:47 am

Dara Navaei

DEN-15660 addressed the code review comments

Options
    • -5
    • +5
    ./App/Controllers/TemperatureSensors.c
    • -21
    • +24
    ./App/Modes/ModeChemicalDisinfect.c
    • -2
    • +0
    ./App/Modes/ModeDrain.c
    • -12
    • +2
    ./App/Modes/ModeFill.c
    • -28
    • +16
    ./App/Modes/ModeGenIdle.c
    • -2
    • +0
    ./App/Modes/ModeGenIdle.h
9:58 am

Dara Navaei

Nelson is not part of the commercial code.

Nelson is not part of the commercial code.

9:57 am

Dara Navaei

Done

Done

9:08 am

Dara Navaei

Done

Done

9:06 am

Dara Navaei

Done

Done

8:53 am

Dara Navaei

Nelson support is only in debug mode.

Nelson support is only in debug mode.

8:51 am

Dara Navaei

Done

Done

8:49 am

Dara Navaei

Done

Done

8:47 am

Dara Navaei

The un-averaged TDi and TRo are used for dialysate temperature checking and trimmer heater control I think we should keep them to be able to have a full picture if needed unless the CAN bus is real...

The un-averaged TDi and TRo are used for dialysate temperature checking and trimmer heater control I think we should keep them to be able to have a full picture if needed unless the CAN bus is really flooded.

8:44 am

Dara Navaei

This is a time and not timeout.

This is a time and not timeout.

8:42 am

Dara Navaei

Done

Done

8:41 am

Dara Navaei

Done

Done

8:39 am

Dara Navaei

Done

Done

8:39 am

Dara Navaei

Done

Done

Tuesday 11 Jul 2023
5:42 pm

wbracken  (deleted user)

Correct indentation

Correct indentation

5:42 pm

wbracken  (deleted user)

Correct indentation

Correct indentation

5:41 pm

wbracken  (deleted user)

Indentation needs to be corrected.

Indentation needs to be corrected.

5:30 pm

wbracken  (deleted user)

handleEmptyBottleFlag is only an input

handleEmptyBottleFlag is only an input

4:03 pm

Dara Navaei

DG-DEN-15702_Alarm 150 Inlet Water Conductivity High Does Not Disappear ON Standby Screen When
DG-DEN-15702_Alarm 150 Inlet Water Conductivity High Does Not Disappear ON Standby Screen When