hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 30 Jul 2021
4:36 pm

Dara Navaei

Merged DEN-9054_HD DG switches

Options
    • -17
    • +71
    /firmware/App/Controllers/BloodFlow.c
    • -16
    • +70
    /firmware/App/Controllers/DialInFlow.c
    • -2
    • +0
    /firmware/App/Controllers/DialInFlow.h
    • -2
    • +84
    /firmware/App/Controllers/SyringePump.c
    • -2
    • +3
    /firmware/App/HDCommon.h
    • -18
    • +14
    /firmware/App/Modes/ModeInitPOST.c
    • -0
    • +14
    /firmware/App/Services/FPGA.c
    • -0
    • +3
    /firmware/App/Services/FPGA.h
    • -1
    • +18
    /firmware/App/Services/SystemComm.c
    • -2
    • +186
    /firmware/App/Services/SystemCommMessages.c
    • -5
    • +24
    /firmware/App/Services/SystemCommMessages.h
    • -5
    • +9
    /firmware/App/Tasks/TaskGeneral.c
2:14 pm

Dara Navaei

Done.

Done.

2:09 pm

Dara Navaei

That is right. I removed the parameter.

That is right. I removed the parameter.

2:05 pm

Dara Navaei

I moved it up so it will be run first with respect to the other exec functions. The epoch function is used to set an epoch value to the calibration records that failed but we set them the benign va...

I moved it up so it will be run first with respect to the other exec functions. The epoch function is used to set an epoch value to the calibration records that failed but we set them the benign values.

1:58 pm

Sean Nash

DEN-8886: Added FPGA voltage monitoring and data publication.

Options
    • -0
    • +13
    /firmware/App/Controllers/Voltages.c
    • -0
    • +6
    /firmware/App/Controllers/Voltages.h
    • -1
    • +0
    /firmware/App/HDCommon.h
    • -5
    • +68
    /firmware/App/Services/FPGA.c
    • -0
    • +4
    /firmware/App/Services/FPGA.h
    • -11
    • +0
    /firmware/App/Services/SystemCommMessages.c
1:57 pm

Dara Navaei

I moved this enum to DGDefs.h in HD-DEN-9054.

I moved this enum to DGDefs.h in HD-DEN-9054.

1:35 pm

Dara Navaei

DEN-9054 removed the FPGA power check

Options
    • -13
    • +0
    /firmware/App/Services/FPGA.c
    • -1
    • +0
    /firmware/App/Services/FPGA.h
10:51 am

Sean Nash

Why was this moved?

Why was this moved?

10:50 am

Sean Nash

The message parameter is not used or needed in this function.

The message parameter is not used or needed in this function.

10:47 am

Sean Nash

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

10:45 am

Sean Nash

Do we need a debounce on the switch before changing state?

Do we need a debounce on the switch before changing state?

10:44 am

Sean Nash

Caps?

Caps?

10:42 am

Sean Nash

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

Thursday 29 Jul 2021
8:27 pm

Dara Navaei

DEN-9054 added a check for the switch IDs

Options
    • -3
    • +11
    /firmware/App/Controllers/Switches.c
5:26 pm

Dara Navaei

DEN-9054 addressed the code review comments

Options
    • -4
    • +4
    /firmware/App/Controllers/Switches.c
    • -8
    • +1
    /firmware/App/Controllers/Switches.h
    • -0
    • +1
    /firmware/App/Services/AlarmMgmtSWFaults.h
1:08 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:06 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:06 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:05 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:05 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:04 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:04 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

1:03 pm

qnguyen  (deleted user)

Added additional functions.

Added additional functions.

1:03 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8679: Addressed code review

Options
    • -0
    • +3
    /firmware/App/Modes/ModePostTreat.c
    • -1
    • +1
    /firmware/App/Modes/Rinseback.c
12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.