hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 03 Jan 2022
3:55 pm

Sean Nash

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2

Options
3:55 pm

Sean Nash

DEN-11114: Fixed bug DEN-11663.

Options
    • -1
    • +1
    /firmware/App/Controllers/BloodFlow.c
    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.c
2:38 pm

Dara Navaei

DEN-11114 addressed the code review comments

Options
    • -6
    • +21
    /firmware/App/Controllers/BloodLeak.c
    • -3
    • +3
    /firmware/App/Controllers/DGInterface.c
    • -9
    • +9
    /firmware/App/Controllers/DGInterface.h
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
2:36 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11098 Addressed code review comments

Options
    • -3
    • +0
    /firmware/App/Controllers/BloodFlow.c
    • -22
    • +22
    /firmware/App/Modes/Prime.c
    • -1
    • +1
    /firmware/App/Services/SystemComm.c
1:18 pm

Dara Navaei

11:41 am

hnguyen  (deleted user)

Dara, did you add this alarm?

Dara, did you add this alarm?

11:39 am

hnguyen  (deleted user)

Done.

Done.

11:37 am

hnguyen  (deleted user)

Done.

Done.

11:21 am

hnguyen  (deleted user)

Done.

Done.

10:14 am

Dara Navaei

Done.

Done.

9:45 am

Dara Navaei

Done.

Done.

9:37 am

Dara Navaei

No I do not think so. The CRCs are all checked in the self test.

No I do not think so. The CRCs are all checked in the self test.

9:31 am

Dara Navaei

Done.

Done.

9:31 am

Dara Navaei

Yes, if you add "alarm no alarm" it will not be checked.

Yes, if you add "alarm no alarm" it will not be checked.

9:28 am

Dara Navaei

Done.

Done.

8:53 am

Sean Nash

Magic numbers on these new for loops.

Magic numbers on these new for loops.

8:44 am

Sean Nash

Align comment.

Align comment.

Friday 31 Dec 2021
7:27 pm

Dara Navaei

Done.

Done.

7:25 pm

Dara Navaei

Fixed it.

Fixed it.

7:25 pm

Dara Navaei

Done.

Done.

7:25 pm

Dara Navaei

Done.

Done.

7:22 pm

Dara Navaei

Done.

Done.

Thursday 30 Dec 2021
7:13 pm

Dara Navaei

DEN-11114 addressed the code review comments. DEN-11364 removed the 1 second fans monitor interval

Options
    • -13
    • +8
    /firmware/App/Controllers/BloodLeak.c
    • -1
    • +1
    /firmware/App/Controllers/BloodLeak.h
    • -47
    • +39
    /firmware/App/Controllers/Fans.c
1:14 pm

Sean Nash

Update message list with latest data details.

Update message list with latest data details.

1:13 pm

Sean Nash

Update message list with latest broadcast msg data details.

Update message list with latest broadcast msg data details.

1:09 pm

Sean Nash

We don't need to calculate digit count - just use strlen(tempCharBuffer) after sprintf creates your string.

We don't need to calculate digit count - just use strlen(tempCharBuffer) after sprintf creates your string.

1:08 pm

Sean Nash

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buf...

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buffer to populate - otherwise it will overwrite memory.

1:03 pm

Sean Nash

.crc?

.crc?

1:00 pm

Sean Nash

1 and 0 is not clear. Better to say FIFO send and reset.

1 and 0 is not clear. Better to say FIFO send and reset.

12:43 pm

Sean Nash

Create and trigger new alarm.

Create and trigger new alarm.