Activity hdfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 16 Feb 2022

12:31 pm

Michael Garthwaite

More
c61acc9
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 337 more HD-DEN-11980-1

Updates and fixes per code review.

- -57
- +58
/firmware/App/Modes/ModeTreatmentParams.c
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatmentParams.c
- -1
- +1
/firmware/App/Modes/ModeTreatmentParams.h
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatmentParams.h
- -3
- +1
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

10:49 am

hnguyen (deleted user)

More
Re: HD-DEN-11250-1
replied to Sean Nash

Reinstalled the case statement back to where it was. case MSG_ID_HD_FAN_RPM_ALARM_START_TIME_OFFSET_OVERRIDE: handleTestFansRPMAlarmStartTimeOffsetOverrideRequest( message );

Reinstalled the case statement back to where it was.
case MSG_ID_HD_FAN_RPM_ALARM_START_TIME_OFFSET_OVERRIDE:
handleTestFansRPMAlarmStartTimeOffsetOverrideRequest( message );

10:13 am

Michael Garthwaite

More
Re: HD-DEN-11980-1
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

10:09 am

Sean Nash

More
Re: HD-DEN-11980-1
commented on review

Function name is misleading. Sounds like Dialin is sending us new parameters, but it is only requesting current params be sent. I would change to something like testSendCurrentTreatmentParameters().

Function name is misleading. Sounds like Dialin is sending us new parameters, but it is only requesting current params be sent. I would change to something like testSendCurrentTreatmentParameters().

10:06 am

Sean Nash

More
Re: HD-DEN-11980-1
commented on review

Check that Dialin has logged in before acting on a Dialin request (TRUE == isTestingActivated()).

Check that Dialin has logged in before acting on a Dialin request (TRUE == isTestingActivated()).

10:05 am

Sean Nash

More
Re: HD-DEN-11980-1
commented on review

Add a blank line between declarations and code.

Add a blank line between declarations and code.

10:04 am

Sean Nash

More
Re: HD-DEN-11980-1
commented on review

Check editor settings. Tabs should be set to 4 spaces.

Check editor settings. Tabs should be set to 4 spaces.

10:04 am

Sean Nash

More
Re: HD-DEN-11980-1
commented on review

Remove blank lines.

Remove blank lines.

10:02 am

Sean Nash

More
Re: HD-DEN-11980-1
commented on review

Remove blank line.

Remove blank line.

10:02 am

Sean Nash

More
Re: HD-DEN-11980-1
commented on review

Remove blank line.

Remove blank line.

10:00 am

Michael Garthwaite

More
Re: HD-DEN-11980-1
replied to Sean Nash

I believe this was caused from us branching out of master to have develop & staging branches for common. I will review this as this was not expected.

I believe this was caused from us branching out of master to have develop & staging branches for common. I will review this as this was not expected.

9:59 am

Sean Nash

More
Re: HD-DEN-11980-1
commented on review

Add one more blank line here.

Add one more blank line here.

9:59 am

Sean Nash

More
Re: HD-DEN-11980-1
commented on review

Remove extra blank lines.

Remove extra blank lines.

9:50 am

Sean Nash

More
Re: HD-DEN-11980-1
commented on review

Remove extra blank line.

Remove extra blank line.

9:48 am

Sean Nash

More
Re: HD-DEN-11980-1
commented on review

Why does it look like you added this table when I know it was there before?

Why does it look like you added this table when I know it was there before?

9:48 am

Sean Nash

More
Re: HD-DEN-11980-1
commented on review

I see why you did this - make sure alarm list script(s) by Dara are updated accordingly.

I see why you did this - make sure alarm list script(s) by Dara are updated accordingly.

9:39 am

Sean Nash

More
Re: HD-DEN-11250-1
commented on review

Why deleted?

Why deleted?

9:31 am

Dara Navaei

More
bda239a
changed 1 file
demo_branch, develop and 2 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

9:30 am

Dara Navaei

More
57f1d00
changed 1 file
demo_branch, develop and 2 more

Merged DEN-11750 and resolved the conflicts

- -34
- +67
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c

9:00 am

Michael Garthwaite

More
HD-DEN-11980-1
started review

HD-DEN-11980_SW Dev Sprint 64

HD-DEN-11980_SW Dev Sprint 64

8:54 am

Dara Navaei

More
35396d8
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more HD-UCOMMITS-20 HD-UCOMMITS-19

DEN-11750 updated the software configurations

- -44
- +64
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -34
- +85
/firmware/App/Controllers/Temperatures.c
- History
- Source
- Diff
/firmware/App/Controllers/Temperatures.c
- -0
- +2
/firmware/App/Controllers/Temperatures.h
- History
- Source
- Diff
/firmware/App/Controllers/Temperatures.h

Tuesday 15 Feb 2022

5:41 pm

Dara Navaei

More
9a831fa
changed 1 file
demo_branch, develop and 2 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

5:41 pm

Hung Nguyen <hnguyen@diality.com>

More
d37f31c
changed 8 files
demo_branch, develop and 2 more

DEN-11250 Fixed merge conflicts

- -30
- +12
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -97
- +88
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -0
- +1
/firmware/App/Modes/ModeInitPOST.c
- History
- Source
- Diff
/firmware/App/Modes/ModeInitPOST.c
- -1
- +0
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -26
- +22
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c
- -2
- +2
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -0
- +32
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -0
- +3
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

4:27 pm

Dara Navaei

More
ad2cf43
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 337 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

4:27 pm

Dara Navaei

More
3d72b77
changed 60 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 337 more HD-DEN-11980-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/firmware/App/Controllers/AirTrap.c
- History
- Source
- Diff
/firmware/App/Controllers/AirTrap.c
- -1
- +1
/firmware/App/Controllers/AirTrap.h
- History
- Source
- Diff
/firmware/App/Controllers/AirTrap.h
- -1
- +1
/firmware/App/Controllers/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.c
- -1
- +1
/firmware/App/Controllers/BloodLeak.h
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.h
- -1
- +1
/firmware/App/Controllers/Bubble.c
- History
- Source
- Diff
/firmware/App/Controllers/Bubble.c
- -1
- +1
/firmware/App/Controllers/Bubble.h
- History
- Source
- Diff
/firmware/App/Controllers/Bubble.h
- -1
- +1
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -1
- +1
/firmware/App/Controllers/DGInterface.h
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.h
- -1
- +1
/firmware/App/Controllers/DialOutFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialOutFlow.c
- -1
- +1
/firmware/App/Controllers/DialOutFlow.h
- History
- Source
- Diff
/firmware/App/Controllers/DialOutFlow.h
- -1
- +1
/firmware/App/Controllers/Fans.c
- History
- Source
- Diff
/firmware/App/Controllers/Fans.c
- -1
- +1
/firmware/App/Controllers/Fans.h
- History
- Source
- Diff
/firmware/App/Controllers/Fans.h
- -1
- +1
/firmware/App/Controllers/FluidLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/FluidLeak.c
- -1
- +1
/firmware/App/Controllers/FluidLeak.h
- History
- Source
- Diff
/firmware/App/Controllers/FluidLeak.h
- -3
- +3
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
… 45 more files in changeset.

4:14 pm

Hung Nguyen <hnguyen@diality.com>

More
aa4db7d
changed 9 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11250-hd-syringe-pump-updates and 338 more HD-DEN-11250-1

DEN-11250 Fixed merge conflicts

- -23
- +7
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -3
- +20
/firmware/App/Modes/Dialysis.c
- History
- Source
- Diff
/firmware/App/Modes/Dialysis.c
- -6
- +12
/firmware/App/Modes/ModeInitPOST.c
- History
- Source
- Diff
/firmware/App/Modes/ModeInitPOST.c
- -9
- +17
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -0
- +1
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c
- -3
- +4
/firmware/App/Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
/firmware/App/.../AlarmMgmtSWFaults.h
- -183
- +23
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -77
- +105
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -14
- +15
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

3:08 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:07 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:06 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:05 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-06 03:15 -0800