Activity hdfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 26 May 2022

10:21 am

Dara Navaei

More
ae1001d
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 330 more HD-DEN-12224-16 HD-DEN-12845-2

DEN-12224 addressed the code review comments

- -1
- +0
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -1
- +1
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c

10:06 am

Dara Navaei

More
e3f1eb6
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 330 more HD-DEN-12224-16

DEN-12224 updated the code and the VectorCAST per Pi Square's report

- -7
- +12
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c

Wednesday 25 May 2022

11:08 pm

Dara Navaei

More
556e924
changed 7 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 330 more HD-DEN-12224-16 HD-DEN-12845-2

DEN-12224 updated VecotCAST with Pi Square's but report

- -2
- +3
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -0
- +3
/firmware/App/Controllers/Switches.c
- History
- Source
- Diff
/firmware/App/Controllers/Switches.c
- -0
- +3
/firmware/App/Controllers/Temperatures.c
- History
- Source
- Diff
/firmware/App/Controllers/Temperatures.c
- -3
- +6
/firmware/App/Controllers/Valves.c
- History
- Source
- Diff
/firmware/App/Controllers/Valves.c
- -3
- +9
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -2
- +1
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -2
- +0
/firmware/App/Services/SystemCommMessages.h
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.h

11:06 am

Michael Garthwaite

More
HD-DEN-12224-16
resumed reviewing

10:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:24 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:20 am

Dara Navaei

More
Re: HD-DEN-12224-16
replied to Sean Nash

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

10:18 am

Dara Navaei

More
fe44ece
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 330 more HD-DEN-12224-16

DEN-12224 addressed the code review comments

- -1
- +0
/firmware/App/Modes/BloodPrime.c
- History
- Source
- Diff
/firmware/App/Modes/BloodPrime.c
- -1
- +0
/firmware/App/Modes/BloodPrime.h
- History
- Source
- Diff
/firmware/App/Modes/BloodPrime.h
- -3
- +0
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

10:17 am

Dara Navaei

More
Re: HD-DEN-12224-16
replied to Sean Nash

Done.

Done.

9:25 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

I don't think we need to broadcast usage data regularly (like every second), but may want to send it once in a while to get logged - maybe when we transition to treatment mode to start a new treatm...

I don't think we need to broadcast usage data regularly (like every second), but may want to send it once in a while to get logged - maybe when we transition to treatment mode to start a new treatment.

9:24 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Too many parenthesis in first part of condition I think.

Too many parenthesis in first part of condition I think.

9:24 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Too many parenthesis in first part of condition I think.

Too many parenthesis in first part of condition I think.

9:23 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Spaces between parenthesis and condition.

Spaces between parenthesis and condition.

9:22 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Space before final parenthesis.

Space before final parenthesis.

9:21 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Remove blank line.

Remove blank line.

9:21 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Should log volume level before and after.

Should log volume level before and after.

9:20 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Rather than UI sending this message to f/w so f/w can send event message back to UI to log it, maybe UI can just log it itself?

Rather than UI sending this message to f/w so f/w can send event message back to UI to log it, maybe UI can just log it itself?

9:19 am

Sean Nash

More
Re: HD-DEN-12845-2
commented on review

Remove blank line.

Remove blank line.

Tuesday 24 May 2022

9:42 pm

Dara Navaei

More
HD-DEN-12845-2
started review

HD-DEN-12845_SW Dev Sprint S71 Steve

HD-DEN-12845_SW Dev Sprint S71 Steve

9:37 pm

Dara Navaei

More
776acee
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12609-sw_dev-sprint-69_mg and 329 more HD-DEN-12845-2

DEN-12845 updated the syringe pumpe event name

- -1
- +1
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c

9:14 pm

Dara Navaei

More
ba4b62b
changed 4 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 330 more HD-DEN-12224-16

DEN-12224 updated VectorCAST and addressed the code review comments

- -13
- +4
/firmware/App/Controllers/Bubble.c
- History
- Source
- Diff
/firmware/App/Controllers/Bubble.c
- -1
- +5
/firmware/App/Controllers/DialOutFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialOutFlow.c
- -1
- +1
/firmware/App/Controllers/Fans.c
- History
- Source
- Diff
/firmware/App/Controllers/Fans.c
- -2
- +1
/firmware/App/Drivers/Battery.c
- History
- Source
- Diff
/firmware/App/Drivers/Battery.c

5:06 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:06 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:05 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:03 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:03 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:02 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:02 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-06 18:43 -0700