hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Dec 2022
1:12 pm

Dara Navaei

DEN-14307 addressed the code review comments

Options
    • -1
    • +1
    /firmware/App/Services/AlarmMgmt.c
1:12 pm

Dara Navaei

Done

Done

1:07 pm

Dara Navaei

Data is a local variable but added alarmButtonBlockers

Data is a local variable but added alarmButtonBlockers

12:02 pm

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

12:01 pm

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

11:59 am

wbracken  (deleted user)

data and alarmButtonBlockers?

data and alarmButtonBlockers?

11:57 am

wbracken  (deleted user)

Should alarmButtonBlockers and ALARM_TABLE also be added.

Should alarmButtonBlockers and ALARM_TABLE also be added.

11:55 am

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

11:55 am

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

11:55 am

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

10:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:47 am

Sean Nash

Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6

Options
9:47 am

Sean Nash

DEN-14307: Removed obsolete build switches.

Options
    • -6
    • +0
    /firmware/App/Drivers/Battery.c
    • -13
    • +8
    /firmware/App/Drivers/SafetyShutdown.c
    • -9
    • +1
    /firmware/App/HDCommon.h
    • -6
    • +0
    /firmware/App/Modes/ModeInitPOST.c
    • -107
    • +0
    /firmware/App/Services/FPGA.c
    • -5
    • +0
    /firmware/App/Services/WatchdogMgmt.c
9:31 am

Dara Navaei

DEN-14307 addressed code review comments

Options
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -7
    • +7
    /firmware/App/Services/AlarmMgmt.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
9:30 am

Dara Navaei

Done

Done

9:29 am

Dara Navaei

Done

Done

9:28 am

Dara Navaei

I think we still want to keep the comment. It has not been implemented yet.

I think we still want to keep the comment. It has not been implemented yet.

9:27 am

Dara Navaei

Done

Done

9:24 am

Dara Navaei

Done

Done

9:21 am

Dara Navaei

Done

Done

9:19 am

Dara Navaei

Fixed the setServiceTime function. Thanks.

Fixed the setServiceTime function. Thanks.

9:17 am

Dara Navaei

Done.

Done.

Tuesday 20 Dec 2022
4:23 pm

Michael Garthwaite

DEN-14344: complier fixes and warnings

Options
    • -0
    • +1
    /firmware/App/Controllers/AirPump.c
    • -0
    • +1
    /firmware/App/Modes/ModePreTreat.c
4:19 pm

Michael Garthwaite

DEN-14344: created air pump monitor function for alarm id 316. Created a timer for venous pressure to handle adjusted treatment values for a time while the air pump is operating. Allow HD to start filling after consumable testing in pretreatment instead of waiting after dry self tests. formatted ifndef release code blocks to look neater.

Options
    • -6
    • +13
    /firmware/App/Controllers/AirPump.c
    • -31
    • +16
    /firmware/App/Controllers/AirTrap.c
    • -1
    • +27
    /firmware/App/Controllers/PresOccl.c
    • -0
    • +5
    /firmware/App/Modes/ModePreTreat.c
3:22 pm

Sean Nash

Agree, though this comment belongs in NVDataMgmt.c where setServiceTime() is lives. That function should return TRUE if successful.

Agree, though this comment belongs in NVDataMgmt.c where setServiceTime() is lives. That function should return TRUE if successful.

3:15 pm

Sean Nash

All of these terms are integers and cast is coming too late (after division). To prevent loss of precision on division, we want to cast both sides of the division as floats.

All of these terms are integers and cast is coming too late (after division). To prevent loss of precision on division, we want to cast both sides of the division as floats.

2:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:47 am

dcox  (deleted user)

Moved to Init.

Moved to Init.

11:46 am

Darren Cox <darren_m@cox.net>

DEN-14007 Code Review comments update 2.

Options
    • -3
    • +2
    /firmware/App/Modes/ModePostTreat.c
9:11 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.