hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 07 Nov 2022
9:48 am

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Update DialInFlow.c

Options
    • -2
    • +5
    ./DialInFlow.c
9:37 am

Dara Navaei

Done.

Done.

9:33 am

Dara Navaei

Done.

Done.

8:53 am

Dong Nguyen

Done.

Done.

Saturday 05 Nov 2022
12:18 pm

Behrouz NematiPour

I know all the FW code is written in this style but it is always interesting to me, 1 - why don't just say if ( isSyringePumpPreLoaded() ) the function is a boolean why compare to TRUE to get a bo...

I know all the FW code is written in this style but it is always interesting to me,
1 - why don't just say 

if ( isSyringePumpPreLoaded() )

the function is a boolean why compare to TRUE to get a bool expression?
if it was returning an int it made sense to have something like this:

if ( isSyringePumpPreLoaded() != 0 )

Which is still unnecessary in some cases.
2 - even if we want to use TRUE, why to put it at the beginning of the expression and don't put it at the end, like 

if ( isSyringePumpPreLoaded() == TRUE )

So the first thing developer sees would be the important part which is the function not always a TRUE or FALSE.

Friday 04 Nov 2022
4:46 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:25 pm

Sean Nash

If we want to do that for consistency, that's fine but let's handle that as a bulk update and going forward kind of thing rather than keep commenting individually on code reviews.

If we want to do that for consistency, that's fine but let's handle that as a bulk update and going forward kind of thing rather than keep commenting individually on code reviews.

4:23 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:23 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:21 pm

Sean Nash

I think the else can end right after ramp. Ok to do checks I would think.

I think the else can end right after ramp. Ok to do checks I would think.

4:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:51 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:50 pm

Dong Nguyen <dnguyen@diality.com>

Merge branch 'DEN-14150-hd-dialysate-flow-estimation' into develop

Options
    • -4
    • +5
    ./DialInFlow.c
  2. … 2 more files in changeset.
3:49 pm

Dong Nguyen <dnguyen@diality.com>

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

Options
    • -3
    • +5
    ./DGInterface.c
3:48 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Update DialInFlow.c

Options
    • -1
    • +0
    ./DialInFlow.c
3:47 pm

Dong Nguyen

Done.

Done.

3:29 pm

Sean Nash

Not what I meant. I mean when we're determining whether the measured flow is within 50% of estimated flow, we should use the get function (that allows override to be considered) instead of using fi...

Not what I meant. I mean when we're determining whether the measured flow is within 50% of estimated flow, we should use the get function (that allows override to be considered) instead of using filteredDialinFlowMeterReading.

3:27 pm

Darren Cox <darren_m@cox.net>

DEN-14170 Updated for code review comments.

Options
    • -22
    • +24
    ./SyringePump.c
  2. … 1 more file in changeset.
3:26 pm

dcox  (deleted user)

Per Sean - "No harm in adding "F" suffix, but not necessary for assignment to a float variable". Will leave as is for float vars.

Per Sean - "No harm in adding "F" suffix, but not necessary for assignment to a float variable". Will leave as is for float vars.

3:25 pm

dcox  (deleted user)

Per Sean - "No harm in adding "F" suffix, but not necessary for assignment to a float variable". Will leave as is for float vars.

Per Sean - "No harm in adding "F" suffix, but not necessary for assignment to a float variable". Will leave as is for float vars.

3:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:23 pm

dcox  (deleted user)

Per our discussion, this is the proper place to set the alarm. But will set stopPump = TRUE and add ELSE condition for move and check move conditions.

Per our discussion, this is the proper place to set the alarm. But will set stopPump = TRUE and add ELSE condition for move and check move conditions.

3:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:21 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Address code review comments

Options
    • -4
    • +6
    ./DialInFlow.c
  2. … 2 more files in changeset.
2:56 pm

wbracken  (deleted user)

SW_CONFIG_ENABLE_VALUE should be first blue in if statement

SW_CONFIG_ENABLE_VALUE should be first blue in if statement

2:54 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:44 pm

dcox  (deleted user)

It is reset on Retract / Home completion. Once the Seek occurs, it is no longer valid so I reset it here on Seek completion.SelfTest.c uses this flag in progression from Retract to Preload to Seek ...

It is reset on Retract / Home completion. Once the Seek occurs, it is no longer valid so I reset it here on Seek completion.SelfTest.c uses this flag in progression from Retract to Preload to Seek to Prime. .

2:31 pm

Dong Nguyen

dialysateInPumpRotorCounter.data = 0.0F; Done.

dialysateInPumpRotorCounter.data = 0.0F; Done.

2:28 pm

dcox  (deleted user)

I attempted to do this earlier in the process, but getTreatmentParameterF32() caused a fault when called too early (treat params not ready?).. So I kept it here after determining it was before UI n...

I attempted to do this earlier in the process, but getTreatmentParameterF32() caused a fault when called too early (treat params not ready?).. So I kept it here after determining it was before UI needed it.