Activity hdfirmware/firmware/App/Modes

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	15
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 26 Jul 2022

2:30 pm

Sean Nash

More
ee458e1
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 319 more HD-UCOMMITS-19

DEN-13460: Fixed syringe home issues.

- -3
- +3
./SelfTests.c
- History
- Source
- Diff
./SelfTests.c
… 1 more file in changeset.

Monday 25 Jul 2022

1:49 pm

Sean Nash

More
4562744
changed 6 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 319 more HD-UCOMMITS-19

DEN-13460: Added persistence to pump direction error count alarm. Fixed comments and pos A average calc for valves.

- -7
- +0
./OperationModes.c
- History
- Source
- Diff
./OperationModes.c
- -7
- +3
./SelfTests.c
- History
- Source
- Diff
./SelfTests.c
… 4 more files in changeset.

10:54 am

Darren Cox <darren_m@cox.net>

More
a845ada
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12609-sw_dev-sprint-69_mg and 323 more HD-DEN-13167-1

DEN-13167 Code review comment updates 1.

- -21
- +14
./Dialysis.c
- History
- Source
- Diff
./Dialysis.c

Sunday 24 Jul 2022

6:45 pm

Dara Navaei

More
df276aa
changed 1 file
demo_branch

Updated the self tests tolerance

- -1
- +1
./SelfTests.c
- History
- Source
- Diff
./SelfTests.c

Friday 22 Jul 2022

1:29 pm

Sean Nash

More
Re: HD-DEN-13167-1
commented on review

Can we remove this now?

Can we remove this now?

1:27 pm

Sean Nash

More
Re: HD-DEN-13167-1
commented on review

I though cycle was an enum (start/final), not a boolean. Should we be looking for final (not TRUE)?

I though cycle was an enum (start/final), not a boolean. Should we be looking for final (not TRUE)?

1:20 pm

Sean Nash

More
Re: HD-DEN-13167-1
commented on review

Better name is reservoir use cycle steady sample points (during treatment, but we're in Dialysis.c here so treatment can be inferred).

Better name is reservoir use cycle steady sample points (during treatment, but we're in Dialysis.c here so treatment can be inferred).

12:48 pm

Dara Navaei

More
HD-DEN-13167-1
started review

HD-DEN-13167_SW Dev Sprint 74 Darren

HD-DEN-13167_SW Dev Sprint 74 Darren

8:28 am

Sean Nash

More
Re: HD-DEN-12931-2
commented on review

Why removed?

Why removed?

8:27 am

Sean Nash

More
Re: HD-DEN-12931-2
commented on review

Why removed? I thought we needed this for VC?

Why removed? I thought we needed this for VC?

Thursday 21 Jul 2022

9:03 pm

Sean Nash

More
Re: HD-DEN-12931-2
replied to wbracken (deleted user)

F has been added.

F has been added.

9:01 pm

Sean Nash

No. Code removed.

No. Code removed.

8:58 pm

Sean Nash

More
Re: HD-DEN-12931-2
commented on review

If no actions handled in this mode, add a comment saying so.

If no actions handled in this mode, add a comment saying so.

8:52 pm

Sean Nash

More
Re: HD-DEN-12931-2
replied to wbracken (deleted user)

Yes, at bottom of exec function above.

Yes, at bottom of exec function above.

8:50 pm

Sean Nash

More
Re: HD-DEN-12931-2
commented on review

Remove blank line.

Remove blank line.

8:49 pm

Sean Nash

More
Re: HD-DEN-12931-2
commented on review

Can we remove this now?

Can we remove this now?

5:08 pm

Sean Nash

More
Re: HD-DEN-13141-6
commented on review

Why?

Why?

5:08 pm

Sean Nash

More
Re: HD-DEN-13141-6
commented on review

Why?

Why?

4:28 pm

Dara Navaei

More
HD-DEN-13141-6
started review

HD-DEN-13141_Miscellaneous HD Issues BB

HD-DEN-13141_Miscellaneous HD Issues BB

10:39 am

Dara Navaei

More
b1f086e
changed 9 files
demo_branch, develop and 2 more

Merged DEN-13460

- -9
- +2
./ModeInitPOST.c
- History
- Source
- Diff
./ModeInitPOST.c
- -76
- +10
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c
- -1
- +3
./Prime.c
- History
- Source
- Diff
./Prime.c
- -28
- +17
./SelfTests.c
- History
- Source
- Diff
./SelfTests.c
… 5 more files in changeset.

9:47 am

Dara Navaei

More
f10b94b
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 320 more

Merge branch 'DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2

- -1
- +1
./ModeTreatmentParams.c
- History
- Source
- Diff
./ModeTreatmentParams.c
… 2 more files in changeset.

9:47 am

Dara Navaei

More
43e59e5
changed 8 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 320 more HD-UCOMMITS-20

DEN-13460 updated the code with DVT changes

- -6
- +11
./Dialysis.c
- History
- Source
- Diff
./Dialysis.c
- -0
- +4
./ModeTreatmentParams.c
- History
- Source
- Diff
./ModeTreatmentParams.c
… 6 more files in changeset.

Wednesday 20 Jul 2022

4:50 pm

Sean Nash

More
d625570
changed 4 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 320 more HD-DEN-13460-2 HD-UCOMMITS-19

DEN-13460: Updated thresholds for wet transfer test. Updated valve home function to just go to position A if already homed.

- -0
- +3
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c
- -8
- +4
./ModeStandby.h
- History
- Source
- Diff
./ModeStandby.h
- -10
- +6
./SelfTests.c
- History
- Source
- Diff
./SelfTests.c
… 1 more file in changeset.

4:05 pm

Darren Cox <darren_m@cox.net>

More
999abe4
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12609-sw_dev-sprint-69_mg and 323 more HD-DEN-13167-1

DEN-13167 Update Load Cell drift to use Start to Final only.

- -12
- +29
./Dialysis.c
- History
- Source
- Diff
./Dialysis.c

11:15 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
641f418
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12609-sw_dev-sprint-69_mg and 320 more HD-DEN-13141-6

Merge branch 'staging' into DEN-13141-miscellaneous_hd_issues_bb

- -9
- +1
./ModeInitPOST.c
- History
- Source
- Diff
./ModeInitPOST.c

11:13 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
0078d0d
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12609-sw_dev-sprint-69_mg and 320 more HD-DEN-13141-6

DEN-13141 DEN-13149 Resolved alarm 219 (ALARM_ID_HD_SYRINGE_PUMP_SYRINGE_REMOVED). Removed check for presence of syringe pump.

- -8
- +0
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c

Tuesday 19 Jul 2022

2:34 pm

Sean Nash

More
cb832b3
changed 5 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 320 more HD-UCOMMITS-20

DEN-13460: Updated arterial pressure limits range. Added actuators homing to standby start state.

- -1
- +45
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c
- -1
- +1
./ModeTreatmentParams.c
- History
- Source
- Diff
./ModeTreatmentParams.c
- -1
- +1
./SelfTests.c
- History
- Source
- Diff
./SelfTests.c
… 2 more files in changeset.

Monday 18 Jul 2022

2:49 pm

wbracken (deleted user)

More
Re: HD-DEN-12931-2
commented on review

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

2:42 pm

wbracken (deleted user)

More
Re: HD-DEN-12931-2
commented on review

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

1:00 pm

wbracken (deleted user)

More
Re: HD-DEN-12931-2
commented on review

Need #define for minimum vRef

Need #define for minimum vRef

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-12 10:13 -0800