Modes

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-13834 merged staging

  1. … 7 more files in changeset.
common and fwcommon repos are covered in the 13598 DG code review so not needed here.

common and fwcommon repos are covered in the 13598 DG code review so not needed here.

Bill, I think this #ifndef is here because this test will fail if you are debugging and ever stop for a break point (FPGA timer keeps going but processor timer stops). So the idea here is that this...

Bill, I think this #ifndef is here because this test will fail if you are debugging and ever stop for a break point (FPGA timer keeps going but processor timer stops). So the idea here is that this test only runs on a release build.

Done.

Done.

It is implemented.

It is implemented.

Done.

Done.

Done.

Done.

Done.

Done.

These variables will be deleted.

These variables will be deleted.

Done.

Done.

The buffer has been increased in the DEN-13903.

The buffer has been increased in the DEN-13903.

Done.

Done.

DEN-13903: Implemented a 2nd speed, 300ml/min, to purge air that is used after the first purge.

Add bloodLeakEmbModeHasZeroBeenRqustd to header.

Add bloodLeakEmbModeHasZeroBeenRqustd to header.

DEN-13903: Changed no air detection from 20 seconds to 40 seconds. Changed upper level air trap alarm to use the correct alarm.

  1. … 1 more file in changeset.
Merge branch 'DEN-13834-dg_hd_dev-hd_dg_dvt-update-part-3' into develop

  1. … 1 more file in changeset.
DEN-13834 changed the service and disinfect alarms to reject reasons. Added retries for the blood leak zero command

  1. … 3 more files in changeset.
DEN-13903: Restored DPi control to open loop and increased target flow to avoid trimmer heater on w/ low flow alarm while in pre-treatment recirc and patient connect states.

DEN-13903: Run DPi closed loop in pre-treatment re-circ and patient connect states.

Merge branch 'DEN-13903-s80-mg-DIAL-204' into develop

  1. … 7 more files in changeset.
Merged DEN-13834

  1. … 5 more files in changeset.
Update header.

Update header.

Update header?

Update header?

Should this be #elseif? Can DG AND HD both be defined or neither?

Should this be #elseif? Can DG AND HD both be defined or neither?

Should 365 be #define? Why changed from #define to static const U32?

Should 365 be #define? Why changed from #define to static const U32?

Should 250 be #define?

Should 250 be #define?

Should struct members be aligned?

Should struct members be aligned?

Last value is 0, should be 0.0. Do they need to be 0.0F?

Last value is 0, should be 0.0. Do they need to be 0.0F?

Magic number 1500. Give an explanation or define constant elsewhere.

Magic number 1500. Give an explanation or define constant elsewhere.

DEN-13834 updated the code

  1. … 6 more files in changeset.