hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Mar 2023
7:30 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModePreTreat.c
    • -1
    • +1
    ./ModeTreatmentParams.h
    • -1
    • +1
    ./Rinseback.c
    • -1
    • +1
    ./SampleWater.c
    • -2
    • +2
    ./TreatmentRecirc.c
  6. … 16 more files in changeset.
3:19 pm

Michael Garthwaite

11:13 am

Darren Cox <darren_m@cox.net>

DEN-14860 Merge

Options
    • -9
    • +0
    ./SelfTests.c
11:06 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./SelfTests.c
  2. … 1 more file in changeset.
11:06 am

dcox  (deleted user)

11:04 am

Darren Cox <darren_m@cox.net>

Merge DEN-14860 to staging

Options
    • -0
    • +5
    ./SelfTests.c
  2. … 2 more files in changeset.
9:49 am

wbracken  (deleted user) and Michael Garthwaite

Thursday 30 Mar 2023
8:19 pm

Sean Nash

DEN-14999: Removed redundant trigger for DG restarted alarm.

Options
    • -31
    • +0
    ./SampleWater.c
2:22 pm

Sean Nash

12:23 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:33 am

Sean Nash

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to ...

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to candump and this was causing alarm 46. Until UI sorts this out, I am not going to check payload.

10:18 am

Michael Garthwaite

What is the other flavor of UI check in message. If it is a different size, shouldn't it be its own separate message?

What is the other flavor of UI check in message. If it is a different size, shouldn't it be its own separate message?

9:47 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:44 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:41 am

Sean Nash

DEN-14999: Removed obsolete/redundant alarms. Addressed code review comment.

Options
    • -8
    • +1
    ./Rinseback.c
    • -31
    • +2
    ./TreatmentRecirc.c
  3. … 1 more file in changeset.
9:40 am

Sean Nash

Warning (13 min) removed since no longer alarming at 15 min.

Warning (13 min) removed since no longer alarming at 15 min.

9:38 am

Sean Nash

Fixed.

Fixed.

Wednesday 29 Mar 2023
4:30 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:29 pm

dcox  (deleted user)

Updated all headers.

Updated all headers.

12:23 pm

wbracken  (deleted user)

Add timeOfLastUICheckin and uiDidCommunicate.

Add timeOfLastUICheckin and uiDidCommunicate.

11:20 am

Sean Nash

DEN-14999: Removed minimum UF change. Added 250ms of persistence to HD fluid leak alarm. Increased no ack retries from 8 to 10 because UI needed more time at startup. Accept UI check-in message regardless of payload size because UI is sending 2 different flavors of check-in message.

Options
    • -1
    • +1
    ./ModeTreatmentParams.h
  2. … 3 more files in changeset.
Tuesday 28 Mar 2023
2:23 pm

wbracken  (deleted user)

Does the new code result in one less TRUE comparison? Can rinsebackTimerCtr ever be greater than RINSEBACK_DONE_WARNING_TIME?

Does the new code result in one less TRUE comparison? Can rinsebackTimerCtr ever be greater than RINSEBACK_DONE_WARNING_TIME?

1:33 pm

Sean Nash

DEN-14999: Do not alarm after rinseback completed due to 15 min t/o.

Options
    • -13
    • +4
    ./Rinseback.c
1:22 pm

Darren Cox <darren_m@cox.net>

Merge DEN-14860

Options
    • -0
    • +14
    ./SelfTests.c
  2. … 2 more files in changeset.
11:36 am

Sean Nash

Fixed merge conflicts from DEN-14999.

Options
    • -3
    • +5
    ./ModePreTreat.c
  2. … 6 more files in changeset.
11:33 am

Sean Nash

11:03 am

Sean Nash

Reverted previous change to re-enable re-prime feature and allow zero UF rate.

Options
    • -1
    • +1
    ./ModeTreatment.c
    • -1
    • +1
    ./ModeTreatmentParams.c
  3. … 1 more file in changeset.
10:59 am

Sean Nash

Re-Prime feature re-enabled for this build. Minimum UF rate set back to zero for this build.

Options
    • -1
    • +1
    ./ModeTreatment.c
    • -1
    • +1
    ./ModeTreatmentParams.c
  3. … 1 more file in changeset.
9:24 am

Sean Nash

Fixed merge conflicts.

Options
    • -2
    • +2
    ./ModePreTreat.c
    • -51
    • +220
    ./ModeStandby.c
    • -2
    • +3
    ./ModeStandby.h
  4. … 7 more files in changeset.
9:07 am

wbracken  (deleted user) , Sean Nash , Dara Navaei and Michael Garthwaite