Activity hdfirmware/firmware/App/Modes

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	15
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 14 Jun 2023

10:43 am

Michael Garthwaite

More
8126d8e
changed 7 files
develop

Merge branch 'DEN-15196-DIAL-262-fixes' into develop

- -26
- +29
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c
- -1
- +1
./ModeStandby.h
- History
- Source
- Diff
./ModeStandby.h
… 5 more files in changeset.

10:42 am

Michael Garthwaite

More
49083c8
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 196 more DIALIN-DEN-15196-7

DIAL-264: fixed blood prime not showing sub state in operation status event

- -1
- +1
./BloodPrime.c
- History
- Source
- Diff
./BloodPrime.c

10:39 am

Michael Garthwaite

More
42202c4
changed 2 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 196 more DIALIN-DEN-15196-7

Merge branch 'staging' into DEN-15196-DIAL-262-fixes

- -3
- +7
./OperationModes.c
- History
- Source
- Diff
./OperationModes.c
- -71
- +72
./Prime.c
- History
- Source
- Diff
./Prime.c

10:26 am

Dara Navaei

More
f1157c7
changed 15 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 197 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./ModeFault.c
- History
- Source
- Diff
./ModeFault.c
- -1
- +1
./ModePreTreat.c
- History
- Source
- Diff
./ModePreTreat.c
- -2
- +2
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c
- -1
- +1
./ModeStandby.h
- History
- Source
- Diff
./ModeStandby.h
- -1
- +1
./ModeTreatment.c
- History
- Source
- Diff
./ModeTreatment.c
- -2
- +2
./OperationModes.c
- History
- Source
- Diff
./OperationModes.c
- -2
- +2
./Prime.c
- History
- Source
- Diff
./Prime.c
… 8 more files in changeset.

10:22 am

Dara Navaei

More
HD-DEN-15367-1
Closed

10:18 am

dcox (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:11 am

Dara Navaei

More
Re: HD-DEN-15367-1
replied to dcox (deleted user)

It is called in the translationToStandyMode in the function clearCurrentCleaningModeStatus().

It is called in the translationToStandyMode in the function clearCurrentCleaningModeStatus().

10:11 am

Sean Nash

More
HD-DEN-15367-1
finished reviewing

10:08 am

dcox (deleted user)

More
Re: HD-DEN-15367-1
commented on review

Where is currentDGCleaningMode initialized?

Where is currentDGCleaningMode initialized?

9:56 am

Dara Navaei

More
e63dcc4
changed 2 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more HD-DEN-15367-1

DEN-15367 merged staging

- -11
- +15
./Prime.c
- History
- Source
- Diff
./Prime.c
… 1 more file in changeset.

9:41 am

Dara Navaei

More
180305f
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./ModeTreatmentParams.c
- History
- Source
- Diff
./ModeTreatmentParams.c

9:39 am

dcox (deleted user)

More
HD-DEN-15493-1
Closed

9:29 am

Sean Nash

More
HD-DEN-15558-1
Closed

9:18 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Dara Navaei

More
febf34a
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more HD-DEN-15367-1

DEN-15367 addressed a code review comment

- -1
- +1
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c

9:12 am

Dara Navaei

More
Re: HD-DEN-15367-1
replied to Sean Nash

Done

Done

9:07 am

Sean Nash

More
Re: HD-DEN-15367-1
commented on review

Implicit bool to BOOL conversion. Prefer explicit conversion with ternary.

Implicit bool to BOOL conversion. Prefer explicit conversion with ternary.

9:07 am

Dara Navaei

More
8bfe61e
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more HD-DEN-15367-1

DEN-15489 updated the code that checks for the validation dates

- -16
- +18
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c

9:06 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:05 am

jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:02 am

Michael Garthwaite

More
HD-DEN-15558-1
finished reviewing

9:02 am

jtaylor (deleted user)

More
HD-DEN-15493-1
finished reviewing

Tuesday 13 Jun 2023

5:20 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

5:19 pm

wbracken (deleted user)

More
Re: HD-DEN-15558-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:54 pm

Michael Garthwaite

More
e30734b
changed 1 file
develop

Merge branch 'DEN-15196-DIAL-262-fixes' into develop

- -2
- +1
./OperationModes.c
- History
- Source
- Diff
./OperationModes.c

4:53 pm

Michael Garthwaite

More
7527efb
changed 2 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 196 more DIALIN-DEN-15196-7

DIAL-262: fixes

- -1
- +1
./OperationModes.c
- History
- Source
- Diff
./OperationModes.c
- -1
- +1
./OperationModes.h
- History
- Source
- Diff
./OperationModes.h

4:50 pm

Michael Garthwaite

More
673214e
changed 3 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 196 more DIALIN-DEN-15196-7

DIAL-262: added additional event calls for UF and saline transitions.

- -1
- +9
./Dialysis.c
- History
- Source
- Diff
./Dialysis.c
- -1
- +0
./OperationModes.c
- History
- Source
- Diff
./OperationModes.c
- -0
- +1
./OperationModes.h
- History
- Source
- Diff
./OperationModes.h

3:34 pm

Dara Navaei

More
f249310
changed 5 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more HD-DEN-15367-1

DEN-15367 addressed the code review comments. Added code to check the payload of the message that is received from DG to indicate that DG is ready to dispense more water in RO permeate sample mode

- -9
- +7
./ModeStandby.c
- History
- Source
- Diff
./ModeStandby.c
… 4 more files in changeset.

3:33 pm

Sean Nash

More
Re: HD-DEN-15558-1
replied to wbracken (deleted user)

Done.

Done.

3:33 pm

Dara Navaei

More
Re: HD-DEN-15367-1
replied to Sean Nash

Done

Done

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-13 12:57 -0800