hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Oct 2022
9:25 am

Michael Garthwaite

DEN-13903: DIAL-204: code review comments.

Options
    • -3
    • +4
    ./Controllers/BloodFlow.c
    • -7
    • +7
    ./Controllers/DialInFlow.c
    • -6
    • +6
    ./Controllers/DialOutFlow.c
    • -1
    • +1
    ./Modes/Dialysis.c
    • -1
    • +0
    ./Services/SystemComm.c
    • -1
    • +0
    ./Services/SystemCommMessages.c
9:16 am

Sean Nash

This probably warrants a comment.

This probably warrants a comment.

9:12 am

Sean Nash

Is this a TODO? Can we just do it?

Is this a TODO? Can we just do it?

9:11 am

Sean Nash

Why are we checking non-zero here? Seems like we will get stuck here if years really is set to zero.

Why are we checking non-zero here? Seems like we will get stuck here if years really is set to zero.

9:09 am

Michael Garthwaite

This whole block of code ( lines 127 - 178 ) was removed in when staging was merged in and not reflected on crucible.

This whole block of code ( lines 127 - 178 ) was removed in when staging was merged in and not reflected on crucible.

9:01 am

Michael Garthwaite

This whole block of code ( lines 248 - 304 ) was removed in when staging was merged in and not reflected on crucible.

This whole block of code ( lines 248 - 304 ) was removed in when staging was merged in and not reflected on crucible.

8:57 am

Sean Nash

This seems very similar to condition above. Is this a merge issue? Do we need both?

This seems very similar to condition above. Is this a merge issue? Do we need both?

8:56 am

Sean Nash

I think this flag should be set to FALSE in prior state as we transition to this state.

I think this flag should be set to FALSE in prior state as we transition to this state.

8:49 am

Sean Nash

Remove blank line.

Remove blank line.

8:47 am

Sean Nash

Add TODO to restore to 100 when DPi flow control is fixed.

Add TODO to restore to 100 when DPi flow control is fixed.

8:45 am

Sean Nash

Add a TODO to restore this to 100 when open DPi flow control fixed.

Add a TODO to restore this to 100 when open DPi flow control fixed.

8:43 am

Sean Nash

Should have an else here where we reset (zero) airTrapIllegalLevelSensorsCtr.

Should have an else here where we reset (zero) airTrapIllegalLevelSensorsCtr.

8:40 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

8:38 am

Sean Nash

Remove last param.

Remove last param.

8:37 am

Sean Nash

Remove last param.

Remove last param.

8:37 am

Sean Nash

Remove last param.

Remove last param.

8:30 am

Sean Nash

Remove param.

Remove param.

8:29 am

Sean Nash

Add space before last ")"

Add space before last ")"

Tuesday 11 Oct 2022
4:01 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14001: Updated battery driver

Options
    • -1
    • +1
    ./Drivers/Battery.c
3:59 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
3:52 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Merge to develop.

Options
    • -12
    • +10
    ./Modes/ModeStandby.c
    • -0
    • +167
    ./Modes/OperationModes.c
    • -93
    • +22
    ./Services/SystemCommMessages.c
    • -30
    • +7
    ./Services/SystemCommMessages.h
3:43 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Refactor Confirm Request to be managed in Operation Mode and allow multiple requests.

Options
    • -12
    • +10
    ./Modes/ModeStandby.c
    • -0
    • +167
    ./Modes/OperationModes.c
    • -0
    • +4
    ./Modes/OperationModes.h
    • -93
    • +22
    ./Services/SystemCommMessages.c
    • -30
    • +7
    ./Services/SystemCommMessages.h
2:29 pm

Dara Navaei

DEN-13834 updated the comment.

Options
    • -1
    • +2
    ./Controllers/DGInterface.c
2:19 pm

Dong Nguyen <dnguyen@diality.com>

Updated time to send command to battery.

Options
    • -3
    • +16
    ./Drivers/Battery.c
    • -1
    • +2
    ./Tasks/TaskBG.c
12:16 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
12:16 pm

Dara Navaei

Merged DEN-13834

Options
    • -7
    • +12
    ./Controllers/DGInterface.c
    • -4
    • +1
    ./HDCommon.h
12:13 pm

Dara Navaei

DEN-13834 updated the valves and changed the DGInterface to not send trimmer heater commands if chemical disinfect or heat disinfects are running

Options
    • -7
    • +12
    ./Controllers/DGInterface.c
    • -8
    • +8
    ./Controllers/Valves.c
    • -3
    • +0
    ./HDCommon.h
12:05 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
12:05 pm

Sean Nash

Fixed merge conflicts.

Options
    • -14
    • +18
    ./Modes/ModeStandby.c
11:46 am

Sean Nash

DEN-13903: Fixed bug with syringe pump force sensor DAC check in standby mode.

Options
    • -14
    • +19
    ./Modes/ModeStandby.c