hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Oct 2022
12:43 pm

Darren Cox <darren_m@cox.net>

DEN-14000 Code review updates.

Options
    • -1
    • +1
    ./Modes/OperationModes.c
    • -4
    • +3
    ./Modes/OperationModes.h
    • -1
    • +2
    ./Services/SystemCommMessages.h
10:10 am

Sean Nash

Can we assign request_type here at declaration instead of below?

Can we assign request_type here at declaration instead of below?

10:05 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:05 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:05 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:05 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:03 am

Sean Nash

Add // MSG_ID_... comment above prototype.

Add // MSG_ID_... comment above prototype.

10:00 am

Sean Nash

Add a /// doxygen comment above this new declaration.

Add a /// doxygen comment above this new declaration.

9:59 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:59 am

Sean Nash

Should say "private definitions".

Should say "private definitions".

9:58 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:34 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:33 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:32 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:25 am

Michael Garthwaite

DEN-13903: DIAL-204: code review comments.

Options
    • -3
    • +4
    ./Controllers/BloodFlow.c
    • -7
    • +7
    ./Controllers/DialInFlow.c
    • -6
    • +6
    ./Controllers/DialOutFlow.c
    • -1
    • +1
    ./Modes/Dialysis.c
    • -1
    • +0
    ./Services/SystemComm.c
    • -1
    • +0
    ./Services/SystemCommMessages.c
9:16 am

Sean Nash

This probably warrants a comment.

This probably warrants a comment.

9:12 am

Sean Nash

Is this a TODO? Can we just do it?

Is this a TODO? Can we just do it?

9:11 am

Sean Nash

Why are we checking non-zero here? Seems like we will get stuck here if years really is set to zero.

Why are we checking non-zero here? Seems like we will get stuck here if years really is set to zero.

9:09 am

Michael Garthwaite

This whole block of code ( lines 127 - 178 ) was removed in when staging was merged in and not reflected on crucible.

This whole block of code ( lines 127 - 178 ) was removed in when staging was merged in and not reflected on crucible.

9:01 am

Michael Garthwaite

This whole block of code ( lines 248 - 304 ) was removed in when staging was merged in and not reflected on crucible.

This whole block of code ( lines 248 - 304 ) was removed in when staging was merged in and not reflected on crucible.

8:57 am

Sean Nash

This seems very similar to condition above. Is this a merge issue? Do we need both?

This seems very similar to condition above. Is this a merge issue? Do we need both?

8:56 am

Sean Nash

I think this flag should be set to FALSE in prior state as we transition to this state.

I think this flag should be set to FALSE in prior state as we transition to this state.

8:49 am

Sean Nash

Remove blank line.

Remove blank line.

8:47 am

Sean Nash

Add TODO to restore to 100 when DPi flow control is fixed.

Add TODO to restore to 100 when DPi flow control is fixed.

8:45 am

Sean Nash

Add a TODO to restore this to 100 when open DPi flow control fixed.

Add a TODO to restore this to 100 when open DPi flow control fixed.

8:43 am

Sean Nash

Should have an else here where we reset (zero) airTrapIllegalLevelSensorsCtr.

Should have an else here where we reset (zero) airTrapIllegalLevelSensorsCtr.

8:40 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

8:38 am

Sean Nash

Remove last param.

Remove last param.

8:37 am

Sean Nash

Remove last param.

Remove last param.

8:37 am

Sean Nash

Remove last param.

Remove last param.