hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 10 Mar 2023
10:01 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
10:01 am

Dara Navaei

HD-DEN-14888_Unable TO Trigger Alarm 47 Ultrafiltration Rate IS Too High Error During Treatment
HD-DEN-14888_Unable TO Trigger Alarm 47 Ultrafiltration Rate IS Too High Error During Treatment
9:58 am

Michael Garthwaite

Merge branch 'DEN-14689-messaging-bugs' into develop

Options
    • -5
    • +5
    ./Services/SystemCommMessages.c
9:58 am

Michael Garthwaite

DEN-14689: reworked message len checks for it to be grabbed by automation

Options
    • -5
    • +5
    ./Services/SystemCommMessages.c
9:48 am

Sean Nash

Why removed?

Why removed?

9:25 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
9:16 am

Michael Garthwaite

Merge branch 'DEN-14689-messaging-bugs' into develop

Options
    • -9
    • +26
    ./Services/SystemCommMessages.c
9:16 am

Michael Garthwaite

DEN-14830: Removed duplicate heater structure

Options
    • -11
    • +0
    ./Controllers/DGInterface.h
Thursday 09 Mar 2023
11:35 am

wbracken  (deleted user)

Change cmd to prompt

Change cmd to prompt

11:08 am

Michael Garthwaite

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness. If set to false, the output is: 0x4A MSG_ID_UI_PATI...

How do we wish to handle the output of the automated script? It currently does not handle conditional statements to determine ack requiredness.

If set to false, the output is:

0x4A MSG_ID_UI_PATIENT_DISCONNECTION_CONFIRM hdfirmware response COMM_BUFFER_OUT_CAN_HD_2_UI ACK_REQUIRED PAYLOAD

which is incorrect to what the code is doing. We have 2 different implementations of calling sendAckResponseMsg()


1. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, FALSE );

  1. if we dont meet an expected condition. Later in the handler we will call a response message with the response message calling:
    serializeMessage( msg, COMM_BUFFER_OUT_CAN_DG_2_HD, ACK_REQUIRED );


2. sendAckResponseMsg( (MSG_ID_T)message->hdr.msgID, COMM_BUFFER_OUT_CAN_HD_2_UI, result );

  1. a conditional based on?


Please review the FW_Message_list.csv within latest develop & staging builds to understand how the automated script is determining "ack requireness"

9:33 am

Michael Garthwaite

DEN-14689: removed dg checkin message as it is no longer needed.

Options
    • -4
    • +0
    ./Services/SystemComm.c
    • -9
    • +26
    ./Services/SystemCommMessages.c
Wednesday 08 Mar 2023
9:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:05 pm

Sean Nash

Remove blank line.

Remove blank line.

7:14 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:08 pm

Sean Nash

FALSE was right.

FALSE was right.

7:03 pm

Sean Nash

Add space after "(".

Add space after "(".

7:01 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

7:00 pm

Sean Nash

Add blank line before comment.

Add blank line before comment.

4:52 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:52 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:52 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:40 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
4:39 pm

Michael Garthwaite

Merge branch 'DEN-14689-messaging-bugs' into develop

Options
    • -10
    • +8
    ./Services/SystemCommMessages.c
    • -1
    • +1
    ./Services/SystemCommMessages.h
4:39 pm

Michael Garthwaite

DEN-14689: updated active alarm list response to have a payload contained within a struct

Options
    • -1
    • +1
    ./Modes/SelfTests.c
    • -8
    • +8
    ./Services/AlarmMgmt.c
    • -1
    • +9
    ./Services/AlarmMgmt.h
    • -10
    • +8
    ./Services/SystemCommMessages.c
    • -1
    • +1
    ./Services/SystemCommMessages.h
3:55 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
3:50 pm

Michael Garthwaite

Merge branch 'DEN-14689-messaging-bugs' into develop

Options
    • -25
    • +34
    ./Services/SystemCommMessages.c
    • -14
    • +14
    ./Services/SystemCommMessages.h
3:50 pm

Michael Garthwaite

DEN-14689: fixed compiler warning.

Options
    • -1
    • +1
    ./Services/SystemCommMessages.c