hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 04 Nov 2022
3:50 pm

Dong Nguyen <dnguyen@diality.com>

Merge branch 'DEN-14150-hd-dialysate-flow-estimation' into develop

Options
    • -4
    • +5
    ./App/Controllers/DialInFlow.c
    • -1
    • +1
    ./App/Drivers/Battery.c
    • -1
    • +1
    ./App/Modes/ModeStandby.c
3:49 pm

Dong Nguyen <dnguyen@diality.com>

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

Options
    • -3
    • +5
    ./App/Controllers/DGInterface.c
3:48 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Update DialInFlow.c

Options
    • -1
    • +0
    ./App/Controllers/DialInFlow.c
3:47 pm

Dong Nguyen

Done.

Done.

3:29 pm

Sean Nash

Not what I meant. I mean when we're determining whether the measured flow is within 50% of estimated flow, we should use the get function (that allows override to be considered) instead of using fi...

Not what I meant. I mean when we're determining whether the measured flow is within 50% of estimated flow, we should use the get function (that allows override to be considered) instead of using filteredDialinFlowMeterReading.

3:27 pm

Darren Cox <darren_m@cox.net>

DEN-14170 Updated for code review comments.

Options
    • -22
    • +24
    ./App/Controllers/SyringePump.c
    • -1
    • +1
    ./App/Modes/SelfTests.c
3:26 pm

dcox  (deleted user)

Per Sean - "No harm in adding "F" suffix, but not necessary for assignment to a float variable". Will leave as is for float vars.

Per Sean - "No harm in adding "F" suffix, but not necessary for assignment to a float variable". Will leave as is for float vars.

3:25 pm

dcox  (deleted user)

Per Sean - "No harm in adding "F" suffix, but not necessary for assignment to a float variable". Will leave as is for float vars.

Per Sean - "No harm in adding "F" suffix, but not necessary for assignment to a float variable". Will leave as is for float vars.

3:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:23 pm

dcox  (deleted user)

Per our discussion, this is the proper place to set the alarm. But will set stopPump = TRUE and add ELSE condition for move and check move conditions.

Per our discussion, this is the proper place to set the alarm. But will set stopPump = TRUE and add ELSE condition for move and check move conditions.

3:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:21 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Address code review comments

Options
    • -4
    • +6
    ./App/Controllers/DialInFlow.c
    • -1
    • +1
    ./App/Drivers/Battery.c
    • -1
    • +1
    ./App/Modes/ModeStandby.c
2:56 pm

wbracken  (deleted user)

SW_CONFIG_ENABLE_VALUE should be first blue in if statement

SW_CONFIG_ENABLE_VALUE should be first blue in if statement

2:54 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:44 pm

dcox  (deleted user)

It is reset on Retract / Home completion. Once the Seek occurs, it is no longer valid so I reset it here on Seek completion.SelfTest.c uses this flag in progression from Retract to Preload to Seek ...

It is reset on Retract / Home completion. Once the Seek occurs, it is no longer valid so I reset it here on Seek completion.SelfTest.c uses this flag in progression from Retract to Preload to Seek to Prime. .

2:31 pm

Dong Nguyen

dialysateInPumpRotorCounter.data = 0.0F; Done.

dialysateInPumpRotorCounter.data = 0.0F; Done.

2:28 pm

dcox  (deleted user)

I attempted to do this earlier in the process, but getTreatmentParameterF32() caused a fault when called too early (treat params not ready?).. So I kept it here after determining it was before UI n...

I attempted to do this earlier in the process, but getTreatmentParameterF32() caused a fault when called too early (treat params not ready?).. So I kept it here after determining it was before UI needed it.

1:21 pm

Dong Nguyen

Done.

Done.

1:14 pm

Dong Nguyen

Yes, now call isDialInPumpRunning(). Done.

Yes, now call isDialInPumpRunning(). Done.

1:11 pm

Dong Nguyen

Done.

Done.

1:05 pm

Dong Nguyen <dnguyen@diality.com>

Merge DEN-14150

Options
    • -8
    • +0
    ./App/Controllers/DGInterface.c
    • -0
    • +1
    ./App/Controllers/DialInFlow.c
1:02 pm

Dara Navaei

12:09 pm

wbracken  (deleted user)

Thought we had decided that the standard would be to add the F?

Thought we had decided that the standard would be to add the F?

11:57 am

Sean Nash

Ok to calculate here (this is called before UI needs it I assume). I was expecting this to be pre-calculated on exit of treatment params mode or on entry to pre-treatment mode when we have what we ...

Ok to calculate here (this is called before UI needs it I assume). I was expecting this to be pre-calculated on exit of treatment params mode or on entry to pre-treatment mode when we have what we need to do the calculation.

11:43 am

Sean Nash

I would think this alarm would be triggered generally by driver because current mode said we shouldn't see syringe yet. Can we just set stopPump to TRUE here and nothing else?

I would think this alarm would be triggered generally by driver because current mode said we shouldn't see syringe yet.
Can we just set stopPump to TRUE here and nothing else?

11:37 am

Sean Nash

No harm in adding "F" suffix, but not necessary for assignment to a float variable - assignment statement is inherently typed. We need the "F" suffix where typing is not assured (e.g. #define where...

No harm in adding "F" suffix, but not necessary for assignment to a float variable - assignment statement is inherently typed. We need the "F" suffix where typing is not assured (e.g. #define where we don't know how it will be used).

11:33 am

Sean Nash

We probably don't need this flag at this point, but should we reset this flag on exit of retract (after treatment done)?

We probably don't need this flag at this point, but should we reset this flag on exit of retract (after treatment done)?

11:26 am

Sean Nash

I think this should probably be reset elsewhere. Init function and on exit of retract maybe?

I think this should probably be reset elsewhere. Init function and on exit of retract maybe?

11:16 am

Sean Nash

Probably could just be if ( TRUE == isSyringePumpPreLoaded() ).

Probably could just be if ( TRUE == isSyringePumpPreLoaded() ).

Thursday 03 Nov 2022
5:38 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/HDCommon.h