hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 15 Jun 2023
10:54 am

dcox  (deleted user)

10:25 am

wbracken  (deleted user) and Sean Nash

10:25 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:19 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:17 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:16 am

Sean Nash

Align the TRUEs.

Align the TRUEs.

10:14 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:12 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:12 am

Sean Nash

Looks like they do need to do the same thing. We should combine with condition above.

Looks like they do need to do the same thing. We should combine with condition above.

10:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:09 am

Sean Nash

Don't need this include.

Don't need this include.

9:47 am

Michael Garthwaite

With this being a WIP im unsure at the moment if both conditions need to do the same thing.

With this being a WIP im unsure at the moment if both conditions need to do the same thing.

9:45 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:45 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:45 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:44 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:44 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:22 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Wednesday 14 Jun 2023
6:23 pm

Dara Navaei

Please remove the extra blank line.

Please remove the extra blank line.

5:38 pm

dcox  (deleted user)

State removed.

State removed.

5:16 pm

Sean Nash

Add blank line after function scope.

Add blank line after function scope.

5:16 pm

Sean Nash

I think we should be checking alarm condition instead of alarm active. Temperature may have come back into range (condition cleared) but user hasn't resumed to clear alarm (maybe stepped away for a...

I think we should be checking alarm condition instead of alarm active. Temperature may have come back into range (condition cleared) but user hasn't resumed to clear alarm (maybe stepped away for a minute).

5:14 pm

Sean Nash

Why is this a separate condition when it's doing the exact same thing as above?

Why is this a separate condition when it's doing the exact same thing as above?

5:13 pm

Sean Nash

Add space between if and (.

Add space between if and (.

5:11 pm

Sean Nash

If you search for where execReservoirs() is called, you will see that it's already called by ModeTreatment.c right before this function is called.

If you search for where execReservoirs() is called, you will see that it's already called by ModeTreatment.c right before this function is called.

4:52 pm

Sean Nash

The next state - which should now be the first drain state - also checks DG modes. I don't see an issue with removing this state except that next state needs to check for DG in fault mode so that i...

The next state - which should now be the first drain state - also checks DG modes. I don't see an issue with removing this state except that next state needs to check for DG in fault mode so that it will skip past drain state.

4:50 pm

Sean Nash

CLOSED in CODE WALKTHROUGH.

CLOSED in CODE WALKTHROUGH.

4:18 pm

dcox  (deleted user)

Not required. checkPostTreatmentPatientDisconnect() releases the door closed requirements when user confirms patient disconnect. Removed.

Not required. checkPostTreatmentPatientDisconnect() releases the door closed requirements when user confirms patient disconnect. Removed.

4:08 pm

dcox  (deleted user)

I left it because DG modes are checked and thought it must be waiting for DG mode to sync before moving on. If not an issue, I can remove it.

I left it because DG modes are checked and thought it must be waiting for DG mode to sync before moving on. If not an issue, I can remove it.