leahi-application / sources / gui / qml

AlarmItem.qml

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 11 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 04 Sep
9:42 am

Dara Navaei

9:41 am

Dara Navaei

LDT-1788 - Feature/LDT-1788 - General Alarm Instructions With New Design
LDT-1788 - Feature/LDT-1788 - General Alarm Instructions With New Design
Wednesday 13 Aug
6:07 pm

Behrouz NematiPour

5:09 pm

Behrouz NematiPour and Stephen Quong

4:11 pm

Stephen Quong

RESOLVED

RESOLVED

4:11 pm

Stephen Quong

RESOLVED

RESOLVED

4:11 pm

Stephen Quong

RESOLVED

RESOLVED

3:09 pm

Behrouz NematiPour

BN: RESOLVED

BN: RESOLVED

3:07 pm

Behrouz NematiPour

BN: RESOLVED

BN: RESOLVED

2:24 pm

Nicholas Ramirez

updated

updated

2:24 pm

Nicholas Ramirez

updated

updated

2:23 pm

Nicholas Ramirez

updated

updated

2:23 pm

Nicholas Ramirez

as discussed to add the space after the parenthesis. updated all instances

as discussed to add the space after the parenthesis. updated all instances

1:46 pm

Behrouz NematiPour

I agree with this comment, to make the code fit in a shorter vertical area. Please use the Bjarne Stroustrup everywhere and be consistent: if () { } else { }

I agree with this comment, to make the code fit in a shorter vertical area.
Please use the Bjarne Stroustrup everywhere and be consistent:

if () {
}
else {
}
1:43 pm

Behrouz NematiPour

Stephen Quong Please let's do that only for the long template-based iterator types, and not for all the variables. And agree with using const and also & when applicable.

Stephen Quong
Please let's do that only for the long template-based iterator types, and not for all the variables.

And agree with using const and also & when applicable.

1:40 pm

Stephen Quong

Remove leading and trailing spaces in if conditionals to keep style consistent.

Remove leading and trailing spaces in if conditionals to keep style consistent.

1:39 pm

Stephen Quong

Declare variables using 'auto' and 'const auto' where possible, especially where initializing the variable.

Declare variables using 'auto' and 'const auto' where possible, especially where initializing the variable.

1:34 pm

Stephen Quong

Change to match other beginning { style.

Change to match other beginning { style.

1:34 pm

Stephen Quong

Change to match other beginning { style.

Change to match other beginning { style.

1:33 pm

Stephen Quong

Change to match above beginning { style.

Change to match above beginning { style.

1:03 pm

Behrouz NematiPour

RESOLVED.

RESOLVED.

1:00 pm

Behrouz NematiPour

RESOLVED.

RESOLVED.

1:00 pm

Behrouz NematiPour

RESOLVED.

RESOLVED.

11:32 am

Nicholas Ramirez

updated to parse and do nothing

updated to parse and do nothing

11:32 am

Nicholas Ramirez

removed

removed

11:31 am

Nicholas Ramirez

LDT-1793 General Alarm Requirements - SW - 01 - Instructions with new design - R&I - 05: DEV - Feature Implementation

address CR commetns and fix qml errors

Options
    • -1
    • +0
    ./AlarmItem.qml
  2. … 3 more files in changeset.
10:53 am

Nicholas Ramirez

revert this too

revert this too

10:53 am

Nicholas Ramirez

revert

revert

10:51 am

Nicholas Ramirez

you have been removed

you have been removed

10:49 am

Behrouz NematiPour

RESOLVED.

RESOLVED.