HeaderbarInformation.qml

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LEAHI-APPLICATION-LDT-2359_Software Upgrade - SW - 01 - Qt6-LTS Investigation - R&I
LEAHI-APPLICATION-LDT-2359_Software Upgrade - SW - 01 - Qt6-LTS Investigation - R&I
RESOLVED

RESOLVED

RESOLVED

RESOLVED

updated naming

updated naming

Thanks for updating the names. Please make the object name match the Component name. While you are doing that, could you also please remove the Dialog from the new name: HeaderbarWiFi { id:...

Thanks for updating the names.
Please make the object name match the Component name.
While you are doing that, could you also please remove the Dialog from the new name:

HeaderbarWiFi         { id: _headerbarWifi                  }
HeaderbarInformation  { id: _headerbarInformation           }
RESOLVED

RESOLVED

i moved it and renamed the files.

i moved it and renamed the files.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

To be consistent with the other qml files, always move this onComplete to the end of the file.

To be consistent with the other qml files, always move this onComplete to the end of the file.

RESOLVED

RESOLVED

updated

updated

updated

updated

updated

updated

removed calculation and hard coded column widths

removed calculation and hard coded column widths

updated

updated

We should add a DSP for display the information to the user. everytihg start from user but we do not have a response comming back to the user.

We should add a DSP for display the information to the user.
everytihg start from user but we do not have a response comming back to the user.

Make each of these, as properties with constant values. *_rightColumnWidth *_leftColumnWidth *_columnSpacing

Make each of these, as properties with constant values.

  • _rightColumnWidth
  • _leftColumnWidth
  • _columnSpacing
These are not dynamic texts, and calculating the width is not necessary. Please look at the implemented UI and set the width of each column as a constant value. You can then also delete textMetrics...

These are not dynamic texts, and calculating the width is not necessary.
Please look at the implemented UI and set the width of each column as a constant value.
You can then also delete textMetrics.
Please note that it should have started with '_' if we were going to keep it.

Generally, please avoid these types of calculations.

Please make this URL a property on top of the Dialog.

Please make this URL a property on top of the Dialog.

RESOLVED.

RESOLVED.

this has been removed

this has been removed

Remove unneeded semicolons.

Remove unneeded semicolons.

Have you tested the race condition here? Is the _repeater initialized before the property being initialized? How do you make sure we do not have a race condition?

Have you tested the race condition here?
Is the _repeater initialized before the property being initialized?
How do you make sure we do not have a race condition?

LDT-1636 - Feature/LDT-1636 - Headerbar - Information
LDT-1636 - Feature/LDT-1636 - Headerbar - Information