Fisheye on leahi-dialin/leahi_dialin/ui

LEAHI-DIALIN-LDT-4979-6: reviewers finished

Mon, 20 Jul 2026 15:26:53 -0700

Stephen Quong , Tiffany Mejia and Behrouz NematiPour finished reviewing LEAHI-DIALIN-LDT-4979-6

LEAHI-DIALIN-LDT-4979_SW Misc & Enhc - SW - 01 - SW Integration - Pre-Tx - R&I

leahi-dialin (feature/LDT-4767-enhancement-Isolated-UF): LDT-4775 SW Misc & Enhc - SW - 01 - Isolated UF - R&I - 08: DEV - Dialin Implementation...

Nicholas Ramirez — Mon, 20 Jul 2026 09:55:13 -0700

Nicholas Ramirez committed d57e7ed on branch feature/LDT-4767-enhancement-Isolated-UF in leahi-dialin

LDT-4775 SW Misc & Enhc - SW - 01 - Isolated UF - R&I - 08: DEV - Dialin Implementation

update iso uf broacast

· /leahi_dialin/ui/td_messaging.py

(-9, +15)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-4767-1: started by Dara Navaei

Dara Navaei — Fri, 17 Jul 2026 16:04:03 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4767-1

leahi-dialin (feature/LDT-4767-enhancement-Isolated-UF): LDT-4775 SW Misc & Enhc - SW - 01 - Isolated UF - R&I - 08: DEV - Dialin Implementation...

Nicholas Ramirez — Thu, 16 Jul 2026 16:38:08 -0700

Nicholas Ramirez committed ce1a61b on branch feature/LDT-4767-enhancement-Isolated-UF in leahi-dialin

LDT-4775 SW Misc & Enhc - SW - 01 - Isolated UF - R&I - 08: DEV - Dialin Implementation

added iso uf dialin state

· /leahi_dialin/common/msg_ids.py	(-2, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/ui/td_messaging.py	(-0, +19)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4919-1: reviewers left LEAHI-DIALIN-LDT-4919_SW Misc & Enhc - SW - 01 - ...

Tue, 14 Jul 2026 09:09:13 -0700

Sean Nash left LEAHI-DIALIN-LDT-4919-1

LEAHI-DIALIN-LDT-4919_SW Misc & Enhc - SW - 01 - SW Integration - Rinseback - R&I

LEAHI-DIALIN-LDT-5074-1: reviewers left LEAHI-DIALIN-LDT-5074_SW Misc & Enhc - SW - 01 - ...

Tue, 14 Jul 2026 09:08:14 -0700

Sean Nash left LEAHI-DIALIN-LDT-5074-1

LEAHI-DIALIN-LDT-5074_SW Misc & Enhc - SW - 01 - Feature Complete - R&I

LEAHI-DIALIN-LDT-5074-1: started by Dara Navaei

Dara Navaei — Mon, 13 Jul 2026 10:17:12 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-5074-1

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "Zoltan and I had a meeting, and the counter sol..."

Behrouz NematiPour — Sun, 12 Jul 2026 23:43:02 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

Zoltan and I had a meeting, and the counter solution he provided works better than mine.
He explained to me that my proposed solution has flaws.
RESOLVED.

leahi-dialin (feature/LDT-4919-SW-Integration-Rinseback): LDT-4927 SW Misc & Enhc - SW - 01 - SW Integration - Rinseback - R&I - 08: DEV - Dialin Implementation...

Nicholas Ramirez — Thu, 09 Jul 2026 11:52:53 -0700

Nicholas Ramirez committed bd23fb9 on branch feature/LDT-4919-SW-Integration-Rinseback in leahi-dialin

LDT-4927 SW Misc & Enhc - SW - 01 - SW Integration - Rinseback - R&I - 08: DEV - Dialin Implementation

update recirulate and rinseback

· /leahi_dialin/ui/td_messaging.py

(-6, +4)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-4919-1: started by Dara Navaei

Dara Navaei — Thu, 09 Jul 2026 10:33:34 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4919-1

LEAHI-DIALIN-LDT-4979-6: reviewers left LEAHI-DIALIN-LDT-4979_SW Misc & Enhc - SW - 01 - ...

Thu, 09 Jul 2026 08:40:36 -0700

Sean Nash left LEAHI-DIALIN-LDT-4979-6

LEAHI-DIALIN-LDT-4979_SW Misc & Enhc - SW - 01 - SW Integration - Pre-Tx - R&I

leahi-dialin (feature/LDT-4979-pre-tx-install-complete): LDT-4987 SW Misc & Enhc - SW - 01 - SW Integration - Pre-Tx - R&I - 08: DEV - Dialin Implementation...

Nicholas Ramirez — Wed, 08 Jul 2026 14:19:01 -0700

Nicholas Ramirez committed 3663606 on branch feature/LDT-4979-pre-tx-install-complete, staging in leahi-dialin

LDT-4987 SW Misc & Enhc - SW - 01 - SW Integration - Pre-Tx - R&I - 08: DEV - Dialin Implementation

message added

· /leahi_dialin/ui/td_messaging.py

(-0, +18)

| History

| Source

| Diff

LEAHI-DIALIN-LDT-4979-6: started by Dara Navaei

Dara Navaei — Wed, 08 Jul 2026 14:02:43 -0700

Dara Navaei started review LEAHI-DIALIN-LDT-4979-6

leahi-dialin (feature/LDT-5074-feature-complete): LDT-5082 SW Misc & Enhc - SW - 01 - Miscellaneous - Feature Complete - R&I - 08: DEV - Dialin Implementation...

Nicholas Ramirez — Wed, 08 Jul 2026 12:03:57 -0700

Nicholas Ramirez committed 4f64e52 on branch feature/LDT-5074-feature-complete in leahi-dialin

LDT-5082 SW Misc & Enhc - SW - 01 - Miscellaneous - Feature Complete - R&I - 08: DEV - Dialin Implementation

add dd ro water mode plugin

· /leahi_dialin/common/msg_ids.py	(-1, +2)	\| History	\| Source	\| Diff
· /leahi_dialin/ui/dd_messaging.py	(-0, +17)	\| History	\| Source	\| Diff
· /leahi_dialin/ui/td_messaging.py	(-2, +2)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4787-1: closed by Nicholas Ramirez

Nicholas Ramirez — Thu, 02 Jul 2026 15:39:35 -0700

Nicholas Ramirez Closed LEAHI-DIALIN-LDT-4787-1

LEAHI-DIALIN-LDT-4787-1: reviewers finished

Thu, 02 Jul 2026 15:38:23 -0700

Behrouz NematiPour and Stephen Quong finished reviewing LEAHI-DIALIN-LDT-4787-1

LEAHI-DIALIN-LDT-4787_NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I

LEAHI-DIALIN-LDT-4787-1: comment by Nicholas Ramirez "bn approves"

Nicholas Ramirez — Thu, 02 Jul 2026 15:36:14 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-DIALIN-LDT-4787-1

bn approves

LEAHI-DIALIN-LDT-4747-1: closed by Nicholas Ramirez

Nicholas Ramirez — Thu, 02 Jul 2026 15:35:22 -0700

Nicholas Ramirez Closed LEAHI-DIALIN-LDT-4747-1

LEAHI-DIALIN-LDT-4747-1: reviewers finished

Thu, 02 Jul 2026 15:31:13 -0700

Stephen Quong finished reviewing LEAHI-DIALIN-LDT-4747-1

LDT-4747: SW Integration - FP Diagnostics - DialIn

LEAHI-DIALIN-LDT-4484-1: comment by Zoltan Miskolci "The approach of what this code does and the con..."

Zoltan Miskolci — Wed, 01 Jul 2026 14:28:52 -0700

Zoltan Miskolci replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.

Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "RESOLVED for now."

Behrouz NematiPour — Wed, 01 Jul 2026 12:33:22 -0700

Behrouz NematiPour replied to Behrouz NematiPour in LEAHI-DIALIN-LDT-4484-1

RESOLVED for now.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "I would not do that because the function names ..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:32:17 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

I would not do that because the function names and messages for each project should be different to avoid confusion.
I think that is fine for now.

RESOLVED.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "So the same channels are used for both the Leah..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:07:36 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

So the same channels are used for both the Leahi and Denali?
I am not talking about how collisions are handled; that is handled by the CAN driver, not the FW or SW.
My point is that the CAN Channels by themselves do not have the meaning we want; they are only a priority.
As we defined them, we gave them a meaning as a category; therefore, it is better to name them the Denali/Leahi Channels rather than the CAN Channels.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "RESOLVED."

Behrouz NematiPour — Wed, 01 Jul 2026 12:06:39 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

RESOLVED.

LEAHI-DIALIN-LDT-4484-1: comment by Behrouz NematiPour "{code} def fp_versions(self, major: int, minor..."

Behrouz NematiPour — Wed, 01 Jul 2026 12:05:06 -0700

Behrouz NematiPour replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4484-1

def fp_versions(self, major: int, minor: int, micro: int, build: int,
                     fpga_id: int, fpga_major: int, fpga_minor: int, fpga_lab: int,
                     compatibility_rev: int):
     """
     Broadcasts the current dd Version Data (Msg ID: 0x0F, 15)
     Args:
         @param major: (uint) - Major version number
         @param minor: (uint) - Minor version number
         @param micro: (uint) - Micro version number
         @param build: (uint) - Build version number
         @param fpga_id: (int) - FPGA id version number
         @param fpga_major: (int) - FPGA Major version number
         @param fpga_minor: (int) - FPGA Minor version number
         @param fpga_lab: (int) - FPGA Lab version number
         @param compatibility_rev: (uint) - The FWs/UI compatibility revision
     @return: None
     """
     if not self.can_enabled:
         raise ValueError("CAN Interface is not enabled")

     payload =  conversions.unsigned_byte_to_bytearray   (major            )
     payload += conversions.unsigned_byte_to_bytearray   (minor            )
     payload += conversions.unsigned_byte_to_bytearray   (micro            )
     payload += conversions.unsigned_short_to_bytearray  (build            )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_id          )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_major       )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_minor       )
     payload += conversions.unsigned_byte_to_bytearray   (fpga_lab         )
     payload += conversions.unsigned_integer_to_bytearray(compatibility_rev)

     message = CAN.CanMessage.build_message(
                                         channel_id=CAN.CanChannels.fp_sync_broadcast_ch_id,
                                         message_id=msg_ids.MsgIds.MSG_ID_FP_VERSION_RESPONSE.value,
                                         payload=payload)

     self.can_interface.send(message, 0)

leahi-dialin (version_fix): Merge branch 'LDT-4734-temp-comp-conductivity' into develop

Michael Garthwaite — Wed, 01 Jul 2026 10:33:58 -0700

Michael Garthwaite committed c67b334 on branch develop, version_fix in leahi-dialin

Merge branch 'LDT-4734-temp-comp-conductivity' into develop

· /leahi_dialin/common/dd_defs.py	(-5, +7)	\| History	\| Source	\| Diff
· /leahi_dialin/common/msg_ids.py	(-1, +1)	\| History	\| Source	\| Diff
· /leahi_dialin/dd/modules/conductivity_sensors.py	(-59, +22)	\| History	\| Source	\| Diff
· /leahi_dialin/fp/modules/conductivity_sensors.py	(-7, +27)	\| History	\| Source	\| Diff
· /leahi_dialin/ui/fp_messaging.py	(-46, +30)	\| History	\| Source	\| Diff

LEAHI-DIALIN-LDT-4747-1: reviewers left LDT-4747: SW Integration - FP Diagnostics - DialIn

Mon, 29 Jun 2026 18:26:49 -0700

Sean Nash left LEAHI-DIALIN-LDT-4747-1

LDT-4747: SW Integration - FP Diagnostics - DialIn

LEAHI-DIALIN-LDT-4787-1: reviewers left LEAHI-DIALIN-LDT-4787_NON-FEATURE: SW Misc & Enhc ...

Mon, 29 Jun 2026 18:25:59 -0700

Sean Nash left LEAHI-DIALIN-LDT-4787-1

LEAHI-DIALIN-LDT-4787_NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I

LEAHI-DIALIN-LDT-4787-1: comment by Nicholas Ramirez "added name to freed up mesg id"

Nicholas Ramirez — Mon, 29 Jun 2026 14:19:39 -0700

Nicholas Ramirez replied to Zoltan Miskolci in LEAHI-DIALIN-LDT-4787-1

added name to freed up mesg id

LEAHI-DIALIN-LDT-4787-1: comment by Nicholas Ramirez "updated"

Nicholas Ramirez — Mon, 29 Jun 2026 14:19:24 -0700

Nicholas Ramirez replied to Nicholas Ramirez in LEAHI-DIALIN-LDT-4787-1

updated