leahi-testsuites

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
changed as per comment mouseClick(utility.findChildByText(main_menu_container, "Treatment"))

changed as per comment mouseClick(utility.findChildByText(main_menu_container, "Treatment"))

instead of this can we use a wait for object .. mouseClick(waitForObject(settings_menu_object, 2000))

instead of this can we use a wait for object .. mouseClick(waitForObject(settings_menu_object, 2000))

is this check needed? can we just click update to remove the if statement and use waitForObject? Ex. mouseClick(waitForObject(settings_menu_object, 2000))

is this check needed? can we just click update to remove the if statement and use waitForObject?

Ex. mouseClick(waitForObject(settings_menu_object, 2000))

Added test.verify as per comment

Added test.verify as per comment

Added test.verify as per comment

Added test.verify as per comment

Added test.verify as per comment

Added test.verify as per comment

Now I am verifying Heparin containers are visible or not in create rx screen

Now I am verifying Heparin containers are visible or not in create rx screen

For me all test cases getting passed

For me all test cases getting passed

this will work but can be updated to be more flexible and take into account if HeparinSringePump is set to enabled or disabled.. I suggest checking the system.conf first specfically the HeparinSyri...

this will work but can be updated to be more flexible and take into account if HeparinSringePump is set to enabled or disabled.. I suggest checking the system.conf first specfically the HeparinSyringePump and if it is set to 1 then the 3 heparin parameters are visible.

IF HeparinSyringePump is set to 0 then heparin is defeatured and those 3 heparin parameters are not visible and will fail to find and set those values.

this way will not be flexible. We are removing 2 of the pre treatment steps so this case will fail in a future staging build. A better way to check if the steps are shorter or longer is to check if...

this way will not be flexible. We are removing 2 of the pre treatment steps so this case will fail in a future staging build. A better way to check if the steps are shorter or longer is to check if we are in advanced mode.

I suggest checking the system.conf file specifically AdvancedMode if it is set to 0 then we are in standard mode = more steps if AdvancedMode is set to 1 then advanced mode is enabled and we will see the shorter amount of steps

remove the visible property

remove the visible property

in addition to testing the heparin tab in main tx you need to test the heparin parameters in the create rx screen are visible depending if heparin is enabled

in addition to testing the heparin tab in main tx you need to test the heparin parameters in the create rx screen are visible depending if heparin is enabled

please update throughout for testing bools use test.verify

please update throughout for testing bools use test.verify

for testing booleans please use test.verify()

for testing booleans please use test.verify()

for testing booleans please use test.verify()

for testing booleans please use test.verify()

this seems to fail here because if we enter TREATMENT_DIALYSIS_STATE then the Blood Prime screen is not going to show and thus failing the squish test case

this seems to fail here because if we enter TREATMENT_DIALYSIS_STATE then the Blood Prime screen is not going to show and thus failing the squish test case

LEAHI-TESTSUITES-LDT-3060_Service - SW - 02 - Feature Configurations - Q&R
LEAHI-TESTSUITES-LDT-3060_Service - SW - 02 - Feature Configurations - Q&R
LEAHI-TESTSUITES-LDT-2819_Edit Treatment Parameters During Treatment - SW - 02 - Edit Treatment Parameters During Treatment - Q&R
LEAHI-TESTSUITES-LDT-2819_Edit Treatment Parameters During Treatment - SW - 02 - Edit Treatment Parameters During Treatment - Q&R
if it is not in the if block add an empty line.

if it is not in the if block add an empty line.

If all timeouts are set to 3000, please set it as the default for the function parameter to avoid passing it everywhere.

If all timeouts are set to 3000, please set it as the default for the function parameter to avoid passing it everywhere.

should this file be removed?

should this file be removed?

That was a great idea to make it a function. *I would also use different (4) parameters and give them a relevant, short name, so users in the code can set them as false or true without knowing th...

That was a great idea to make it a function.

  • I would also use different (4) parameters and give them a relevant, short name, so users in the code can set them as false or true without knowing the -q meaning.
  • It also gives the application flexibility to change the CLI switches without affecting the rest of the test, and only this function would need to be changed.


How should be developed:

def aut(vDisableTimeout, vDisableCheckIn, vDisableAcknow, vDisableSDFail)


How users use it:

aut(vDisableTimeout = True)

FYI the entire CLI switches:

* Options:
 *   -h, --help                           Displays help on commandline options.
 *   --help-all                           Displays help including Qt specific
 *                                        options.
 *   -v, --version                        Displays version information.
 *   -c, --canOut                         Show the Can Frame Output
 *   -m, --msgOut                         Show the Message Output
 *   -l, --logOut                         Show the Logs Output
 *   -0, --enable-keep-awake              Enable send low priority, empty message
 *                                        on the CANBus just to keep UI board CAN
 *                                        driver awake
 *   -i, --fake-interval <interval>       Test fake message interval(ms)
 *   -f, --fake-message <data>            Test fake message data
 *                                        will use default sequenced long fake
 *                                        message if set to 00(default)
 *                                        will used only if correct integer value
 *                                        assigned for interval option
 *   -b, --fake-message-seq-at-begin      Test fake message sequence at the
 *                                        beginning of the frame
 *   -u, --disable-unhandled-report       Disable unhandled messages report as an
 *                                        error in the log
 *   -d, --disable-dialin-unhandled       Disable the Dialin messages logged as
 *                                        unhandled
 *   -q, --disable-timeout                Disables communication timeout
 *   -a, --disable-alarm-no-minimize      Disables alarm no minimize
 *   -S, --disable-sd-card-fail-log-stop  disable-sd-card-fail-log-stop
 *   -C, --disable-cloudsync-fail-stop    disable-cloudsync-fail-stop
 *   -k, --disable-check-in-log           Disables Check-In Log
 *   -K, --disable-acknow-log             Disables Acknowledgment Log
 *   -D, --enable-dry-demo                Enables Dry-Demo Mode
 *   -A, --active-can-bus <CANBus>        Sets the Active CANBus [Shall start with
 *                                        'can' or 'vcan]
 *   -E, --enable-manufacturing           Enables the manufacturing mode to
 *                                        configure the system for the first time.
 *   -R, --use-root-home                  In case the application is not in
 *                                        Manufacturing Setup but needs to use root
 *                                        home folder for configurations.
 *   -U, --enable-update-mode             Enables the update mode to update only
 *                                        necessary files during the update and
 *                                        keep the rest.
 *   -x, --use-log-long-name              Use the log long file name format
 *                                        <date>_<time>_<serial>_<mode>
 *   -y, --use-log-cloud-upload           Use the log cloud upload
 *   -z, --use-log-compression            Use the log compression
 *   -L, --use-log-unhandled-only         Use the unhandled messages only to log
I don't think anything other than the container, and [ id or objectName ] should be in the object definition dictionary. If, as an example, the passwordCharacter is changed to #, the object cannot ...

I don't think anything other than the container, and [ id or objectName ] should be in the object definition dictionary.
If, as an example, the passwordCharacter is changed to #, the object cannot be found. same for echoMode.

Isn't it better to name it like "findAllChildrenById"? Children instead of Objects? *And why do we add the parent, too? *That could be because you are using a recursive function, and I am not s...
  • Isn't it better to name it like "findAllChildrenById"? Children instead of Objects?
  • And why do we add the parent, too?
    • That could be because you are using a recursive function, and I am not sure that is necessary.
  • Any object in QML has "id", do we need to check that, since it is not like the "objectName"
  • How could all id of the children be the same since there is no RegEx here?
translatable. I won't repeat the same comment, but I see the same pattern elsewhere.

translatable.
I won't repeat the same comment, but I see the same pattern elsewhere.

Multiple lines of the texts here are translatable. I think we need to create a separate Python file for text-only content, so we can load different versions of it depending on the language we set b...

Multiple lines of the texts here are translatable.
I think we need to create a separate Python file for text-only content, so we can load different versions of it depending on the language we set before each test.
Additionally, another idea is to separate any text verification into a translation test case for the entire application using the Python file I mentioned above.
Nicholas Ramirez What are your thoughts on that?

Removed the duplicate objects

Removed the duplicate objects

updated to utility.aut("-q")

updated to utility.aut("-q")

updated as per comment

updated as per comment

updated to utility.aut("-q")

updated to utility.aut("-q")