leahi-testsuites / suite_leahi

shared

Clone Tools

Stats

Commits this week: 8
Total Committers: 4
Last Commit: 03 Feb
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 03 Feb
12:43 am

Vendor - TEL - Divya Sree Nidamamidi

try catch is avoided as per suggestion

try catch is avoided as per suggestion

12:42 am

Vendor - TEL - Divya Sree Nidamamidi

try catch is removed

try catch is removed

12:42 am

Vendor - TEL - Divya Sree Nidamamidi

Moved all the constants to config.py file

Moved all the constants to config.py file

12:41 am

Vendor - TEL - Divya Sree Nidamamidi

Removed the line

Removed the line

12:40 am

Vendor - TEL - Divya Sree Nidamamidi

Method name is changed and added docstring and method is available in navigation.py file

Method name is changed and added docstring and method is available in navigation.py file

12:40 am

Vendor - TEL - Divya Sree Nidamamidi

Method is moved to navigation.py file

Method is moved to navigation.py file

Monday 02 Feb
11:12 pm

Vendor - TEL - Shivaprasad Basavaraju

this function also contains Wi-Fi Screen Parameters and Navigate to Wi-Fi Screen from Device Settings is not required in others test scripts

this function also contains Wi-Fi Screen Parameters and Navigate to Wi-Fi Screen from Device Settings is not required in others test scripts

11:08 pm

Vendor - TEL - Shivaprasad Basavaraju

updated

updated

10:45 pm

Vendor - TEL - Divya Sree Nidamamidi

code is aligned

code is aligned

10:39 pm

Vendor - TEL - Divya Sree Nidamamidi

All strings are placed in config.py

All strings are placed in config.py

10:38 pm

Vendor - TEL - Divya Sree Nidamamidi

All strings are placed in config.py

All strings are placed in config.py

Friday 30 Jan
10:28 am

Nicholas Ramirez

move this to navigation.py?

move this to navigation.py?

10:28 am

Nicholas Ramirez

Please upload report to https://diality.atlassian.net/browse/LDT-2743

Please upload report to https://diality.atlassian.net/browse/LDT-2743

10:17 am

Behrouz NematiPour

Please add a docstring for this function. And the naming seems like to be better like: navigation_pageIndicator_step(vStep_name)

Please add a docstring for this function.
And the naming seems like to be better like:

navigation_pageIndicator_step(vStep_name)
10:12 am

Behrouz NematiPour

Same (translation)

Same (translation)

10:11 am

Behrouz NematiPour

The translatable strings shall be defined in a global space. Generally, please make sure this is handled everywhere.

The translatable strings shall be defined in a global space.
Generally, please make sure this is handled everywhere.

10:11 am

Nicholas Ramirez

should this method be moved to navigation.py?

should this method be moved to navigation.py?

10:09 am

Nicholas Ramirez

remove commented out line

remove commented out line

10:07 am

Nicholas Ramirez

please move these into the config.py to be consistent with other test cases

please move these into the config.py to be consistent with other test cases

10:02 am

Behrouz NematiPour

When appropriate, align the code.

When appropriate, align the code.

9:59 am

Behrouz NematiPour

As a general note, avoid try-catch. Your code should be prepared for exceptions, not to be surprised.

As a general note, avoid try-catch.
Your code should be prepared for exceptions, not to be surprised.

9:58 am

Behrouz NematiPour

Why do you need try-catch?

Why do you need try-catch?

9:56 am

Behrouz NematiPour

Why do you need this? Is any editor used other than Squish? We need to make sure it is running in the Squish IDE and with its tools on the build server. Preferably, remove it to be consistent.

Why do you need this?
Is any editor used other than Squish?
We need to make sure it is running in the Squish IDE and with its tools on the build server.
Preferably, remove it to be consistent.

Thursday 29 Jan
10:07 pm

Vendor - TEL - Divya Sree Nidamamidi

Added the line

Added the line

10:06 pm

Vendor - TEL - Divya Sree Nidamamidi

Added the line

Added the line

2:09 pm

Nicholas Ramirez

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after waitForObject(names.o_listView_Item)

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after

waitForObject(names.o_listView_Item)

2:09 pm

Nicholas Ramirez

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after waitForObject(names.o_listView_Item)

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after

waitForObject(names.o_listView_Item)

1:46 pm

Nicholas Ramirez

1:25 pm

Behrouz NematiPour

10:02 am

Vendor - TEL - Divya Sree Nidamamidi

Removed the line

Removed the line