Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
this will work but can be updated to be more flexible and take into account if HeparinSringePump is set to enabled or disabled.. I suggest checking the system.conf first specfically the HeparinSyri...

this will work but can be updated to be more flexible and take into account if HeparinSringePump is set to enabled or disabled.. I suggest checking the system.conf first specfically the HeparinSyringePump and if it is set to 1 then the 3 heparin parameters are visible.

IF HeparinSyringePump is set to 0 then heparin is defeatured and those 3 heparin parameters are not visible and will fail to find and set those values.

this way will not be flexible. We are removing 2 of the pre treatment steps so this case will fail in a future staging build. A better way to check if the steps are shorter or longer is to check if...

this way will not be flexible. We are removing 2 of the pre treatment steps so this case will fail in a future staging build. A better way to check if the steps are shorter or longer is to check if we are in advanced mode.

I suggest checking the system.conf file specifically AdvancedMode if it is set to 0 then we are in standard mode = more steps if AdvancedMode is set to 1 then advanced mode is enabled and we will see the shorter amount of steps

remove the visible property

remove the visible property

Removed the duplicate objects

Removed the duplicate objects

these look like duplicates of already existing object. This CR is for End of treatment and shouldnt have any pre treatment names under this section

these look like duplicates of already existing object.

This CR is for End of treatment and shouldnt have any pre treatment names under this section

ok them be careful to always use it as: import squish NOT the following as has been stated: from squish import *

ok them be careful to always use it as:

import squish

NOT the following as has been stated:

from squish import  *
i believe it is necessary for a custom module.. https://doc.qt.io/squish/python-notes.html#squish-funcs-in-py-modules

i believe it is necessary for a custom module.. https://doc.qt.io/squish/python-notes.html#squish-funcs-in-py-modules

Removed the from squish import * line and keeping the import squish in utility.py and navigation.py files

Removed the from squish import * line and keeping the import squish in utility.py and navigation.py files

without squish import in utility file scripts will fail so added import squish line in utility.py and navigation.py file

without squish import in utility file scripts will fail so added import squish line in utility.py and navigation.py file

Please remove squish import everywhere. It is also duplicate here.

Please remove squish import everywhere.
It is also duplicate here.

LEAHI-TESTSUITES-LDT-3014_End of Treatment - SW - 02 - Q&R
LEAHI-TESTSUITES-LDT-3014_End of Treatment - SW - 02 - Q&R
try catch is avoided as per suggestion

try catch is avoided as per suggestion

try catch is removed

try catch is removed

Moved all the constants to config.py file

Moved all the constants to config.py file

Removed the line

Removed the line

Method name is changed and added docstring and method is available in navigation.py file

Method name is changed and added docstring and method is available in navigation.py file

Method is moved to navigation.py file

Method is moved to navigation.py file

code is aligned

code is aligned

All strings are placed in config.py

All strings are placed in config.py

All strings are placed in config.py

All strings are placed in config.py

Please add a docstring for this function. And the naming seems like to be better like: navigation_pageIndicator_step(vStep_name)

Please add a docstring for this function.
And the naming seems like to be better like:

navigation_pageIndicator_step(vStep_name)
Same (translation)

Same (translation)

The translatable strings shall be defined in a global space. Generally, please make sure this is handled everywhere.

The translatable strings shall be defined in a global space.
Generally, please make sure this is handled everywhere.

should this method be moved to navigation.py?

should this method be moved to navigation.py?

remove commented out line

remove commented out line

please move these into the config.py to be consistent with other test cases

please move these into the config.py to be consistent with other test cases

When appropriate, align the code.

When appropriate, align the code.

As a general note, avoid try-catch. Your code should be prepared for exceptions, not to be surprised.

As a general note, avoid try-catch.
Your code should be prepared for exceptions, not to be surprised.