leahi-testsuites / suite_leahi / tst_service_export_logs / testdata

firefox-144.0.2.tar.xz

Clone Tools

Stats

Commits this week: 0
Total Committers: 1
Last Commit: 19 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 06 Nov
10:12 am

Vendor - TEL - Sivvanarayana Kurapati

Tuesday 04 Nov
11:30 am

Nicholas Ramirez

Monday 03 Nov
10:23 am

Vendor - TEL - Shivaprasad Basavaraju

LDT-1059 Device Settings - SW - 02 - Export Log - Q&R - 15: SIT - Software Integration Tests - Squish Qt

Options
    • binary
    ./firefox-144.0.2.tar.xz
  2. … 21 more files in changeset.
10:22 am

Vendor - TEL - Sivvanarayana Kurapati

Updated as suggested.

Updated as suggested.

10:20 am

Vendor - TEL - Sivvanarayana Kurapati

Added comment block and uploaded test report onto Jira.

Added comment block and uploaded test report onto Jira.

10:17 am

Vendor - TEL - Sivvanarayana Kurapati

Updated as per the suggestion.

Updated as per the suggestion.

Thursday 30 Oct
2:19 pm

Behrouz NematiPour

It is ok for now, but from lines 11 to 19, there are still some object names that need to be refactored. Will be mentioned in later reviews,

It is ok for now, but from lines 11 to 19, there are still some object names that need to be refactored.
Will be mentioned in later reviews,

2:12 pm

Behrouz NematiPour

That is fine for now, but please think ahead and move it as soon as you have used it elsewhere. Also, by moving it to a more general place, others will notice and use it, instead of duplicating.

That is fine for now, but please think ahead and move it as soon as you have used it elsewhere.
Also, by moving it to a more general place, others will notice and use it, instead of duplicating.

Wednesday 29 Oct
4:32 pm

Nicholas Ramirez

lets try and avoid using the occurrence property and instead get the parent object which should be a TouchGrid qml component then find the children and find the object in the grid by testing theTex...

lets try and avoid using the occurrence property and instead get the parent object which should be a TouchGrid qml component then find the children and find the object in the grid by testing theText property of the child object "Export Logs"

12:21 pm

Vendor - TEL - Sivvanarayana Kurapati

Updated as suggested.

Updated as suggested.

12:21 pm

Vendor - TEL - Sivvanarayana Kurapati

moved to application_init.py

moved to application_init.py

12:20 pm

Vendor - TEL - Sivvanarayana Kurapati

removed the method def_stop_application(), because not using it in test script.

removed the method def_stop_application(), because not using it in test script.

12:15 pm

Vendor - TEL - Sivvanarayana Kurapati

startApplication method is moved to def main() function. *'-l' is removed and added '-q'
  • startApplication method is moved to def main() function.
  • '-l' is removed and added '-q'
12:13 pm

Vendor - TEL - Sivvanarayana Kurapati

removed the line "app_context = None".

removed the line "app_context = None".

12:12 pm

Vendor - TEL - Sivvanarayana Kurapati

We're using this method specifically in this file, so for now it will remain in test.py

We're using this method specifically in this file, so for now it will remain in test.py

12:08 pm

Vendor - TEL - Sivvanarayana Kurapati

updated all objects names started with o_.

updated all objects names started with o_.

12:08 pm

Vendor - TEL - Sivvanarayana Kurapati

updated all objects names started with o_.

updated all objects names started with o_.

12:07 pm

Vendor - TEL - Sivvanarayana Kurapati

removed the "text" as suggested.

removed the "text" as suggested.

12:05 pm

Vendor - TEL - Sivvanarayana Kurapati

Updated the object names as suggested.

Updated the object names as suggested.

11:59 am

Vendor - TEL - Sivvanarayana Kurapati

updated combobox to o_LogTypeComboBox.

updated combobox to o_LogTypeComboBox.

11:58 am

Vendor - TEL - Sivvanarayana Kurapati

The Objects have been updated for clarity: exportLogsText → o_ExportLogsPageTitleText (refers to the Export Log page title) settingsHomeExportLogs → o_DeviceSettingsTitleText (refers to the Expor...

The Objects have been updated for clarity:

exportLogsText → o_ExportLogsPageTitleText (refers to the Export Log page title)

settingsHomeExportLogs → o_DeviceSettingsTitleText (refers to the Export Log text on the Device Settings page)

Monday 27 Oct
1:07 pm

Behrouz NematiPour

I would move this in the application_init.py

I would move this in the application_init.py

1:06 pm

Behrouz NematiPour

I would move these navigations into a py file like navigation.py to ve used in other places.

I would move these navigations into a py file like navigation.py to ve used in other places.

1:02 pm

Behrouz NematiPour

Shouldn't it be better defined in utility.py, or application_init.py?

Shouldn't it be better defined in utility.py, or application_init.py?

12:59 pm

Behrouz NematiPour

why is this line here?

why is this line here?

12:58 pm

Behrouz NematiPour

1) Always call this like in the def main() function, to make it obvious. 2) Please do not use the "-l" option, which is only for debugging and should not be used as a reliable option; it can be rem...

1) Always call this like in the def main() function, to make it obvious.
2) Please do not use the "-l" option, which is only for debugging and should not be used as a reliable option; it can be removed at any point in time.

12:42 pm

Behrouz NematiPour

Do not use "text" to identify the object; once translated, it cannot be found anymore.

Do not use "text" to identify the object; once translated, it cannot be found anymore.

12:41 pm

Behrouz NematiPour

Same here. And all the other same instances. *Please add the container/use case in the name if the object is not generally unique. *Add the type at the end if it is not redundant. Example: *o...

Same here.
And all the other same instances.

  • Please add the container/use case in the name if the object is not generally unique.
  • Add the type at the end if it is not redundant.


Example:

  • o_SettigsExportLogs_ProgressRect
12:39 pm

Behrouz NematiPour

Could you remind me what the difference is between this one, "exportLogsText", and the one in line 29, "settingsHomeExportLogs".

Could you remind me what the difference is between this one, "exportLogsText", and the one in line 29, "settingsHomeExportLogs".

12:34 pm

Behrouz NematiPour

Please use more meaningful names. The combobox is too general.

Please use more meaningful names.
The combobox is too general.