Fisheye on ro-firmware/firmware/App/Modes

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): Merge branch 'staging' into LDT-2116-iofp-evaluate-closing-p39

Michael Garthwaite — Thu, 18 Dec 2025 10:59:13 -0800

Michael Garthwaite committed 44dbba5 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

Merge branch 'staging' into LDT-2116-iofp-evaluate-closing-p39

· /firmware/App/Controllers/PermeateTank.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/FluidPump.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeStandby.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushFilter.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/WaterQualityMonitor.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-5, +5)	\| History	\| Source	\| Diff

ro-firmware (staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 18 Dec 2025 10:27:26 -0800

Dara Navaei committed ca95dc7 on branch LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BoostPump.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/BoostPump.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/PermeateTank.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/PermeateTank.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.h

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Drivers/InternalADC.c

(-0, +16)

| History

| Source

| Diff

… 67 more files in changeset.

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116 addressed rewview comments

Raghu Kallala — Sat, 22 Nov 2025 12:54:01 -0800

Raghu Kallala committed b110edb on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116 addressed rewview comments

· /firmware/App/Controllers/PermeateTank.c	(-5, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushFilter.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-1, +2)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116 addressed review comment

Raghu Kallala — Sat, 22 Nov 2025 12:42:57 -0800

Raghu Kallala committed c0c217f on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116 addressed review comment

· /firmware/App/Modes/ModeGenPermeate.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116 moved ro rejection check to waterQualityMonitors

Raghu Kallala — Sat, 22 Nov 2025 12:28:36 -0800

Raghu Kallala committed a871122 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116 moved ro rejection check to waterQualityMonitors

· /firmware/App/Modes/ModeGenPermeate.c	(-8, +2)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-0, +21)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/WaterQualityMonitor.h	(-0, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): Fixed reset during fill and full. Adjusted samples for duty cycle average calculation.

Raghu Kallala — Thu, 20 Nov 2025 14:43:18 -0800

Raghu Kallala committed bb1b586 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

Fixed reset during fill and full. Adjusted samples for duty cycle average calculation.

· /firmware/App/Controllers/ROPump.c	(-2, +10)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-6, +3)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116 RO RR and duty cycle to start with has been updated

Raghu Kallala — Tue, 18 Nov 2025 12:58:11 -0800

Raghu Kallala committed 764e0e8 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116 RO RR and duty cycle to start with has been updated

· /firmware/App/Modes/ModeGenPermeate.c	(-10, +23)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-4, +4)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116 Added code for RO rejection ratio broadcast and dialin overrides.

Raghu Kallala — Thu, 13 Nov 2025 11:52:56 -0800

Raghu Kallala committed 5ad3da2 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116 Added code for RO rejection ratio broadcast and dialin overrides.

· /firmware/App/Modes/ModeGenPermeate.c	(-4, +2)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-2, +190)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.h	(-0, +18)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-1, +3)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116 changed Gen logic to go open loop for 3 sec and transition to closed loop.

Raghu Kallala — Mon, 10 Nov 2025 13:30:25 -0800

Raghu Kallala committed 3475e61 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116 changed Gen logic to go open loop for 3 sec and transition to closed loop.

· /firmware/App/Controllers/PermeateTank.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-1, +105)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116: removed manual level control out of pre gen mode. Permeate tank control will be sub mode specific. implemented...

Michael Garthwaite — Wed, 05 Nov 2025 09:07:16 -0800

Michael Garthwaite committed b6b45de on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116: removed manual level control out of pre gen mode. Permeate tank control will be sub mode specific. implemented in permeate flush to prevent overfill

· /firmware/App/Modes/FlushPermeate.c	(-0, +13)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-14, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116: code review updates. Change target flow rate from 700 to 750 per system spec. Reverted debugging broadcast for...

Michael Garthwaite — Mon, 03 Nov 2025 09:10:13 -0800

Michael Garthwaite committed 6a318f2 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116: code review updates. Change target flow rate from 700 to 750 per system spec. Reverted debugging broadcast for RO Pump.

· /firmware/App/Controllers/PermeateTank.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-10, +10)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116: fixed handle function call where it shouldnt have been called.

Michael Garthwaite — Fri, 31 Oct 2025 08:50:31 -0700

Michael Garthwaite committed f93be5a on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116: fixed handle function call where it shouldnt have been called.

· /firmware/App/Modes/FlushConcentrate.c

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116: Updates to pre gen tank control such that it does not recirculate water while in the op mode.

Michael Garthwaite — Thu, 30 Oct 2025 13:54:12 -0700

Michael Garthwaite committed 74be2e3 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116: Updates to pre gen tank control such that it does not recirculate water while in the op mode.

· /firmware/App/Modes/FPModeStandby.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +15)	\| History	\| Source	\| Diff

ro-firmware (LDT-2116-iofp-evaluate-closing-p39): LDT-2116: Added concentrate flush changes to keep the permeate tank full in pre-gen

Michael Garthwaite — Wed, 29 Oct 2025 08:43:45 -0700

Michael Garthwaite committed aab4ab3 on branch LDT-2116-iofp-evaluate-closing-p39 in ro-firmware

LDT-2116: Added concentrate flush changes to keep the permeate tank full in pre-gen

· /firmware/App/Modes/FlushConcentrate.c	(-16, +57)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1809 Resolved conflicts while merging staging

Raghu Kallala — Thu, 04 Sep 2025 13:19:55 -0700

Raghu Kallala committed 60df6fd on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

LDT-1809 Resolved conflicts while merging staging

· /firmware/App/Controllers/ROPump.c	(-16, +35)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): LDT-1735: fixed merge conflicts.

Wed, 03 Sep 2025 14:28:04 -0700

Shyam Kumar Mathamala committed d5f58f8 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 4 more in ro-firmware

LDT-1735: fixed merge conflicts.

· /firmware/App/Modes/InletPressureCheck.c	(-0, +368)	\| History	\| Source
· /firmware/App/Services/Messaging.c	(-0, +3)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: code review comments. comment aligning. fix ro pump control calling set pwm pct when it should have been pwm c...

Michael Garthwaite — Wed, 03 Sep 2025 09:44:56 -0700

Michael Garthwaite committed 30c175a on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: code review comments. comment aligning. fix ro pump control calling set pwm pct when it should have been pwm cnt

· /firmware/App/Controllers/PermeateTank.c	(-8, +11)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/InletPressureCheck.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Merge branch 'staging' into LDT-1242-iofp-finalize-permeate-tank

Michael Garthwaite — Wed, 03 Sep 2025 08:49:43 -0700

Michael Garthwaite committed c0fe2ab on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

Merge branch 'staging' into LDT-1242-iofp-finalize-permeate-tank

· /firmware/App/Modes/ModePreGenPermeate.c

(-1, +8)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: added TODO for condition check when P7 is no longer available.

Michael Garthwaite — Wed, 03 Sep 2025 08:42:14 -0700

Michael Garthwaite committed 85ec68b on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: added TODO for condition check when P7 is no longer available.

· /firmware/App/Modes/FlushConcentrate.c

(-2, +2)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1809 latest from staging

Raghu Kallala — Tue, 02 Sep 2025 11:10:25 -0700

Raghu Kallala committed 62c5b1e on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

LDT-1809 latest from staging

· /firmware/App/Modes/ModePreGenPermeate.c

(-1, +8)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: updates to pre gen mode timeouts

Michael Garthwaite — Fri, 29 Aug 2025 09:14:37 -0700

Michael Garthwaite committed d163e3c on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: updates to pre gen mode timeouts

· /firmware/App/Modes/FlushPermeate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Updated ToDo check for inletpressurecheck init call

Raghu Kallala — Thu, 28 Aug 2025 13:40:10 -0700

Raghu Kallala committed c97730c on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Updated ToDo check for inletpressurecheck init call

· /firmware/App/Modes/ModePreGenPermeate.c

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-1242: updated flow control curve. Renamed fp def op modes. Closing P39 on TANK FULL state

Michael Garthwaite — Thu, 28 Aug 2025 08:51:16 -0700

Michael Garthwaite committed af6229d on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 3 more in ro-firmware

LDT-1242: updated flow control curve. Renamed fp def op modes. Closing P39 on TANK FULL state

· /firmware/App/Controllers/PermeateTank.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPOperationModes.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeateDefeatured.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeateDefeatured.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/DDInterface.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Addressed review comment to remove flag assignment in paused state.

Raghu Kallala — Wed, 27 Aug 2025 08:16:33 -0700

Raghu Kallala committed f31d172 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Addressed review comment to remove flag assignment in paused state.

· /firmware/App/Modes/InletPressureCheck.c

(-1, +0)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

Raghu Kallala — Tue, 26 Aug 2025 10:37:51 -0700

Raghu Kallala committed ba9341b on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

· /firmware/App/Controllers/ROPump.c	(-100, +62)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushConcentrate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FlushPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-1, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Addressed review comments.

Raghu Kallala — Wed, 20 Aug 2025 06:31:28 -0700

Raghu Kallala committed e91ecdf on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Addressed review comments.

· /firmware/App/Modes/InletPressureCheck.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/InletPressureCheck.h	(-4, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-2, +0)	\| History	\| Source	\| Diff

ro-firmware (LDT-1735-test-config-support-for-dd): Addressed review comments to remove unwanted code lines and handled state assignment.

Raghu Kallala — Tue, 19 Aug 2025 10:24:42 -0700

Raghu Kallala committed 44b3345 on branch LDT-1735-test-config-support-for-dd, LDT-1773-iofp-valve-pwm and 5 more in ro-firmware

Addressed review comments to remove unwanted code lines and handled state assignment.

· /firmware/App/Modes/InletPressureCheck.c	(-4, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/InletPressureCheck.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreGenPermeate.c	(-0, +1)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-566: increased permeate flush timer to 5 minutes to support conductivity testing.

Michael Garthwaite — Wed, 13 Aug 2025 15:41:23 -0700

Michael Garthwaite committed 684099b on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 4 more in ro-firmware

LDT-566: increased permeate flush timer to 5 minutes to support conductivity testing.

· /firmware/App/Modes/FlushPermeate.c

(-1, +1)

| History

| Source

| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-566: moved valve enum from ro firmware repo to common repo

Michael Garthwaite — Wed, 13 Aug 2025 12:34:01 -0700

Michael Garthwaite committed e8d9c00 on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 2 more in ro-firmware

LDT-566: moved valve enum from ro firmware repo to common repo

· /firmware/App/Controllers/Valves.c	(-20, +20)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-21, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeFault.c	(-2, +2)	\| History	\| Source	\| Diff

ro-firmware (LDT-1773-iofp-valve-pwm): LDT-566: moved valve enum from ro firmware repo to common repo

Michael Garthwaite — Wed, 13 Aug 2025 12:34:01 -0700

Michael Garthwaite committed 014dc3d on branch LDT-1773-iofp-valve-pwm, LDT-1809-iofp-ws-setup-and-bug-fixing and 4 more in ro-firmware

LDT-566: moved valve enum from ro firmware repo to common repo

· /firmware/App/Controllers/Valves.c	(-20, +20)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-21, +5)	\| History	\| Source	\| Diff
· /firmware/App/Modes/FPModeFault.c	(-2, +2)	\| History	\| Source	\| Diff