Fisheye on td-firmware/firmware/App/Modes/StateTxRecirc.c

Fisheye on td-firmware/firmware/App/Modes/StateTxRecirc.c https://devapps.diality.us/changelog/td-firmware/firmware/App/Modes/StateTxRecirc.c Recent activity in "td-firmware" under directory /firmware/App/Modes/StateTxRecirc.c LEAHI-TD-FIRMWARE-LDT-4040-1: comment by Vendor - TEL - Praneeth Bunne "it will be adjusted when I merge latest staging" Fri, 10 Jul 2026 15:32:49 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30432 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30432 Vendor - TEL - Praneeth Bunne replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4040-1

it will be adjusted when I merge latest staging

]]> LEAHI-TD-FIRMWARE-LDT-4040-1: comment by Vendor - TEL - Praneeth Bunne "not required anymore, forgot to remove" Fri, 10 Jul 2026 15:31:22 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30431 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30431 Vendor - TEL - Praneeth Bunne replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4040-1

not required anymore, forgot to remove

]]> LEAHI-TD-FIRMWARE-LDT-4040-1: comment by Sean Nash "I think a comment here is needed. Keep it and ..." Fri, 10 Jul 2026 15:21:20 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30429 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30429 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4040-1

I think a comment here is needed. Keep it and maybe mention rinseback alarm responses too.

]]> LEAHI-TD-FIRMWARE-LDT-4040-1: comment by Sean Nash "Maybe this should be handled in OperationModes ..." Fri, 10 Jul 2026 15:20:19 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30428 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30428 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4040-1

Maybe this should be handled in OperationModes exec since it applies to all confirmations (not just alarm related ones).

]]> LEAHI-TD-FIRMWARE-LDT-4040-1: comment by Sean Nash "There will be confirmations that are not handle..." Fri, 10 Jul 2026 15:18:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30427 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30427 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4040-1

There will be confirmations that are not handled here (e.g. power off). So we shouldn't fault in default - we should do nothing.

]]> LEAHI-TD-FIRMWARE-LDT-4040-1: comment by Sean Nash "Shutdown would be handled somewhere else (butto..." Fri, 10 Jul 2026 15:17:29 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30426 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30426 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4040-1

Shutdown would be handled somewhere else (buttons.c probably). It's not related to alarms.

]]> LEAHI-TD-FIRMWARE-LDT-4040-1: comment by Sean Nash "Is this still possible since we're not returnin..." Fri, 10 Jul 2026 15:09:58 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30425 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30425 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4040-1

Is this still possible since we're not returning to TxPaused from rinseback anymore?

]]> LEAHI-TD-FIRMWARE-LDT-4040-1: comment by Sean Nash "Is rinseback completed an indication that we've..." Fri, 10 Jul 2026 11:12:08 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30420 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30420 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4040-1

Is rinseback completed an indication that we've done a blood prime following a temporary break?
If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjust the UF rate so that we will reach the new (larger) UF volume when the treatment completes.
We also need to add RB volume to UF volume in pre-tx when treatment parameters are given/validated (for the final rinseback which we will always have so we should just plan for it before treatment starts).

]]> LEAHI-TD-FIRMWARE-LDT-4040-1: comment by Sean Nash "What if multiple confirmations pending? Which ..." Fri, 10 Jul 2026 11:02:58 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30419 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30419 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4040-1

What if multiple confirmations pending? Which ID will this function return?

]]> LEAHI-TD-FIRMWARE-LDT-4040-1: comment by Sean Nash "Align comments. Should substitution pump data ..." Fri, 10 Jul 2026 10:54:37 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30418 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1/#c30418 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4040-1

Align comments.
Should substitution pump data be moved down to 0xBA instead of commented out?

]]> LEAHI-TD-FIRMWARE-LDT-4040-1: started by Dara Navaei Thu, 09 Jul 2026 13:33:39 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4040-1 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-4040-1 ]]> td-firmware (LDT-4040-rinseback): LDT-4040: Add rinseback realted code Thu, 09 Jul 2026 11:44:54 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/changelog/td-firmware?cs=1275f9e92eb1ab0cd1b321c0c8eb940524e22117 https://devapps.diality.us/changelog/td-firmware?cs=1275f9e92eb1ab0cd1b321c0c8eb940524e22117 Vendor - TEL - Praneeth Bunne committed 1275f9e on branch LDT-4040-rinseback in td-firmware LDT-4040: Add rinseback realted code

· /firmware/App/Modes/ModeTreatment.c (-77, +167) | History | Source | Diff

· /firmware/App/Modes/ModeTreatment.h (-0, +5) | History | Source | Diff

· /firmware/App/Modes/OperationModes.c (-82, +129) | History | Source | Diff

· /firmware/App/Modes/OperationModes.h (-0, +15) | History | Source | Diff

· /firmware/App/Modes/StateTxBloodPrime.c (-0, +1) | History | Source | Diff

· /firmware/App/Modes/StateTxDialysis.c (-0, +1) | History | Source | Diff

· /firmware/App/Modes/StateTxPaused.c (-1, +3) | History | Source | Diff

· /firmware/App/Modes/StateTxRecirc.c (-0, +584) | History | Source

· /firmware/App/Modes/StateTxRecirc.h (-0, +51) | History | Source

· /firmware/App/Modes/StateTxRinseback.c (-0, +969) | History | Source

· /firmware/App/Modes/StateTxRinseback.h (-0, +67) | History | Source

· /firmware/App/Services/AlarmMgmtSWFaults.h (-0, +3) | History | Source | Diff

· /firmware/App/Services/AlarmMgmtTD.c (-8, +68) | History | Source | Diff

· /firmware/App/Services/AlarmMgmtTD.h (-1, +4) | History | Source | Diff

· /firmware/App/Services/Messaging.c (-0, +65) | History | Source | Diff

· /firmware/App/Services/Messaging.h (-0, +3) | History | Source | Diff

· /firmware/App/Services/TxParams.c (-1, +2) | History | Source | Diff

]]>