Fisheye on testsuites/simulator/plugins/heparin https://devapps.diality.us/changelog/testsuites/simulator/plugins/heparin Recent activity in "testsuites" under directory /simulator/plugins/heparin TESTSUITES-DEN-9626-1: closed by Behrouz NematiPour Fri, 20 Oct 2023 09:33:53 -0700 Behrouz NematiPour https://devapps.diality.us/cru/TESTSUITES-DEN-9626-1 https://devapps.diality.us/cru/TESTSUITES-DEN-9626-1 Behrouz NematiPour Closed TESTSUITES-DEN-9626-1 ]]> TESTSUITES-DEN-9626-1: reviewers finished Fri, 20 Oct 2023 09:32:57 -0700 https://devapps.diality.us/cru/TESTSUITES-DEN-9626-1 https://devapps.diality.us/cru/TESTSUITES-DEN-9626-1 Dara Navaei and msuleiman  (deleted user) finished reviewing TESTSUITES-DEN-9626-1 TESTSUITES-DEN-9626_UI Dev Bluetoothcuffintegration ]]> TESTSUITES-DEN-8705-2: closed by Behrouz NematiPour Fri, 20 Oct 2023 09:23:22 -0700 Behrouz NematiPour https://devapps.diality.us/cru/TESTSUITES-DEN-8705-2 https://devapps.diality.us/cru/TESTSUITES-DEN-8705-2 Behrouz NematiPour Closed TESTSUITES-DEN-8705-2 ]]> TESTSUITES-DEN-8705-2: reviewers finished Fri, 20 Oct 2023 09:22:35 -0700 https://devapps.diality.us/cru/TESTSUITES-DEN-8705-2 https://devapps.diality.us/cru/TESTSUITES-DEN-8705-2 Behrouz NematiPour and msuleiman  (deleted user) finished reviewing TESTSUITES-DEN-8705-2 TESTSUITES-DEN-8705_Pre Treatment Setup Screen ]]> TESTSUITES-DEN-8705-2: started by Dara Navaei Thu, 19 Oct 2023 20:47:31 -0700 Dara Navaei https://devapps.diality.us/cru/TESTSUITES-DEN-8705-2 https://devapps.diality.us/cru/TESTSUITES-DEN-8705-2 Dara Navaei started review TESTSUITES-DEN-8705-2 ]]> UI-DEN-8705-1: reviewers resumed Thu, 19 Oct 2023 20:26:58 -0700 https://devapps.diality.us/cru/UI-DEN-8705-1 https://devapps.diality.us/cru/UI-DEN-8705-1 pmontazemi  (deleted user) resumed reviewing UI-DEN-8705-1 UI-DEN-8705_Pre Treatment Setup Screen ]]> TESTSUITES-DEN-9626-1: started by Dara Navaei Thu, 19 Oct 2023 20:26:41 -0700 Dara Navaei https://devapps.diality.us/cru/TESTSUITES-DEN-9626-1 https://devapps.diality.us/cru/TESTSUITES-DEN-9626-1 Dara Navaei started review TESTSUITES-DEN-9626-1 ]]> UI-DEN-10602-1: closed by Behrouz NematiPour Mon, 03 Jan 2022 12:37:05 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-10602-1 https://devapps.diality.us/cru/UI-DEN-10602-1 Behrouz NematiPour Closed UI-DEN-10602-1 ]]> UI-DEN-10602-1: reviewers finished Thu, 30 Dec 2021 09:37:13 -0800 https://devapps.diality.us/cru/UI-DEN-10602-1 https://devapps.diality.us/cru/UI-DEN-10602-1 Sean Nash finished reviewing UI-DEN-10602-1 UI-DEN-10602_UI DEV Add PatientID PreTreatment ]]> UI-DEN-10602-1: comment by Sean Nash "RESOLVED." Thu, 30 Dec 2021 09:36:13 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-10602-1/#c11582 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11582 Sean Nash replied to Behrouz NematiPour in UI-DEN-10602-1

RESOLVED.

]]> UI-DEN-10602-1: reviewers finished Tue, 21 Dec 2021 14:03:47 -0800 https://devapps.diality.us/cru/UI-DEN-10602-1 https://devapps.diality.us/cru/UI-DEN-10602-1 Michael Garthwaite finished reviewing UI-DEN-10602-1 UI-DEN-10602_UI DEV Add PatientID PreTreatment ]]> UI-DEN-10602-1: comment by Michael Garthwaite "RESOLVED" Tue, 21 Dec 2021 11:29:32 -0800 Michael Garthwaite https://devapps.diality.us/cru/UI-DEN-10602-1/#c11559 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11559 Michael Garthwaite replied to Behrouz NematiPour in UI-DEN-10602-1

RESOLVED

]]> UI-DEN-10602-1: comment by Behrouz NematiPour "Fixed. Thanks for your attention to the detail..." Fri, 17 Dec 2021 18:45:14 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-10602-1/#c11553 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11553 Behrouz NematiPour replied to Michael Garthwaite in UI-DEN-10602-1

Fixed.
Thanks for your attention to the details.

]]> UI-DEN-10602-1: comment by Michael Garthwaite "Some functions and variables in this file use P..." Fri, 17 Dec 2021 16:00:15 -0800 Michael Garthwaite https://devapps.diality.us/cru/UI-DEN-10602-1/#c11552 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11552 Michael Garthwaite commented on UI-DEN-10602-1

Some functions and variables in this file use PatientID instead of PtientID, was this spelling intentional?

]]> UI-DEN-10602-1: comment by Behrouz NematiPour "Added" Tue, 14 Dec 2021 10:36:08 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-10602-1/#c11529 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11529 Behrouz NematiPour replied to Sean Nash in UI-DEN-10602-1

Added

]]> UI-DEN-10602-1: comment by Sean Nash "Needs function header?" Mon, 13 Dec 2021 16:33:40 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-10602-1/#c11520 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11520 Sean Nash commented on UI-DEN-10602-1

Needs function header?

]]> UI-DEN-10602-1: comment by Behrouz NematiPour "RESOLVED" Mon, 13 Dec 2021 16:15:11 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-10602-1/#c11519 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11519 Behrouz NematiPour replied to Behrouz NematiPour in UI-DEN-10602-1

RESOLVED

]]> UI-DEN-10602-1: comment by Behrouz NematiPour "that is fine because..." Mon, 13 Dec 2021 16:13:41 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-10602-1/#c11517 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11517 Behrouz NematiPour replied to Behrouz NematiPour in UI-DEN-10602-1

that is fine because...

]]> UI-DEN-10602-1: comment by Behrouz NematiPour "it is a test for the code review demo" Mon, 13 Dec 2021 16:12:50 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-10602-1/#c11516 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11516 Behrouz NematiPour commented on UI-DEN-10602-1

it is a test for the code review demo

]]> UI-DEN-10602-1: reviewers added to UI-DEN-10602_UI DEV Add PatientID PreTreatment Thu, 09 Dec 2021 17:18:19 -0800 https://devapps.diality.us/cru/UI-DEN-10602-1 https://devapps.diality.us/cru/UI-DEN-10602-1 Behrouz NematiPour added Dara Navaei and Michael Garthwaite to UI-DEN-10602-1 UI-DEN-10602_UI DEV Add PatientID PreTreatment ]]> UI-DEN-10602-1: reviewers removed from UI-DEN-10602_UI DEV Add PatientID PreTreatment Thu, 09 Dec 2021 17:18:19 -0800 https://devapps.diality.us/cru/UI-DEN-10602-1 https://devapps.diality.us/cru/UI-DEN-10602-1 Behrouz NematiPour removed pmontazemi  (deleted user) from UI-DEN-10602-1 UI-DEN-10602_UI DEV Add PatientID PreTreatment ]]> UI-DEN-10602-1: comment by Sean Nash "RESOLVED." Mon, 29 Nov 2021 12:26:05 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-10602-1/#c11466 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11466 Sean Nash replied to Behrouz NematiPour in UI-DEN-10602-1

RESOLVED.

]]> UI-DEN-10602-1: comment by Sean Nash "RESOLVED." Mon, 29 Nov 2021 12:25:14 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-10602-1/#c11465 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11465 Sean Nash replied to Behrouz NematiPour in UI-DEN-10602-1

RESOLVED.

]]> UI-DEN-10602-1: comment by Sean Nash "RESOLVED." Mon, 29 Nov 2021 12:25:08 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-10602-1/#c11464 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11464 Sean Nash replied to Behrouz NematiPour in UI-DEN-10602-1

RESOLVED.

]]> UI-DEN-10602-1: comment by Behrouz NematiPour "The code was old and not up to our standard. I..." Mon, 29 Nov 2021 10:46:22 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-10602-1/#c11462 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11462 Behrouz NematiPour replied to Sean Nash in UI-DEN-10602-1

The code was old and not up to our standard.
It was in the middle of a huge improvement and test.
It has been completely removed from the screen and moved to the component to avoid redundant code copy/paste.

]]> UI-DEN-10602-1: comment by Behrouz NematiPour "The code was old and not up to our standard. I..." Mon, 29 Nov 2021 10:47:33 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-10602-1/#c11463 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11463 Behrouz NematiPour replied to Sean Nash in UI-DEN-10602-1

The code was old and not up to our standard.
It was in the middle of a huge improvement and test.
It has been completely removed from the screen and moved to the component to avoid redundant code copy/paste.

]]> UI-DEN-10602-1: comment by Behrouz NematiPour "This is a debug code that will be enabled to tr..." Mon, 29 Nov 2021 10:43:52 -0800 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-10602-1/#c11461 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11461 Behrouz NematiPour replied to Sean Nash in UI-DEN-10602-1

This is a debug code that will be enabled to trace the screen stack.
if was only a return, changed to an if to make it conditional for later use.

]]> UI-DEN-10602-1: comment by Sean Nash "Why commented out?" Mon, 29 Nov 2021 08:47:07 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-10602-1/#c11457 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11457 Sean Nash commented on UI-DEN-10602-1

Why commented out?

]]> UI-DEN-10602-1: comment by Sean Nash "Why commented out?" Mon, 29 Nov 2021 08:46:58 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-10602-1/#c11456 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11456 Sean Nash commented on UI-DEN-10602-1

Why commented out?

]]> UI-DEN-10602-1: comment by Sean Nash "Looks like the rest of this function is dead co..." Mon, 29 Nov 2021 08:44:40 -0800 Sean Nash https://devapps.diality.us/cru/UI-DEN-10602-1/#c11455 https://devapps.diality.us/cru/UI-DEN-10602-1/#c11455 Sean Nash commented on UI-DEN-10602-1

Looks like the rest of this function is dead code. Why are we returning here?

]]>