Fisheye on dialin/tests/test_can.py

DIALIN-DEN-8251-1: closed by plucia

plucia — Mon, 24 May 2021 13:13:39 -0700

plucia (deleted user) Closed DIALIN-DEN-8251-1

DIALIN-DEN-8251-1: reviewers finished

Mon, 24 May 2021 13:11:14 -0700

Sean Nash finished reviewing DIALIN-DEN-8251-1

DIALIN-DEN-8251_Sprint 44

DIALIN-DEN-8251-1: reviewers finished

Fri, 21 May 2021 16:38:43 -0700

qnguyen (deleted user) and pmontazemi (deleted user) finished reviewing DIALIN-DEN-8251-1

DIALIN-DEN-8251_Sprint 44

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Fri, 21 May 2021 16:37:31 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Fri, 21 May 2021 16:37:19 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Fri, 21 May 2021 16:36:40 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by plucia "If you select Edit Configuration -> "add conten..."

plucia — Fri, 21 May 2021 15:15:07 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

If you select Edit Configuration -> "add content roots" in PyCharm, it will automatically add /home/denali/Projects/dialin/ to your path before executing the script and there is no longer a need to append to the path in the script. I had selected this option and wasn't having issue running any script.
I've updated all the paths now to support execution from outside of PyCharm.

DIALIN-DEN-8251-1: comment by plucia "Done"

plucia — Fri, 21 May 2021 15:16:11 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done

DIALIN-DEN-8251-1: comment by plucia "Done - just FYI I have added type hints in my S..."

plucia — Fri, 21 May 2021 15:18:06 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done - just FYI I have added type hints in my Sprint 45 branch for the dg classes. So it hasn't been updated almost everywhere inside the dg folder on this Sprint 44 branch

DIALIN-DEN-8251-1: comment by qnguyen "Will this path is enough to find dialin folder ..."

qnguyen — Fri, 21 May 2021 10:29:50 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Will this path is enough to find dialin folder since this has been moved into another folder?

DIALIN-DEN-8251-1: comment by qnguyen "This function and the one below needs to match ..."

qnguyen — Fri, 14 May 2021 10:50:16 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

This function and the one below needs to match the new style.

DIALIN-DEN-8251-1: comment by qnguyen "Change to return type to None and remove not ne..."

qnguyen — Fri, 14 May 2021 10:41:35 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Change to return type to None and remove not needed return 0 to keep consistency with other functions in this file.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Tue, 11 May 2021 13:46:15 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Tue, 11 May 2021 13:46:09 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Tue, 11 May 2021 13:46:02 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by plucia "Done"

plucia — Tue, 11 May 2021 12:17:27 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done

DIALIN-DEN-8251-1: comment by plucia "Done"

plucia — Tue, 11 May 2021 12:18:23 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done

DIALIN-DEN-8251-1: comment by plucia "Done"

plucia — Tue, 11 May 2021 12:19:08 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done

DIALIN-DEN-8251-1: comment by qnguyen "Need file header."

qnguyen — Wed, 05 May 2021 23:08:38 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Need file header.

DIALIN-DEN-8251-1: comment by qnguyen "Need file header (copyright, etc.)"

qnguyen — Wed, 05 May 2021 23:07:05 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Need file header (copyright, etc.)

DIALIN-DEN-8251-1: comment by qnguyen "Mismatch filename."

qnguyen — Wed, 05 May 2021 23:06:06 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Mismatch filename.

DIALIN-DEN-8251-1: started by plucia

plucia — Tue, 04 May 2021 00:02:04 -0700

plucia (deleted user) started review DIALIN-DEN-8251-1

dialin (DEN-12358-sw_dev-sprint-67_mg): Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Dara Navaei — Wed, 21 Oct 2020 11:41:30 -0700

Dara Navaei committed 91dc90b on branch 2020_EOY_DEMO, Calibration_fixes and 263 more in dialin

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

· /dialin/common/msg_defs.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/accelerometer.py

(-10, +8)

| History

| Source

| Diff

· /dialin/dg/dialysate_generator.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/hd_proxy.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/heaters.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/load_cells.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/ro_pump.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/temperature_sensors.py

(-2, +2)

| History

| Source

| Diff

· /dialin/hd/accelerometer.py

(-10, +8)

| History

| Source

| Diff

· /dialin/hd/air_trap.py

(-3, +3)

| History

| Source

| Diff

· /dialin/hd/alarms.py

(-1, +1)

| History

| Source

| Diff

· /dialin/hd/blood_flow.py

(-1, +1)

| History

| Source

| Diff

· /dialin/hd/constants.py

(-2, +2)

| History

| Source

| Diff

· /dialin/hd/dialysate_inlet_flow.py

(-1, +1)

| History

| Source

| Diff

· /dialin/hd/dialysate_outlet_flow.py

(-1, +1)

| History

| Source

| Diff

… 28 more files in changeset.

DIALIN-DEN-4856-1: closed by plucia

plucia — Fri, 16 Oct 2020 14:42:41 -0700

plucia (deleted user) Closed DIALIN-DEN-4856-1

DIALIN-DEN-4856-1: reviewers finished

Fri, 16 Oct 2020 14:41:32 -0700

qnguyen (deleted user) and Sean Nash finished reviewing DIALIN-DEN-4856-1

DIALIN-DEN-4856_Sprint_27

DIALIN-DEN-4856-1: comment by qnguyen "RESOLVED."

qnguyen — Wed, 14 Oct 2020 17:26:05 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-4856-1

RESOLVED.

DIALIN-DEN-4856-1: comment by qnguyen "RESOLVED."

qnguyen — Wed, 14 Oct 2020 16:22:51 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-4856-1

RESOLVED.

DIALIN-DEN-4856-1: comment by qnguyen "RESOLVED."

qnguyen — Wed, 14 Oct 2020 16:22:33 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-4856-1

RESOLVED.

DIALIN-DEN-4856-1: comment by plucia "The version of crucible we're using has an issu..."

plucia — Wed, 14 Oct 2020 15:59:06 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-4856-1

The version of crucible we're using has an issue where duplicate files show in the file viewer on the left.

If you look at the more recent hemodialysis_device.py file (see the files viewer on the left), this message id is removed: http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19219

It is also removed from both msg_defs.py: http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19027 and http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19203

DIALIN-DEN-4856-1: comment by plucia "Done"

plucia — Wed, 14 Oct 2020 15:57:59 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-4856-1

Done