Fisheye on dialin/tests/test_dg.py https://devapps.diality.us/changelog/~br%3D2020_EOY_DEMO/dialin/tests/test_dg.py Recent activity in "dialin" under directory /tests/test_dg.py DIALIN-DEN-8055-1: closed by Dara Navaei Thu, 19 Oct 2023 13:14:50 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-8055-1 https://devapps.diality.us/cru/DIALIN-DEN-8055-1 Dara Navaei Closed DIALIN-DEN-8055-1 ]]> DIALIN-DEN-8055-1: comment by Dara Navaei "RESOLVED" Thu, 19 Oct 2023 13:14:43 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c19197 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c19197 Dara Navaei replied to pmontazemi  (deleted user) in DIALIN-DEN-8055-1

RESOLVED

]]> DIALIN-DEN-8055-1: started by Dara Navaei Thu, 19 Oct 2023 13:13:38 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-8055-1 https://devapps.diality.us/cru/DIALIN-DEN-8055-1 Dara Navaei started review DIALIN-DEN-8055-1 ]]> DIALIN-DEN-8055-1: closed by plucia Tue, 11 May 2021 09:49:19 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-8055-1 https://devapps.diality.us/cru/DIALIN-DEN-8055-1 plucia  (deleted user) Closed DIALIN-DEN-8055-1 ]]> DIALIN-DEN-8055-1: reviewers finished Thu, 06 May 2021 09:40:57 -0700 https://devapps.diality.us/cru/DIALIN-DEN-8055-1 https://devapps.diality.us/cru/DIALIN-DEN-8055-1 qnguyen  (deleted user) and pmontazemi  (deleted user) finished reviewing DIALIN-DEN-8055-1 DIALIN-DEN-8055_Sprint 43 ]]> DIALIN-DEN-8055-1: comment by pmontazemi "RESOLVED." Thu, 06 May 2021 09:34:01 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9765 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9765 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-8055-1

RESOLVED.

]]> DIALIN-DEN-8055-1: comment by pmontazemi "RESOLVED." Thu, 06 May 2021 09:33:53 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9764 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9764 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-8055-1

RESOLVED.

]]> DIALIN-DEN-8055-1: comment by pmontazemi "RESOLVED." Thu, 06 May 2021 09:33:34 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9763 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9763 pmontazemi  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-8055-1

RESOLVED.

]]> DIALIN-DEN-8055-1: comment by Sean Nash "RESOLVED." Wed, 05 May 2021 09:55:16 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9753 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9753 Sean Nash replied to plucia  (deleted user) in DIALIN-DEN-8055-1

RESOLVED.

]]> DIALIN-DEN-8055-1: comment by plucia "Done" Wed, 05 May 2021 09:47:51 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9743 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9743 plucia  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-DEN-8055-1

Done

]]> DIALIN-DEN-8055-1: comment by plucia "It has been moved to nv_ops_utils.py: {code}pr..." Wed, 05 May 2021 09:37:47 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9742 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9742 plucia  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-DEN-8055-1

It has been moved to nv_ops_utils.py:

prepare_record_to_send_to_fw
]]> DIALIN-DEN-8055-1: comment by plucia "Done" Wed, 05 May 2021 09:32:44 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9741 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9741 plucia  (deleted user) replied to pmontazemi  (deleted user) in DIALIN-DEN-8055-1

Done

]]> DIALIN-DEN-8055-1: comment by plucia "Done" Wed, 05 May 2021 09:32:02 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9740 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9740 plucia  (deleted user) replied to Sean Nash in DIALIN-DEN-8055-1

Done

]]> DIALIN-DEN-8055-1: comment by qnguyen "RESOLVED." Tue, 04 May 2021 10:24:06 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9711 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9711 qnguyen  (deleted user) replied to Sean Nash in DIALIN-DEN-8055-1

RESOLVED.

]]> DIALIN-DEN-8055-1: comment by Sean Nash "These are 1 and 2 byte fields, so cannot use th..." Tue, 04 May 2021 09:20:21 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9710 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9710 Sean Nash replied to qnguyen  (deleted user) in DIALIN-DEN-8055-1

These are 1 and 2 byte fields, so cannot use the generic 4-byte field names.

]]> DIALIN-DEN-8055-1: comment by qnguyen "Recommend converting to use message field posit..." Thu, 29 Apr 2021 14:35:34 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9681 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9681 qnguyen  (deleted user) commented on DIALIN-DEN-8055-1

Recommend converting to use message field positions and remove local defines.

]]> DIALIN-DEN-8055-1: comment by pmontazemi "Remove extra lines." Thu, 29 Apr 2021 09:41:48 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9648 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9648 pmontazemi  (deleted user) commented on DIALIN-DEN-8055-1

Remove extra lines.

]]> DIALIN-DEN-8055-1: comment by pmontazemi ""sent" instead of "send"" Thu, 29 Apr 2021 09:33:16 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9647 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9647 pmontazemi  (deleted user) commented on DIALIN-DEN-8055-1

"sent" instead of "send"

]]> DIALIN-DEN-8055-1: comment by pmontazemi "Where was CRC moved to?" Thu, 29 Apr 2021 09:30:46 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9645 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9645 pmontazemi  (deleted user) commented on DIALIN-DEN-8055-1

Where was CRC moved to?

]]> DIALIN-DEN-8055-1: comment by pmontazemi "Remove extra line." Thu, 29 Apr 2021 09:28:23 -0700 pmontazemi https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9643 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9643 pmontazemi  (deleted user) commented on DIALIN-DEN-8055-1

Remove extra line.

]]> DIALIN-DEN-8055-1: comment by Sean Nash "Remove obsolete definitions at top of class." Thu, 29 Apr 2021 08:49:11 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9641 https://devapps.diality.us/cru/DIALIN-DEN-8055-1/#c9641 Sean Nash commented on DIALIN-DEN-8055-1

Remove obsolete definitions at top of class.

]]> DIALIN-DEN-8055-1: started by plucia Wed, 28 Apr 2021 16:32:15 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-8055-1 https://devapps.diality.us/cru/DIALIN-DEN-8055-1 plucia  (deleted user) started review DIALIN-DEN-8055-1 ]]> DIALIN-DEN-5980-1: closed by Dara Navaei Tue, 06 Apr 2021 12:07:49 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-5980-1 https://devapps.diality.us/cru/DIALIN-DEN-5980-1 Dara Navaei Closed DIALIN-DEN-5980-1 ]]> DIALIN-DEN-5980-1: reviewers finished Tue, 06 Apr 2021 10:29:12 -0700 https://devapps.diality.us/cru/DIALIN-DEN-5980-1 https://devapps.diality.us/cru/DIALIN-DEN-5980-1 plucia  (deleted user) and Sean Nash finished reviewing DIALIN-DEN-5980-1 DIALIN-DEN-5980_Non-volatile Data Management 2 of 2 ]]> DIALIN-DEN-5980-1: comment by plucia "RESOLVED" Thu, 01 Apr 2021 14:58:04 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-5980-1/#c8939 https://devapps.diality.us/cru/DIALIN-DEN-5980-1/#c8939 plucia  (deleted user) replied to Dara Navaei in DIALIN-DEN-5980-1

RESOLVED

]]> DIALIN-DEN-5980-1: comment by plucia "RESOLVED" Thu, 01 Apr 2021 14:56:23 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-5980-1/#c8938 https://devapps.diality.us/cru/DIALIN-DEN-5980-1/#c8938 plucia  (deleted user) replied to Dara Navaei in DIALIN-DEN-5980-1

RESOLVED

]]> DIALIN-DEN-5980-1: comment by plucia "RESOLVED" Thu, 01 Apr 2021 14:56:07 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-5980-1/#c8937 https://devapps.diality.us/cru/DIALIN-DEN-5980-1/#c8937 plucia  (deleted user) replied to Dara Navaei in DIALIN-DEN-5980-1

RESOLVED

]]> DIALIN-DEN-5980-1: comment by Dara Navaei "Done." Thu, 01 Apr 2021 14:52:34 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-5980-1/#c8936 https://devapps.diality.us/cru/DIALIN-DEN-5980-1/#c8936 Dara Navaei replied to plucia  (deleted user) in DIALIN-DEN-5980-1

Done.

]]> DIALIN-DEN-5980-1: comment by Dara Navaei "Done." Thu, 01 Apr 2021 14:52:00 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-5980-1/#c8934 https://devapps.diality.us/cru/DIALIN-DEN-5980-1/#c8934 Dara Navaei replied to plucia  (deleted user) in DIALIN-DEN-5980-1

Done.

]]> DIALIN-DEN-5980-1: comment by plucia "This should be received_msg_length" Thu, 01 Apr 2021 13:16:53 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-5980-1/#c8932 https://devapps.diality.us/cru/DIALIN-DEN-5980-1/#c8932 plucia  (deleted user) commented on DIALIN-DEN-5980-1

This should be received_msg_length

]]>