Fisheye on application/resources/settings/Instructions

UI-DEN-8705-1: reviewers resumed

Thu, 19 Oct 2023 20:26:58 -0700

pmontazemi (deleted user) resumed reviewing UI-DEN-8705-1

UI-DEN-8705_Pre Treatment Setup Screen

UI-DEN-10602-1: closed by Behrouz NematiPour

Behrouz NematiPour — Mon, 03 Jan 2022 12:37:05 -0800

Behrouz NematiPour Closed UI-DEN-10602-1

UI-DEN-10602-1: reviewers finished

Thu, 30 Dec 2021 09:37:13 -0800

Sean Nash finished reviewing UI-DEN-10602-1

UI-DEN-10602_UI DEV Add PatientID PreTreatment

UI-DEN-10602-1: comment by Sean Nash "RESOLVED."

Sean Nash — Thu, 30 Dec 2021 09:36:13 -0800

Sean Nash replied to Behrouz NematiPour in UI-DEN-10602-1

RESOLVED.

UI-DEN-10602-1: reviewers finished

Tue, 21 Dec 2021 14:03:47 -0800

Michael Garthwaite finished reviewing UI-DEN-10602-1

UI-DEN-10602_UI DEV Add PatientID PreTreatment

UI-DEN-10602-1: comment by Michael Garthwaite "RESOLVED"

Michael Garthwaite — Tue, 21 Dec 2021 11:29:32 -0800

Michael Garthwaite replied to Behrouz NematiPour in UI-DEN-10602-1

RESOLVED

UI-DEN-10602-1: comment by Behrouz NematiPour "Fixed. Thanks for your attention to the detail..."

Behrouz NematiPour — Fri, 17 Dec 2021 18:45:14 -0800

Behrouz NematiPour replied to Michael Garthwaite in UI-DEN-10602-1

Fixed.
Thanks for your attention to the details.

application (bugfix/DEN-16597-UI-BN-S114): DEN-10979: Can we move Unhandled.conf file to common folder so that f/w team can make updates...

Behrouz NematiPour — Fri, 17 Dec 2021 17:30:37 -0800

Behrouz NematiPour committed 6e9e702 on branch master, @Environement_Swith and 205 more in application

DEN-10979: Can we move Unhandled.conf file to common folder so that f/w team can make updates

The settings file have all been removed from the applicaion and moved to ui.conf repo.

· /resources/settings

(-0, +1)

| History

| Source

· /resources/settings/Instructions/Dialysate lines to DG Y v4-01.png

(binary)

| History

| Source

| Diff

· /resources/settings/Instructions/HD door open_v1.png

(binary)

| History

| Source

| Diff

· /resources/settings/Instructions/Instructions.conf

(-80, +0)

| History

| Source

| Diff

· /resources/settings/Instructions/PBo connect_72.png

(binary)

| History

| Source

| Diff

· /resources/settings/Instructions/Remove_patient connection temp.png

(binary)

| History

| Source

| Diff

· /resources/settings/Instructions/Twist shunt_temp.png

(binary)

| History

| Source

| Diff

· /resources/settings/Instructions/alt connect fistula_72.png

(binary)

| History

| Source

| Diff

· /resources/settings/Instructions/arterial to saline_v1.png

(binary)

| History

| Source

| Diff

· /resources/settings/Instructions/cassette clamp lock v2-01.png

(binary)

| History

| Source

| Diff

· /resources/settings/Instructions/cassette clamp release v1.png

(binary)

| History

| Source

| Diff

· /resources/settings/Instructions/concentrate door open-v1.png

(binary)

| History

| Source

| Diff

· /resources/settings/Instructions/connect acid line v2-01.png

(binary)

| History

| Source

| Diff

· /resources/settings/Instructions/connect bicarb ine-v2-01.png

(binary)

| History

| Source

| Diff

· /resources/settings/Instructions/door down v2.png

(binary)

| History

| Source

| Diff

… 24 more files in changeset.

UI-DEN-10602-1: comment by Michael Garthwaite "Some functions and variables in this file use P..."

Michael Garthwaite — Fri, 17 Dec 2021 16:00:15 -0800

Michael Garthwaite commented on UI-DEN-10602-1

Some functions and variables in this file use PatientID instead of PtientID, was this spelling intentional?

UI-DEN-10602-1: comment by Behrouz NematiPour "Added"

Behrouz NematiPour — Tue, 14 Dec 2021 10:36:08 -0800

Behrouz NematiPour replied to Sean Nash in UI-DEN-10602-1

Added

UI-DEN-10602-1: comment by Sean Nash "Needs function header?"

Sean Nash — Mon, 13 Dec 2021 16:33:40 -0800

Sean Nash commented on UI-DEN-10602-1

Needs function header?

UI-DEN-10602-1: comment by Behrouz NematiPour "RESOLVED"

Behrouz NematiPour — Mon, 13 Dec 2021 16:15:11 -0800

Behrouz NematiPour replied to Behrouz NematiPour in UI-DEN-10602-1

RESOLVED

UI-DEN-10602-1: comment by Behrouz NematiPour "that is fine because..."

Behrouz NematiPour — Mon, 13 Dec 2021 16:13:41 -0800

Behrouz NematiPour replied to Behrouz NematiPour in UI-DEN-10602-1

that is fine because...

UI-DEN-10602-1: comment by Behrouz NematiPour "it is a test for the code review demo"

Behrouz NematiPour — Mon, 13 Dec 2021 16:12:50 -0800

Behrouz NematiPour commented on UI-DEN-10602-1

it is a test for the code review demo

UI-DEN-10602-1: reviewers added to UI-DEN-10602_UI DEV Add PatientID PreTreatment

Thu, 09 Dec 2021 17:18:19 -0800

Behrouz NematiPour added Dara Navaei and Michael Garthwaite to UI-DEN-10602-1

UI-DEN-10602_UI DEV Add PatientID PreTreatment

UI-DEN-10602-1: reviewers removed from UI-DEN-10602_UI DEV Add PatientID PreTreatment

Thu, 09 Dec 2021 17:18:19 -0800

Behrouz NematiPour removed pmontazemi (deleted user) from UI-DEN-10602-1

UI-DEN-10602_UI DEV Add PatientID PreTreatment

UI-DEN-10602-1: comment by Sean Nash "RESOLVED."

Sean Nash — Mon, 29 Nov 2021 12:26:05 -0800

Sean Nash replied to Behrouz NematiPour in UI-DEN-10602-1

RESOLVED.

UI-DEN-10602-1: comment by Sean Nash "RESOLVED."

Sean Nash — Mon, 29 Nov 2021 12:25:14 -0800

Sean Nash replied to Behrouz NematiPour in UI-DEN-10602-1

RESOLVED.

UI-DEN-10602-1: comment by Sean Nash "RESOLVED."

Sean Nash — Mon, 29 Nov 2021 12:25:08 -0800

Sean Nash replied to Behrouz NematiPour in UI-DEN-10602-1

RESOLVED.

UI-DEN-10602-1: comment by Behrouz NematiPour "The code was old and not up to our standard. I..."

Behrouz NematiPour — Mon, 29 Nov 2021 10:46:22 -0800

Behrouz NematiPour replied to Sean Nash in UI-DEN-10602-1

The code was old and not up to our standard.
It was in the middle of a huge improvement and test.
It has been completely removed from the screen and moved to the component to avoid redundant code copy/paste.

UI-DEN-10602-1: comment by Behrouz NematiPour "The code was old and not up to our standard. I..."

Behrouz NematiPour — Mon, 29 Nov 2021 10:47:33 -0800

Behrouz NematiPour replied to Sean Nash in UI-DEN-10602-1

UI-DEN-10602-1: comment by Behrouz NematiPour "This is a debug code that will be enabled to tr..."

Behrouz NematiPour — Mon, 29 Nov 2021 10:43:52 -0800

Behrouz NematiPour replied to Sean Nash in UI-DEN-10602-1

This is a debug code that will be enabled to trace the screen stack.
if was only a return, changed to an if to make it conditional for later use.

UI-DEN-10602-1: comment by Sean Nash "Why commented out?"

Sean Nash — Mon, 29 Nov 2021 08:47:07 -0800

Sean Nash commented on UI-DEN-10602-1

Why commented out?

UI-DEN-10602-1: comment by Sean Nash "Why commented out?"

Sean Nash — Mon, 29 Nov 2021 08:46:58 -0800

Sean Nash commented on UI-DEN-10602-1

Why commented out?

UI-DEN-10602-1: comment by Sean Nash "Looks like the rest of this function is dead co..."

Sean Nash — Mon, 29 Nov 2021 08:44:40 -0800

Sean Nash commented on UI-DEN-10602-1

Looks like the rest of this function is dead code. Why are we returning here?

UI-DEN-10602-1: started by Behrouz NematiPour

Behrouz NematiPour — Mon, 22 Nov 2021 16:36:08 -0800

Behrouz NematiPour started review UI-DEN-10602-1

UI-DEN-8705-1: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 06 Aug 2021 13:11:14 -0700

Behrouz NematiPour Closed UI-DEN-8705-1

UI-DEN-8705-1: comment by pmontazemi "RESOLVED."

pmontazemi — Fri, 06 Aug 2021 11:17:34 -0700

pmontazemi (deleted user) replied to Behrouz NematiPour in UI-DEN-8705-1

RESOLVED.

UI-DEN-8705-1: comment by pmontazemi "RESOLVED."

pmontazemi — Fri, 06 Aug 2021 11:17:20 -0700

pmontazemi (deleted user) replied to Behrouz NematiPour in UI-DEN-8705-1

RESOLVED.

UI-DEN-8705-1: comment by pmontazemi "RESOLVED."

pmontazemi — Fri, 06 Aug 2021 11:17:08 -0700

pmontazemi (deleted user) replied to Behrouz NematiPour in UI-DEN-8705-1

RESOLVED.