Fisheye on dialin/tests/peter/test_calibration.py https://devapps.diality.us/changelog/~br%3DCalibration_fixes/dialin/tests/peter/test_calibration.py Recent activity in "dialin" under directory /tests/peter/test_calibration.py DIALIN-DEN-8030-1: closed by Dara Navaei Tue, 03 Aug 2021 09:24:44 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-8030-1 https://devapps.diality.us/cru/DIALIN-DEN-8030-1 Dara Navaei Closed DIALIN-DEN-8030-1 ]]> DIALIN-DEN-8030-1: reviewers finished Tue, 03 Aug 2021 09:20:13 -0700 https://devapps.diality.us/cru/DIALIN-DEN-8030-1 https://devapps.diality.us/cru/DIALIN-DEN-8030-1 qnguyen  (deleted user) and Sean Nash finished reviewing DIALIN-DEN-8030-1 DIALIN-DEN-8030_Chemical Disinfect ]]> DIALIN-DEN-8030-1: comment by qnguyen "RESOLVED." Fri, 30 Jul 2021 10:39:56 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-8030-1/#c10554 https://devapps.diality.us/cru/DIALIN-DEN-8030-1/#c10554 qnguyen  (deleted user) replied to Dara Navaei in DIALIN-DEN-8030-1

RESOLVED.

]]> DIALIN-DEN-8030-1: comment by Sean Nash "RESOLVED." Fri, 30 Jul 2021 10:37:43 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-8030-1/#c10550 https://devapps.diality.us/cru/DIALIN-DEN-8030-1/#c10550 Sean Nash replied to Dara Navaei in DIALIN-DEN-8030-1

RESOLVED.

]]> DIALIN-DEN-8030-1: comment by Dara Navaei "Done." Thu, 29 Jul 2021 20:50:54 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-8030-1/#c10537 https://devapps.diality.us/cru/DIALIN-DEN-8030-1/#c10537 Dara Navaei replied to qnguyen  (deleted user) in DIALIN-DEN-8030-1

Done.

]]> DIALIN-DEN-8030-1: comment by Dara Navaei "I added them." Thu, 29 Jul 2021 11:36:39 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-8030-1/#c10487 https://devapps.diality.us/cru/DIALIN-DEN-8030-1/#c10487 Dara Navaei replied to Sean Nash in DIALIN-DEN-8030-1

I added them.

]]> DIALIN-DEN-8030-1: comment by Sean Nash "Where is 0x9D .. 0x9F?" Tue, 27 Jul 2021 15:33:55 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-8030-1/#c10465 https://devapps.diality.us/cru/DIALIN-DEN-8030-1/#c10465 Sean Nash commented on DIALIN-DEN-8030-1

Where is 0x9D .. 0x9F?

]]> DIALIN-DEN-8030-1: comment by qnguyen "These defs should be moved to common/dg_defs.py" Mon, 26 Jul 2021 11:49:23 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-8030-1/#c10449 https://devapps.diality.us/cru/DIALIN-DEN-8030-1/#c10449 qnguyen  (deleted user) commented on DIALIN-DEN-8030-1

These defs should be moved to common/dg_defs.py

]]> DIALIN-DEN-8030-1: started by Dara Navaei Sun, 25 Jul 2021 16:06:12 -0700 Dara Navaei https://devapps.diality.us/cru/DIALIN-DEN-8030-1 https://devapps.diality.us/cru/DIALIN-DEN-8030-1 Dara Navaei started review DIALIN-DEN-8030-1 ]]> DIALIN-DEN-8462-1: closed by plucia Tue, 22 Jun 2021 13:42:04 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-8462-1 https://devapps.diality.us/cru/DIALIN-DEN-8462-1 plucia  (deleted user) Closed DIALIN-DEN-8462-1 ]]> DIALIN-DEN-8462-1: reviewers finished Tue, 22 Jun 2021 13:41:19 -0700 https://devapps.diality.us/cru/DIALIN-DEN-8462-1 https://devapps.diality.us/cru/DIALIN-DEN-8462-1 Sean Nash and qnguyen  (deleted user) finished reviewing DIALIN-DEN-8462-1 DIALIN-DEN-8462_Sprint 45 ]]> DIALIN-DEN-8462-1: comment by qnguyen "RESOLVED." Tue, 22 Jun 2021 13:39:21 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-8462-1/#c10310 https://devapps.diality.us/cru/DIALIN-DEN-8462-1/#c10310 qnguyen  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-8462-1

RESOLVED.

]]> DIALIN-DEN-8462-1: comment by plucia "That's a good idea and I think we should do so...." Tue, 22 Jun 2021 13:25:57 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-8462-1/#c10309 https://devapps.diality.us/cru/DIALIN-DEN-8462-1/#c10309 plucia  (deleted user) replied to qnguyen  (deleted user) in DIALIN-DEN-8462-1

That's a good idea and I think we should do so. Since this code review is quite old I will make that change in my latest branch

]]> DIALIN-DEN-7605-1: closed by Sean Nash Thu, 10 Jun 2021 15:28:27 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-7605-1 https://devapps.diality.us/cru/DIALIN-DEN-7605-1 Sean Nash Closed DIALIN-DEN-7605-1 ]]> DIALIN-DEN-7605-1: reviewers finished Thu, 10 Jun 2021 15:26:22 -0700 https://devapps.diality.us/cru/DIALIN-DEN-7605-1 https://devapps.diality.us/cru/DIALIN-DEN-7605-1 plucia  (deleted user) and pmontazemi  (deleted user) finished reviewing DIALIN-DEN-7605-1 DIALIN-DEN-7605_HD DG Self Tests ]]> DIALIN-DEN-7605-1: comment by plucia "RESOLVED" Thu, 03 Jun 2021 09:54:56 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-7605-1/#c10192 https://devapps.diality.us/cru/DIALIN-DEN-7605-1/#c10192 plucia  (deleted user) replied to Sean Nash in DIALIN-DEN-7605-1

RESOLVED

]]> DIALIN-DEN-7605-1: comment by plucia "RESOLVED" Thu, 03 Jun 2021 09:54:50 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-7605-1/#c10191 https://devapps.diality.us/cru/DIALIN-DEN-7605-1/#c10191 plucia  (deleted user) replied to Sean Nash in DIALIN-DEN-7605-1

RESOLVED

]]> DIALIN-DEN-7605-1: comment by Sean Nash "Fixed." Thu, 03 Jun 2021 09:52:21 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-7605-1/#c10190 https://devapps.diality.us/cru/DIALIN-DEN-7605-1/#c10190 Sean Nash replied to plucia  (deleted user) in DIALIN-DEN-7605-1

Fixed.

]]> DIALIN-DEN-7605-1: comment by Sean Nash "This is Dara's code. Dara will fix in his DIAL..." Thu, 03 Jun 2021 09:32:07 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-7605-1/#c10189 https://devapps.diality.us/cru/DIALIN-DEN-7605-1/#c10189 Sean Nash replied to plucia  (deleted user) in DIALIN-DEN-7605-1

This is Dara's code. Dara will fix in his DIALIN-DEN-8030 branch.

]]> DIALIN-DEN-8462-1: comment by qnguyen "should we create dg_defs file?" Thu, 03 Jun 2021 00:16:18 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-8462-1/#c10184 https://devapps.diality.us/cru/DIALIN-DEN-8462-1/#c10184 qnguyen  (deleted user) commented on DIALIN-DEN-8462-1

should we create dg_defs file?

]]> DIALIN-DEN-8462-1: started by plucia Wed, 02 Jun 2021 13:26:29 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-8462-1 https://devapps.diality.us/cru/DIALIN-DEN-8462-1 plucia  (deleted user) started review DIALIN-DEN-8462-1 ]]> DIALIN-DEN-7605-1: comment by plucia "Is there a problem with crc_16? Or, what needs ..." Tue, 01 Jun 2021 10:49:46 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-7605-1/#c10182 https://devapps.diality.us/cru/DIALIN-DEN-7605-1/#c10182 plucia  (deleted user) commented on DIALIN-DEN-7605-1

Is there a problem with crc_16? Or, what needs to be fixed still?

]]> DIALIN-DEN-7605-1: comment by plucia "In __init__.py you should add from .checks impo..." Tue, 01 Jun 2021 10:47:37 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-7605-1/#c10181 https://devapps.diality.us/cru/DIALIN-DEN-7605-1/#c10181 plucia  (deleted user) commented on DIALIN-DEN-7605-1

In _init_.py you should add from .checks import * so that someone can import the check from utils without having to know which file it is in

]]> dialin (DEN-12358-sw_dev-sprint-67_mg): Merge staging into DEN-8251_Sprint_44 Mon, 24 May 2021 13:22:25 -0700 Peter Lucia <plucia@diality.com> https://devapps.diality.us/changelog/dialin?cs=9d116c25f6482d61d324558b8a1f745468030740 https://devapps.diality.us/changelog/dialin?cs=9d116c25f6482d61d324558b8a1f745468030740 Peter Lucia <plucia@diality.com> committed 9d116c2 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 220 more in dialin Merge staging into DEN-8251_Sprint_44

· /dialin/common/alarm_defs.py (-8, +46) | History | Source | Diff
· /dialin/common/msg_ids.py (-4, +39) | History | Source | Diff
· /dialin/dg/dialysate_generator.py (-1, +2) | History | Source | Diff
· /dialin/dg/fluid_leak.py (-5, +5) | History | Source | Diff
· /dialin/dg/temperature_sensors.py (-1, +33) | History | Source | Diff
· /dialin/dg/uv_reactors.py (-6, +8) | History | Source | Diff
· /dialin/hd/buttons.py (-6, +0) | History | Source | Diff
· /dialin/hd/fluid_leak.py (-6, +6) | History | Source | Diff
· /dialin/hd/hemodialysis_device.py (-0, +2) | History | Source | Diff
· /dialin/hd/ui_proxy.py (-13, +17) | History | Source | Diff
· /dialin/ui/dg_simulator.py (-3, +3) | History | Source | Diff
· /dialin/ui/hd_simulator.py (-9, +282) | History | Source | Diff
· /tests/peter/test_calibration.py (-8, +1) | History | Source | Diff
· /tests/unit_tests/test_imports.py (-1, +1) | History | Source | Diff
· /tests/unit_tests/test_ui_proxy.py (-2, +2) | History | Source | Diff
]]> DIALIN-DEN-8251-1: closed by plucia Mon, 24 May 2021 13:13:39 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-8251-1 https://devapps.diality.us/cru/DIALIN-DEN-8251-1 plucia  (deleted user) Closed DIALIN-DEN-8251-1 ]]> DIALIN-DEN-8251-1: reviewers finished Mon, 24 May 2021 13:11:14 -0700 https://devapps.diality.us/cru/DIALIN-DEN-8251-1 https://devapps.diality.us/cru/DIALIN-DEN-8251-1 Sean Nash finished reviewing DIALIN-DEN-8251-1 DIALIN-DEN-8251_Sprint 44 ]]> DIALIN-DEN-8251-1: reviewers finished Fri, 21 May 2021 16:38:43 -0700 https://devapps.diality.us/cru/DIALIN-DEN-8251-1 https://devapps.diality.us/cru/DIALIN-DEN-8251-1 qnguyen  (deleted user) and pmontazemi  (deleted user) finished reviewing DIALIN-DEN-8251-1 DIALIN-DEN-8251_Sprint 44 ]]> DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED." Fri, 21 May 2021 16:37:31 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-8251-1/#c10019 https://devapps.diality.us/cru/DIALIN-DEN-8251-1/#c10019 qnguyen  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

]]> DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED." Fri, 21 May 2021 16:37:19 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-8251-1/#c10018 https://devapps.diality.us/cru/DIALIN-DEN-8251-1/#c10018 qnguyen  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

]]> DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED." Fri, 21 May 2021 16:36:40 -0700 qnguyen https://devapps.diality.us/cru/DIALIN-DEN-8251-1/#c10017 https://devapps.diality.us/cru/DIALIN-DEN-8251-1/#c10017 qnguyen  (deleted user) replied to plucia  (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

]]>