Fisheye on dgfirmware/firmware/App/Tasks/TaskTimer.c

DG-DEN-4217-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:28:36 -0700

Dara Navaei Closed DG-DEN-4217-1

DG-DEN-4217-1: reviewers finished

Thu, 19 Oct 2023 08:28:27 -0700

Dara Navaei , qnguyen (deleted user) and pmontazemi (deleted user) finished reviewing DG-DEN-4217-1

DG-DEN-4217_Level and Shock Detection

DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:28:18 -0700

Dara Navaei replied to pmontazemi (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-4217-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:27:53 -0700

Dara Navaei replied to pmontazemi (deleted user) in DG-DEN-4217-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-4217-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:26:45 -0700

Dara Navaei started review DG-DEN-4217-1

DG-UCOMMITS-37: closed by Sean Nash

Sean Nash — Thu, 03 Aug 2023 13:21:06 -0700

Sean Nash Closed DG-UCOMMITS-37

DG-UCOMMITS-37: reviewers finished

Thu, 03 Aug 2023 10:09:19 -0700

Dara Navaei finished reviewing DG-UCOMMITS-37

DG Staging Unreviewed Commits

DG-UCOMMITS-37: reviewers finished

Wed, 02 Aug 2023 16:01:41 -0700

Sean Nash finished reviewing DG-UCOMMITS-37

DG Staging Unreviewed Commits

DG-UCOMMITS-37: started by Dara Navaei

Dara Navaei — Mon, 08 May 2023 09:44:32 -0700

Dara Navaei started review DG-UCOMMITS-37

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 05 Jan 2022 20:16:06 -0800

Dara Navaei committed 025612a on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 204 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DialysateFlow.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/DialysateFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-2, +2)

| History

| Source

| Diff

… 80 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 11 Nov 2021 10:57:02 -0800

Dara Navaei committed 94a1905 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-6, +6)

| History

| Source

| Diff

… 78 more files in changeset.

DG-DEN-3504-1: closed by qnguyen

qnguyen — Mon, 23 Nov 2020 13:19:09 -0800

qnguyen (deleted user) Closed DG-DEN-3504-1

DG-DEN-3504-1: reviewers finished

Mon, 23 Nov 2020 13:18:28 -0800

pmontazemi (deleted user) , Dara Navaei and Sean Nash finished reviewing DG-DEN-3504-1

DG-DEN-3504_DG Dialysate Composition (1 of 2)

DG-DEN-3504-1: comment by pmontazemi "RESOLVED in CODE WALKTHROUGH."

pmontazemi — Mon, 23 Nov 2020 10:34:40 -0800

pmontazemi (deleted user) replied to qnguyen (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1: comment by qnguyen "Good catch, it is actually an unintended L. Rem..."

qnguyen — Tue, 17 Nov 2020 10:39:42 -0800

qnguyen (deleted user) replied to pmontazemi (deleted user) in DG-DEN-3504-1

Good catch, it is actually an unintended L. Removed.

DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 17 Nov 2020 10:37:27 -0800

Sean Nash replied to qnguyen (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1: comment by qnguyen "Pumps are now controlled individually. Reverse ..."

qnguyen — Tue, 17 Nov 2020 10:36:33 -0800

qnguyen (deleted user) replied to Sean Nash in DG-DEN-3504-1

Pumps are now controlled individually. Reverse direction for motor has been added.

DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 17 Nov 2020 10:34:35 -0800

Sean Nash replied to qnguyen (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 17 Nov 2020 10:34:21 -0800

Sean Nash replied to qnguyen (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1: comment by pmontazemi "Not a big fan of numbering variables like Speed..."

pmontazemi — Tue, 17 Nov 2020 10:33:35 -0800

pmontazemi (deleted user) commented on DG-DEN-3504-1

Not a big fan of numbering variables like Speed1, Speed2, etc.

DG-DEN-3504-1: comment by Sean Nash "There may be a need to run these pumps in forwa..."

Sean Nash — Mon, 16 Nov 2020 08:20:00 -0800

Sean Nash commented on DG-DEN-3504-1

There may be a need to run these pumps in forward or reverse direction (heat disinfect mode). And this would not be tied to RO flow rate - we would want to set an independent flow. May also want to control the pumps independently in this mode.

DG-DEN-3504-1: comment by qnguyen "This was responsible for turn off concentrate p..."

qnguyen — Fri, 13 Nov 2020 10:48:34 -0800

qnguyen (deleted user) replied to Sean Nash in DG-DEN-3504-1

This was responsible for turn off concentrate pumps when HD commands DG to exit out of fill mode, but reservoir module has handled this.

DG-DEN-3504-1: comment by qnguyen "It was acting as a function to turn off concent..."

qnguyen — Fri, 13 Nov 2020 10:46:33 -0800

qnguyen (deleted user) replied to Sean Nash in DG-DEN-3504-1

It was acting as a function to turn off concentrate pump if HD commands DG exits fill mode, but has been removed due to reservoir module will handle this.

DG-DEN-3504-1: comment by Sean Nash "We should think about this. I'm ok with adding..."

Sean Nash — Fri, 13 Nov 2020 09:40:12 -0800

Sean Nash commented on DG-DEN-3504-1

We should think about this. I'm ok with adding an explicit transition out handler (similar to the existing transition to handler), but if we do this we should build this into all modes (DG and HD).
To date, I've not required any clean-up on way out of a mode - mode can be reset on next entry. That seems to have been working so far.
Valve positions and motor states should be set as appropriate on entry to next mode, so we shouldn't have to worry about these kind of things on way out of a mode.

DG-DEN-3504-1: comment by Sean Nash "I don't see this function actually exiting the ..."

Sean Nash — Fri, 13 Nov 2020 09:37:52 -0800

Sean Nash commented on DG-DEN-3504-1

I don't see this function actually exiting the mode. Is it caller's responsibility to return to re-circ mode after calling this function?

DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 12 Nov 2020 10:51:51 -0800

Sean Nash replied to qnguyen (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 12 Nov 2020 10:51:40 -0800

Sean Nash replied to qnguyen (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 12 Nov 2020 10:51:12 -0800

Sean Nash replied to qnguyen (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 12 Nov 2020 10:50:58 -0800

Sean Nash replied to qnguyen (deleted user) in DG-DEN-3504-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1: comment by qnguyen "Changed variable name and added units in commen..."

qnguyen — Thu, 12 Nov 2020 10:50:47 -0800

qnguyen (deleted user) replied to Sean Nash in DG-DEN-3504-1

Changed variable name and added units in comment.