Fisheye on dgfirmware/firmware/App

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 addressed the code review comments

Dara Navaei — Thu, 03 Mar 2022 13:39:35 -0800

Dara Navaei committed 0d7e626 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 addressed the code review comments

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-0, +1)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 addressed the code review comments

Dara Navaei — Wed, 02 Mar 2022 15:03:59 -0800

Dara Navaei committed 23a9049 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 addressed the code review comments

· /firmware/App/Controllers/Fans.c

(-6, +7)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 addressed the code review comments

Dara Navaei — Wed, 02 Mar 2022 14:27:01 -0800

Dara Navaei committed 954b755 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 addressed the code review comments

· /firmware/App/Controllers/TemperatureSensors.c

(-10, +10)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 addressed the code review comments

Dara Navaei — Wed, 02 Mar 2022 13:29:25 -0800

Dara Navaei committed d7e6955 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 addressed the code review comments

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/UVReactors.c	(-15, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-7, +10)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 added a build switch for heat disinfect

Dara Navaei — Wed, 02 Mar 2022 09:01:31 -0800

Dara Navaei committed 97eb7ff on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 added a build switch for heat disinfect

· /firmware/App/DGCommon.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-6, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-0, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 updated the comments

Dara Navaei — Mon, 28 Feb 2022 13:07:49 -0800

Dara Navaei committed 8d6dcaa on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 updated the comments

· /firmware/App/Modes/ModeFlush.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-12232 fixed the fans monitor

Dara Navaei — Sat, 26 Feb 2022 13:59:54 -0800

Dara Navaei committed 24a3d75 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-12232 fixed the fans monitor

· /firmware/App/Controllers/Fans.c

(-5, +17)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 addressed the code review comments

Dara Navaei — Fri, 25 Feb 2022 18:34:22 -0800

Dara Navaei committed 321e360 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 addressed the code review comments

· /firmware/App/Controllers/Fans.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-7, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-6, +10)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-6, +0)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 updated the drain exit algorithm

Dara Navaei — Fri, 25 Feb 2022 17:37:54 -0800

Dara Navaei committed 4d1a8ff on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 updated the drain exit algorithm

· /firmware/App/Modes/ModeDrain.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-34, +10)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750, DEN-12221 updated the drain exit algorithm

Dara Navaei — Fri, 25 Feb 2022 14:44:26 -0800

Dara Navaei committed 5f538f7 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750, DEN-12221 updated the drain exit algorithm

· /firmware/App/Modes/ModeDrain.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-13, +57)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-0, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 updated the concentrate pumps

Dara Navaei — Thu, 24 Feb 2022 11:28:12 -0800

Dara Navaei committed 550a5df on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 updated the concentrate pumps

· /firmware/App/Controllers/ConcentratePumps.c	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-12225, DEN-12221 added code to update the UV reactors health and to calculate the target flow change based on the ta...

Dara Navaei — Wed, 23 Feb 2022 20:19:47 -0800

Dara Navaei committed 92708a5 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-12225, DEN-12221 added code to update the UV reactors health and to calculate the target flow change based on the target drain pump RPM

· /firmware/App/Controllers/UVReactors.c	(-3, +12)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-5, +6)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-12225 updated the UV reactors

Dara Navaei — Wed, 23 Feb 2022 12:47:27 -0800

Dara Navaei committed 3b91172 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-12225 updated the UV reactors

· /firmware/App/Controllers/UVReactors.c

(-1, +2)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 updated the code

Dara Navaei — Wed, 23 Feb 2022 10:39:26 -0800

Dara Navaei committed 4b20864 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 updated the code

· /firmware/App/Controllers/Fans.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-7, +11)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' of ssh://dvm-linux02:7999/dg/dgfirmware into DE...

Sean Nash — Tue, 22 Feb 2022 17:02:50 -0800

Sean Nash committed 652b062 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up

· /firmware/App/Controllers/ConcentratePumps.c

(-0, +2)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750: Fixed casting error in ConcentratePumps.c.

Sean Nash — Tue, 22 Feb 2022 17:02:48 -0800

Sean Nash committed 7d200a6 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750: Fixed casting error in ConcentratePumps.c.

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 addressed the bugs that Code Clinic reported

Dara Navaei — Tue, 22 Feb 2022 15:48:19 -0800

Dara Navaei committed 02654dc on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 addressed the bugs that Code Clinic reported

· /firmware/App/Controllers/Fans.c	(-5, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Fans.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Switches.c	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-4, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 added more comments

Dara Navaei — Tue, 22 Feb 2022 12:57:58 -0800

Dara Navaei committed 250f7f3 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 added more comments

· /firmware/App/Controllers/ROPump.c

(-15, +8)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 worked on the RO pump duty cycle feedback

Dara Navaei — Tue, 22 Feb 2022 10:59:29 -0800

Dara Navaei committed 609d5c7 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 worked on the RO pump duty cycle feedback

· /firmware/App/Controllers/ConcentratePumps.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-105, +10)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-13, +9)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/InternalADC.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEM-11750 updated the code

Dara Navaei — Sun, 20 Feb 2022 17:37:08 -0800

Dara Navaei committed 71df422 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEM-11750 updated the code

· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750: Fixed drain pump RPM out of range alarm.

Sean Nash — Mon, 14 Feb 2022 11:07:50 -0800

Sean Nash committed 5403fbf on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750: Fixed drain pump RPM out of range alarm.

· /firmware/App/Controllers/DrainPump.c

(-4, +6)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 updated the drain pump

Dara Navaei — Mon, 14 Feb 2022 10:17:51 -0800

Dara Navaei committed 803e7a8 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 updated the drain pump

· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/DGCommon.h	(-26, +26)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Updated code to store the raw conductivity data from sensors CD1 and CD2

Wed, 09 Feb 2022 17:32:53 -0800

Hung Nguyen committed cc182c9 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

Updated code to store the raw conductivity data from sensors CD1 and CD2

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +4)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 updated the drain pump RPM to make sure the pump's RPM is only checked if the pumpis running

Dara Navaei — Wed, 09 Feb 2022 15:56:06 -0800

Dara Navaei committed a3ee6d4 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 updated the drain pump RPM to make sure the pump's RPM is only checked if the pumpis running

· /firmware/App/Controllers/DrainPump.c

(-13, +13)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11250 Updated conductivity sensors manufacture information

Wed, 09 Feb 2022 13:04:32 -0800

Hung Nguyen committed 19ad047 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11250 Updated conductivity sensors manufacture information

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +15)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 Fixed temperature compensated conductivity error and added code to publish raw conductivity data. Updated FW ...

Wed, 09 Feb 2022 12:29:10 -0800

Hung Nguyen committed 1d6a00e on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 Fixed temperature compensated conductivity error and added code to publish raw conductivity data. Updated FW code per peer review comments

· /firmware/App/Controllers/ConductivitySensors.c

(-90, +9)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 enabled the load cells tare alarm

Dara Navaei — Tue, 08 Feb 2022 21:02:45 -0800

Dara Navaei committed 9c3d402 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 enabled the load cells tare alarm

· /firmware/App/Controllers/LoadCell.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' of ssh://dvm-linux02:7999/dg/dgfirmware into DE...

Sean Nash — Tue, 08 Feb 2022 18:10:40 -0800

Sean Nash committed d756f33 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up

· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-10, +41)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750: Renamed msg ack ID for consistency with HD code.

Sean Nash — Tue, 08 Feb 2022 18:10:36 -0800

Sean Nash committed db5eeea on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750: Renamed msg ack ID for consistency with HD code.

· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.h	(-8, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): DEN-11750 Fixed temperature compensated conductivity error and added code to publish raw conductivity data

Tue, 08 Feb 2022 17:31:57 -0800

Hung Nguyen committed 60e0810 on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 203 more in dgfirmware

DEN-11750 Fixed temperature compensated conductivity error and added code to publish raw conductivity data

· /firmware/App/Controllers/ConductivitySensors.c	(-1, +91)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConductivitySensors.h	(-0, +8)	\| History	\| Source	\| Diff