Fisheye on dialin/docs/source/dialin.ui.rst https://devapps.diality.us/changelog/~br%3DDEN-12534-code-update/dialin/docs/source/dialin.ui.rst Recent activity in "dialin" under directory /docs/source/dialin.ui.rst DIALIN-DEN-4344-1: closed by plucia Wed, 26 Aug 2020 12:02:54 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1 https://devapps.diality.us/cru/DIALIN-DEN-4344-1 plucia  (deleted user) Closed DIALIN-DEN-4344-1 ]]> DIALIN-DEN-4344-1: reviewers finished Wed, 26 Aug 2020 12:01:57 -0700 https://devapps.diality.us/cru/DIALIN-DEN-4344-1 https://devapps.diality.us/cru/DIALIN-DEN-4344-1 Sean Nash and Behrouz NematiPour finished reviewing DIALIN-DEN-4344-1 DIALIN-DEN-4344_Sprint 25 ]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "RESOLVED." Wed, 26 Aug 2020 11:52:21 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c4001 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c4001 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-DEN-4344-1

RESOLVED.

]]> DIALIN-DEN-4344-1: comment by plucia "Okay. It's "Projects" now" Wed, 26 Aug 2020 11:49:12 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c4000 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c4000 plucia  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4344-1

Okay. It's "Projects" now

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "Reminded him again and he is aware of it and ha..." Wed, 26 Aug 2020 11:46:40 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3999 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3999 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-DEN-4344-1

Reminded him again and he is aware of it and has plan to do so.
We use "Projects" and if meanwhile anyone has a non-updated VM will update the folder name manually for now.

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "Yes I told him to update that. Will remind him..." Wed, 26 Aug 2020 11:29:20 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3994 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3994 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-DEN-4344-1

Yes I told him to update that.
Will remind him again.

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "Great, RESOLVED" Wed, 26 Aug 2020 11:28:28 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3993 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3993 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-DEN-4344-1

Great,
RESOLVED

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "great, RESOLVED" Wed, 26 Aug 2020 11:28:16 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3992 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3992 Behrouz NematiPour replied to plucia  (deleted user) in DIALIN-DEN-4344-1

great,
RESOLVED

]]> DIALIN-DEN-4344-1: comment by plucia "Have you checked with Dara on this? I think the..." Wed, 26 Aug 2020 10:43:59 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3960 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3960 plucia  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4344-1

Have you checked with Dara on this? I think the VM's are setup with the "~/projects" directory. Systems and V&V both have v4 of those VM's already...

]]> DIALIN-DEN-4344-1: comment by plucia "I had the same thought awhile ago and begin inv..." Wed, 26 Aug 2020 10:41:21 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3958 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3958 plucia  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4344-1

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: http://dvm-linux02:8080/browse/DIAL-23.

]]> DIALIN-DEN-4344-1: comment by plucia "I had the same thought awhile ago and begin inv..." Wed, 26 Aug 2020 10:36:29 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3955 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3955 plucia  (deleted user) replied to Behrouz NematiPour in DIALIN-DEN-4344-1

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: http://dvm-linux02:8080/browse/DIAL-23.

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "Is there a way to get these values right from c..." Wed, 26 Aug 2020 10:33:27 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3948 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3948 Behrouz NematiPour commented on DIALIN-DEN-4344-1

Is there a way to get these values right from c code of firmware?
Like a scripts which reads the c file and generates this py code.

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "Is there a way to get these values right from c..." Wed, 26 Aug 2020 10:32:33 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3946 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3946 Behrouz NematiPour commented on DIALIN-DEN-4344-1

Is there a way to get these values right from c code of firmware?
Like a scripts which reads the c file and generates this py code.

]]> DIALIN-DEN-4344-1: comment by Behrouz NematiPour "It has been updated in scripts to "Projects"" Wed, 26 Aug 2020 10:25:43 -0700 Behrouz NematiPour https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3945 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3945 Behrouz NematiPour commented on DIALIN-DEN-4344-1

It has been updated in scripts to "Projects"

]]> DIALIN-DEN-4344-1: comment by Sean Nash "RESOLVED" Tue, 25 Aug 2020 11:09:46 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3882 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3882 Sean Nash replied to plucia  (deleted user) in DIALIN-DEN-4344-1

RESOLVED

]]> DIALIN-DEN-4344-1: comment by plucia "It is so during the import process, the modules..." Fri, 21 Aug 2020 11:39:00 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3737 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3737 plucia  (deleted user) replied to Sean Nash in DIALIN-DEN-4344-1

It is so during the import process, the modules in the common directory are found. It's used to mark directories as python package directories.
If you remove it, then python will no longer find submodules.

https://docs.python.org/3/reference/import.html#regular-packages

If we add the following to _init.py then the user doesn't have to know the exact file location of a particular class:

So in dialin.init_.py, we could add:
from hd.hemodialysis_device.py import HD

Then, a dialin script could do:

from dialin import HD

instead of

from dialin.hd.hemodialysis_device import HD


It abstracts away the file location so if we can rename files without the API user being affected.

Your comment reminded me that we weren't doing this yet and so I've added those changes to this review.

]]> DIALIN-DEN-4344-1: comment by Sean Nash "Why is this empty?" Fri, 21 Aug 2020 10:45:31 -0700 Sean Nash https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3735 https://devapps.diality.us/cru/DIALIN-DEN-4344-1/#c3735 Sean Nash commented on DIALIN-DEN-4344-1

Why is this empty?

]]> DIALIN-DEN-4344-1: started by plucia Fri, 21 Aug 2020 10:14:08 -0700 plucia https://devapps.diality.us/cru/DIALIN-DEN-4344-1 https://devapps.diality.us/cru/DIALIN-DEN-4344-1 plucia  (deleted user) started review DIALIN-DEN-4344-1 ]]> dialin (DEN-12358-sw_dev-sprint-67_mg): In progress update Thu, 06 Aug 2020 10:57:20 -0700 Peter Lucia <plucia@diality.com> https://devapps.diality.us/changelog/dialin?cs=a08848ed6275cf2afa3bfb7f3c87709b69c224bc https://devapps.diality.us/changelog/dialin?cs=a08848ed6275cf2afa3bfb7f3c87709b69c224bc Peter Lucia <plucia@diality.com> committed a08848e on branch 2020_EOY_DEMO, Calibration_fixes and 276 more in dialin In progress update

· /dialin/dg/hd_proxy.py (-1, +1) | History | Source | Diff
· /dialin/hd/buttons.py (-1, +28) | History | Source | Diff
· /dialin/hd/hemodialysis_device.py (-0, +1) | History | Source | Diff
· /dialin/hd/ui_proxy.py (-1, +1) | History | Source | Diff
· /dialin/ui/__init__.py (-0, +0) | History | Source
· /dialin/ui/dg_simulator.py (-0, +0) | History | Source
· /dialin/ui/hd_simulator.py (-0, +244) | History | Source
· /docs/source/dialin.ui.rst (-0, +22) | History | Source
· /tests/test_buttons.py (-0, +32) | History | Source
· /tests/test_gen_requirements.py (-6, +9) | History | Source | Diff
· /tests/test_hd_simulator.py (-0, +69) | History | Source
· /tools/document.sh (-2, +7) | History | Source | Diff
]]>