Fisheye on application/qtquickcontrols2.conf https://devapps.diality.us/changelog/~br%3DDEN-13226_UI_Unit_Testing/application/qtquickcontrols2.conf Recent activity in "application" under directory /qtquickcontrols2.conf UI-UCOMMITS-3: closed by Sean Nash Thu, 03 Aug 2023 14:23:52 -0700 Sean Nash https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Sean Nash Closed UI-UCOMMITS-3 ]]> UI-UCOMMITS-3: reviewers finished Thu, 03 Aug 2023 14:05:13 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Dara Navaei finished reviewing UI-UCOMMITS-3 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-3: reviewers finished Wed, 02 Aug 2023 09:33:38 -0700 https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Sean Nash finished reviewing UI-UCOMMITS-3 UI Staging Unreviewed Commits ]]> UI-UCOMMITS-3: started by Dara Navaei Mon, 08 May 2023 08:49:03 -0700 Dara Navaei https://devapps.diality.us/cru/UI-UCOMMITS-3 https://devapps.diality.us/cru/UI-UCOMMITS-3 Dara Navaei started review UI-UCOMMITS-3 ]]> UI-DEN-626-1: closed by Dara Navaei Sat, 07 Dec 2019 11:49:30 -0800 Dara Navaei https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Dara Navaei Closed UI-DEN-626-1 ]]> UI-DEN-626-1: reviewers finished Sat, 07 Dec 2019 11:37:35 -0800 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Dara Navaei finished reviewing UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> UI-DEN-626-1: reviewers finished Thu, 05 Dec 2019 10:02:56 -0800 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 pmontazemi  (deleted user) finished reviewing UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> UI-DEN-626-1: reviewers finished Wed, 04 Dec 2019 08:52:51 -0800 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 lbaloa  (deleted user) finished reviewing UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> UI-DEN-626-1: comment by lbaloa "RESOLVED" Wed, 04 Dec 2019 08:51:51 -0800 lbaloa https://devapps.diality.us/cru/UI-DEN-626-1/#c450 https://devapps.diality.us/cru/UI-DEN-626-1/#c450 lbaloa  (deleted user) replied to lbaloa  (deleted user) in UI-DEN-626-1

RESOLVED

]]> UI-DEN-626-1: comment by pmontazemi "Leo, Resolving the case in not enough, you a..." Fri, 01 Nov 2019 15:34:17 -0700 pmontazemi https://devapps.diality.us/cru/UI-DEN-626-1/#c187 https://devapps.diality.us/cru/UI-DEN-626-1/#c187 pmontazemi  (deleted user) replied to lbaloa  (deleted user) in UI-DEN-626-1

Leo,

Resolving the case in not enough, you also need to reply to Behrouz's last comment and mention the word "RESOLVED", otherwise, Dara's Crucible script won't pick this code review up. We will review this next week during the training.

]]> UI-DEN-626-1: comment by Behrouz NematiPour "seems like when I replied the emails were not w..." Mon, 28 Oct 2019 17:47:58 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-626-1/#c169 https://devapps.diality.us/cru/UI-DEN-626-1/#c169 Behrouz NematiPour replied to lbaloa  (deleted user) in UI-DEN-626-1

seems like when I replied the emails were not working
Just as a reminder.

]]> UI-DEN-626-1: reviewers joined UI-DEN-626_UI Power Off Screen Mon, 28 Oct 2019 16:30:23 -0700 https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Dara Navaei joined UI-DEN-626-1 UI-DEN-626_UI Power Off Screen ]]> UI-DEN-626-1: comment by Behrouz NematiPour "Thanks for the comment. static class member ..." Thu, 24 Oct 2019 10:46:41 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-626-1/#c124 https://devapps.diality.us/cru/UI-DEN-626-1/#c124 Behrouz NematiPour replied to lbaloa  (deleted user) in UI-DEN-626-1

Thanks for the comment.

static class member variable can not be initialized in header.
Please take a look at the applicationcontroller.cpp@21.
It has been initialized with nullptr.

Note : To see the whole file content on the top right click on the "View" menu and select "Full Context"

]]> UI-DEN-626-1: comment by lbaloa "initialize with nullptr for consistency" Thu, 24 Oct 2019 09:14:52 -0700 lbaloa https://devapps.diality.us/cru/UI-DEN-626-1/#c123 https://devapps.diality.us/cru/UI-DEN-626-1/#c123 lbaloa  (deleted user) commented on UI-DEN-626-1

initialize with nullptr for consistency

]]> UI-DEN-626-1: started by Behrouz NematiPour Tue, 22 Oct 2019 18:21:54 -0700 Behrouz NematiPour https://devapps.diality.us/cru/UI-DEN-626-1 https://devapps.diality.us/cru/UI-DEN-626-1 Behrouz NematiPour started review UI-DEN-626-1 ]]>