Fisheye on fwcommon/TestSupport.c https://devapps.diality.us/changelog/~br%3DDEN-13786-hd_dg_dev-s78_bb/fwcommon/TestSupport.c Recent activity in "fwcommon" under directory /TestSupport.c DG-UCOMMITS-42: closed by Sean Nash Fri, 20 Oct 2023 09:37:05 -0700 Sean Nash https://devapps.diality.us/cru/DG-UCOMMITS-42 https://devapps.diality.us/cru/DG-UCOMMITS-42 Sean Nash Closed DG-UCOMMITS-42 ]]> DG-UCOMMITS-42: reviewers finished Fri, 20 Oct 2023 09:36:47 -0700 https://devapps.diality.us/cru/DG-UCOMMITS-42 https://devapps.diality.us/cru/DG-UCOMMITS-42 Sean Nash finished reviewing DG-UCOMMITS-42 DG Staging Unreviewed Commits ]]> DG-UCOMMITS-42: started by Dara Navaei Fri, 20 Oct 2023 08:31:47 -0700 Dara Navaei https://devapps.diality.us/cru/DG-UCOMMITS-42 https://devapps.diality.us/cru/DG-UCOMMITS-42 Dara Navaei started review DG-UCOMMITS-42 ]]> DG-DENBUG-112-1: closed by Dara Navaei Fri, 20 Oct 2023 08:27:20 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-112-1 https://devapps.diality.us/cru/DG-DENBUG-112-1 Dara Navaei Closed DG-DENBUG-112-1 ]]> DG-DENBUG-112-1: reviewers finished Fri, 20 Oct 2023 08:14:45 -0700 https://devapps.diality.us/cru/DG-DENBUG-112-1 https://devapps.diality.us/cru/DG-DENBUG-112-1 Sean Nash finished reviewing DG-DENBUG-112-1 DG-DENBUG-112_Alarm 181 Trigger During Heat Disinfect Dvt ]]> DG-DENBUG-112-1: reviewers resumed Thu, 19 Oct 2023 11:13:16 -0700 https://devapps.diality.us/cru/DG-DENBUG-112-1 https://devapps.diality.us/cru/DG-DENBUG-112-1 jtaylor  (deleted user) resumed reviewing DG-DENBUG-112-1 DG-DENBUG-112_Alarm 181 Trigger During Heat Disinfect Dvt ]]> HD-DEN-11250-1: closed by Dara Navaei Thu, 19 Oct 2023 07:55:43 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11250-1 https://devapps.diality.us/cru/HD-DEN-11250-1 Dara Navaei Closed HD-DEN-11250-1 ]]> HD-DEN-11250-1: reviewers finished Thu, 19 Oct 2023 07:55:37 -0700 https://devapps.diality.us/cru/HD-DEN-11250-1 https://devapps.diality.us/cru/HD-DEN-11250-1 Dara Navaei finished reviewing HD-DEN-11250-1 HD-DEN-11250_HD Syringe Pump Updates ]]> HD-DEN-11250-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 07:55:24 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11250-1/#c19088 https://devapps.diality.us/cru/HD-DEN-11250-1/#c19088 Dara Navaei replied to Sean Nash in HD-DEN-11250-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-11250-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:39:56 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11250-1/#c19087 https://devapps.diality.us/cru/HD-DEN-11250-1/#c19087 Dara Navaei replied to Sean Nash in HD-DEN-11250-1

RESOLVED in CODE WALKTHROUGH

]]> HD-DEN-11250-1: reviewers resumed Wed, 18 Oct 2023 21:34:50 -0700 https://devapps.diality.us/cru/HD-DEN-11250-1 https://devapps.diality.us/cru/HD-DEN-11250-1 Sean Nash resumed reviewing HD-DEN-11250-1 HD-DEN-11250_HD Syringe Pump Updates ]]> HD-DEN-11250-1: started by Dara Navaei Wed, 18 Oct 2023 21:34:49 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11250-1 https://devapps.diality.us/cru/HD-DEN-11250-1 Dara Navaei started review HD-DEN-11250-1 ]]> DG-DENBUG-112-1: reviewers resumed Wed, 18 Oct 2023 08:50:44 -0700 https://devapps.diality.us/cru/DG-DENBUG-112-1 https://devapps.diality.us/cru/DG-DENBUG-112-1 wbracken  (deleted user) resumed reviewing DG-DENBUG-112-1 DG-DENBUG-112_Alarm 181 Trigger During Heat Disinfect Dvt ]]> DG-DENBUG-112-1: started by Dara Navaei Tue, 17 Oct 2023 14:05:42 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DENBUG-112-1 https://devapps.diality.us/cru/DG-DENBUG-112-1 Dara Navaei started review DG-DENBUG-112-1 ]]> DG-DEN-16487-1: closed by Dara Navaei Tue, 10 Oct 2023 15:59:29 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16487-1 https://devapps.diality.us/cru/DG-DEN-16487-1 Dara Navaei Closed DG-DEN-16487-1 ]]> DG-DEN-16487-1: reviewers finished Tue, 10 Oct 2023 14:53:00 -0700 https://devapps.diality.us/cru/DG-DEN-16487-1 https://devapps.diality.us/cru/DG-DEN-16487-1 wbracken  (deleted user) , Sean Nash and jtaylor  (deleted user) finished reviewing DG-DEN-16487-1 DG-DEN-16487_Dialin Config Helper Commands Are Not Supported With The Latest HD And DG Builds ]]> DG-DEN-16487-1: started by Dara Navaei Tue, 10 Oct 2023 09:04:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16487-1 https://devapps.diality.us/cru/DG-DEN-16487-1 Dara Navaei started review DG-DEN-16487-1 ]]> DG-DEN-16446-1: closed by Dara Navaei Mon, 09 Oct 2023 11:10:29 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16446-1 https://devapps.diality.us/cru/DG-DEN-16446-1 Dara Navaei Closed DG-DEN-16446-1 ]]> DG-DEN-16446-1: reviewers finished Mon, 09 Oct 2023 11:07:03 -0700 https://devapps.diality.us/cru/DG-DEN-16446-1 https://devapps.diality.us/cru/DG-DEN-16446-1 wbracken  (deleted user) , Sean Nash and jtaylor  (deleted user) finished reviewing DG-DEN-16446-1 DG-DEN-16446_DG Dev Test Clean UP ]]> DG-DEN-16446-1: comment by wbracken "RESOLVED IN CODE WALKTHROUGH" Mon, 09 Oct 2023 11:06:58 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-16446-1/#c19015 https://devapps.diality.us/cru/DG-DEN-16446-1/#c19015 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-16446-1

RESOLVED IN CODE WALKTHROUGH

]]> DG-DEN-16446-1: comment by Dara Navaei "Done" Mon, 09 Oct 2023 09:20:50 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16446-1/#c19014 https://devapps.diality.us/cru/DG-DEN-16446-1/#c19014 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-16446-1

Done

]]> DG-DEN-16446-1: comment by wbracken "sizeof should be first in if" Sun, 08 Oct 2023 17:54:57 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-16446-1/#c19008 https://devapps.diality.us/cru/DG-DEN-16446-1/#c19008 wbracken  (deleted user) commented on DG-DEN-16446-1

sizeof should be first in if

]]> DG-DEN-16446-1: comment by wbracken "Should this have a set of parenthesis around th..." Mon, 02 Oct 2023 00:38:20 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-16446-1/#c18986 https://devapps.diality.us/cru/DG-DEN-16446-1/#c18986 wbracken  (deleted user) commented on DG-DEN-16446-1

Should this have a set of parenthesis around the condition similar to line 437?

]]> DG-DEN-16446-1: comment by wbracken "Resolved in code review." Fri, 06 Oct 2023 10:18:39 -0700 wbracken https://devapps.diality.us/cru/DG-DEN-16446-1/#c19007 https://devapps.diality.us/cru/DG-DEN-16446-1/#c19007 wbracken  (deleted user) replied to Dara Navaei in DG-DEN-16446-1

Resolved in code review.

]]> DG-DEN-16446-1: comment by Dara Navaei "In the condition in line 437 we do a subtractio..." Tue, 03 Oct 2023 14:33:17 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16446-1/#c18995 https://devapps.diality.us/cru/DG-DEN-16446-1/#c18995 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-16446-1

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

]]> DG-DEN-16446-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Sun, 01 Oct 2023 16:15:12 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-16446-1/#c18985 https://devapps.diality.us/cru/DG-DEN-16446-1/#c18985 Sean Nash replied to Dara Navaei in DG-DEN-16446-1

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16446-1: comment by jtaylor "The question was resolved in comments for earli..." Fri, 29 Sep 2023 11:15:12 -0700 jtaylor https://devapps.diality.us/cru/DG-DEN-16446-1/#c18982 https://devapps.diality.us/cru/DG-DEN-16446-1/#c18982 jtaylor  (deleted user) replied to jtaylor  (deleted user) in DG-DEN-16446-1

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-16446-1: comment by jtaylor "RESOLVED in CODE WALKTHROUGH. (with nausea)" Fri, 29 Sep 2023 11:13:42 -0700 jtaylor https://devapps.diality.us/cru/DG-DEN-16446-1/#c18981 https://devapps.diality.us/cru/DG-DEN-16446-1/#c18981 jtaylor  (deleted user) replied to Dara Navaei in DG-DEN-16446-1

RESOLVED in CODE WALKTHROUGH. (with nausea)

]]> DG-DEN-16446-1: comment by jtaylor "But if _VECTORCAST_ is defined there is no defa..." Fri, 29 Sep 2023 11:08:02 -0700 jtaylor https://devapps.diality.us/cru/DG-DEN-16446-1/#c18980 https://devapps.diality.us/cru/DG-DEN-16446-1/#c18980 jtaylor  (deleted user) replied to Dara Navaei in DG-DEN-16446-1

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

]]> DG-DEN-16446-1: comment by Dara Navaei "Done" Thu, 28 Sep 2023 08:56:17 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-16446-1/#c18979 https://devapps.diality.us/cru/DG-DEN-16446-1/#c18979 Dara Navaei replied to jtaylor  (deleted user) in DG-DEN-16446-1

Done

]]>