Fisheye on dgfirmware/firmware/App/Controllers/Thermistors.h

DG-DEN-3421-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:34:58 -0700

Dara Navaei Closed DG-DEN-3421-1

DG-DEN-3421-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 08:34:41 -0700

Dara Navaei replied to qnguyen (deleted user) in DG-DEN-3421-1

RESOLVED in CODE WALKTHROUGH

DG-DEN-3421-1: reviewers resumed

Thu, 19 Oct 2023 08:29:12 -0700

pmontazemi (deleted user) , qnguyen (deleted user) and Sean Nash resumed reviewing DG-DEN-3421-1

DG-DEN-3421_DG Heat Disinfection

DG-DEN-3421-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 08:29:07 -0700

Dara Navaei started review DG-DEN-3421-1

DG-DEN-13946-1: closed by Dara Navaei

Dara Navaei — Wed, 18 Jan 2023 14:05:06 -0800

Dara Navaei Closed DG-DEN-13946-1

DG-DEN-13946-1: reviewers finished

Wed, 18 Jan 2023 14:04:57 -0800

Dara Navaei , Sean Nash and dcox (deleted user) finished reviewing DG-DEN-13946-1

DG-DEN-13946_Certain Temperature Sensors Trigger Wrong Alarm

DG-DEN-13946-1: comment by dcox "RESOLVED IN CODE WALKTHROUGH"

dcox — Wed, 18 Jan 2023 10:43:21 -0800

dcox (deleted user) replied to wbracken (deleted user) in DG-DEN-13946-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13946-1: comment by dcox "RESOLVED IN CODE WALKTHROUGH"

dcox — Tue, 17 Jan 2023 15:32:59 -0800

dcox (deleted user) replied to wbracken (deleted user) in DG-DEN-13946-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13946-1: comment by wbracken "Updated comment"

wbracken — Fri, 13 Jan 2023 11:40:25 -0800

wbracken (deleted user) replied to dcox (deleted user) in DG-DEN-13946-1

Updated comment

DG-DEN-13946-1: comment by dcox "RESOLVED IN CODE WALKTHROUGH"

dcox — Tue, 17 Jan 2023 12:03:54 -0800

dcox (deleted user) replied to wbracken (deleted user) in DG-DEN-13946-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13946-1: comment by dcox "RESOLVED IN CODE WALKTHROUGH"

dcox — Tue, 17 Jan 2023 12:00:45 -0800

dcox (deleted user) replied to wbracken (deleted user) in DG-DEN-13946-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13946-1: comment by wbracken "Corrected."

wbracken — Fri, 13 Jan 2023 11:39:56 -0800

wbracken (deleted user) replied to dcox (deleted user) in DG-DEN-13946-1

Corrected.

DG-DEN-13946-1: comment by wbracken "Only used if Temperature is in alarm."

wbracken — Fri, 13 Jan 2023 11:34:36 -0800

wbracken (deleted user) replied to dcox (deleted user) in DG-DEN-13946-1

Only used if Temperature is in alarm.

DG-DEN-13946-1: comment by wbracken "Only used if the load cell is out of range."

wbracken — Fri, 13 Jan 2023 11:31:20 -0800

wbracken (deleted user) replied to dcox (deleted user) in DG-DEN-13946-1

Only used if the load cell is out of range.

DG-DEN-13946-1: comment by dcox "No initial value for alarmID. Can it end up no..."

dcox — Fri, 13 Jan 2023 10:40:56 -0800

dcox (deleted user) commented on DG-DEN-13946-1

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

DG-DEN-13946-1: comment by dcox "Why remove initial value for alarmIndex?"

dcox — Fri, 13 Jan 2023 10:38:06 -0800

dcox (deleted user) commented on DG-DEN-13946-1

Why remove initial value for alarmIndex?

DG-DEN-13946-1: comment by dcox "Comment does not explain what the numbers are -..."

dcox — Fri, 13 Jan 2023 10:35:16 -0800

dcox (deleted user) commented on DG-DEN-13946-1

Comment does not explain what the numbers are - 3, 10, 10.

DG-DEN-13946-1: comment by dcox "Comment is 12bit specific, but code updated to ..."

dcox — Fri, 13 Jan 2023 10:33:56 -0800

dcox (deleted user) commented on DG-DEN-13946-1

Comment is 12bit specific, but code updated to use different references per thermistor.

DG-DEN-13946-1: comment by Sean Nash "Setting first iterator to 0 seems safer (in cas..."

Sean Nash — Tue, 10 Jan 2023 08:26:39 -0800

Sean Nash replied to wbracken (deleted user) in DG-DEN-13946-1

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum).
Could also create a redundant 0 enum like below and use the "first" enum to initialize a loop iterator safely:
enum list
{
FIRST_TEMP_SENSOR = 0,
TPI_SENSOR = FIRST_TEMP_SENSOR,
TPO_SENSOR,
TD1_SENSOR,
....
}
RESOLVED in CODE WALKTHROUGH.

DG-DEN-13946-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 10 Jan 2023 08:24:35 -0800

Sean Nash replied to wbracken (deleted user) in DG-DEN-13946-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13946-1: comment by wbracken "Similar code is in other monitoring functions. ..."

wbracken — Mon, 09 Jan 2023 11:09:41 -0800

wbracken (deleted user) replied to Sean Nash in DG-DEN-13946-1

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typedef THERMISTORS_TEMP_SENSORS_T. Changed load cells to use U08 to be consistent with temperature and pressure monitoring.

Should probably change temperature, pressure and load cells to use correct typedef.

Also, it looks like why the typedefs weren't used was in order to set the initial value of the iterator to 0 (i.e, the first sensor in the list). Seems like there should be a value that is the first item in the list, i.e. TEMPSENSORS_FIRST_SENSOR.

DG-DEN-13946-1: comment by wbracken "Removed."

wbracken — Mon, 09 Jan 2023 11:07:06 -0800

wbracken (deleted user) replied to Sean Nash in DG-DEN-13946-1

Removed.

DG-DEN-13946-1: comment by Sean Nash "Remove blank line."

Sean Nash — Mon, 09 Jan 2023 10:15:48 -0800

Sean Nash commented on DG-DEN-13946-1

Remove blank line.

DG-DEN-13946-1: comment by Sean Nash "Why change this to U08?"

Sean Nash — Fri, 06 Jan 2023 16:02:52 -0800

Sean Nash commented on DG-DEN-13946-1

Why change this to U08?

DG-DEN-13946-1: started by Dara Navaei

Dara Navaei — Wed, 04 Jan 2023 15:00:42 -0800

Dara Navaei started review DG-DEN-13946-1

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 03 Mar 2022 15:32:18 -0800

Dara Navaei committed a931553 on branch DEN-11928-dg-conductivity-update-den-tbd, DEN-12121-sw_dev-sprint-65-michael-garthwaite and 202 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/DialysateFlow.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DialysateFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-2, +2)

| History

| Source

| Diff

… 45 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 05 Jan 2022 20:16:06 -0800

Dara Navaei committed 025612a on branch DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update-den-tbd and 204 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DialysateFlow.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/DialysateFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-2, +2)

| History

| Source

| Diff

… 80 more files in changeset.

dgfirmware (DEN-15916-heat-disinfect-active-cool-fails-to-start-in-start-mode): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 11 Nov 2021 10:57:02 -0800

Dara Navaei committed 94a1905 on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 206 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConcentratePumps.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.c

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/Fans.h

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/FluidLeak.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/LoadCell.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-6, +6)

| History

| Source

| Diff

… 78 more files in changeset.

DG-DEN-3421-2-1: closed by Dara Navaei

Dara Navaei — Fri, 18 Dec 2020 13:18:13 -0800

Dara Navaei Closed DG-DEN-3421-2-1

DG-DEN-3421-2-1: reviewers finished

Mon, 14 Dec 2020 09:20:25 -0800

Sean Nash finished reviewing DG-DEN-3421-2-1

DG-DEN-3421_DG Heat Disinfection