Fisheye on hdfirmware/

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14007: Addressed code review comments.

Sean Nash — Mon, 02 Jan 2023 15:17:04 -0800

Sean Nash committed 90945af on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 296 more in hdfirmware

DEN-14007: Addressed code review comments.

· /firmware/App/Controllers/BloodFlow.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-2, +3)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14007: Addressed code review comments.

Sean Nash — Mon, 02 Jan 2023 15:09:59 -0800

Sean Nash committed d265eb0 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 296 more in hdfirmware

DEN-14007: Addressed code review comments.

· /firmware/App/Controllers/DialOutFlow.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14007: Fixed alarm 36 error from updates.

Sean Nash — Mon, 02 Jan 2023 14:49:31 -0800

Sean Nash committed c3315e0 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 296 more in hdfirmware

DEN-14007: Fixed alarm 36 error from updates.

· /firmware/App/Controllers/DialInFlow.c

(-6, +6)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14007: misc fixes to homing speed updates.

Sean Nash — Mon, 02 Jan 2023 14:26:51 -0800

Sean Nash committed 9883c63 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 296 more in hdfirmware

DEN-14007: misc fixes to homing speed updates.

· /firmware/App/Controllers/DialInFlow.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-5, +6)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14007: Tentative fix for DEN-13688 for pump homing consistency - set all pumps to same speed while homing.

Sean Nash — Mon, 02 Jan 2023 13:22:32 -0800

Sean Nash committed 0a0417a on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 296 more in hdfirmware

DEN-14007: Tentative fix for DEN-13688 for pump homing consistency - set all pumps to same speed while homing.

· /firmware/App/Controllers/BloodFlow.c	(-2, +24)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodFlow.h	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-3, +23)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-2, +24)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-0, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14007: Increased post-tx de-prime time from 20 to 30 seconds to allow dialysate line to fully de-prime.

Sean Nash — Mon, 02 Jan 2023 10:31:25 -0800

Sean Nash committed 2d7073b on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 296 more in hdfirmware

DEN-14007: Increased post-tx de-prime time from 20 to 30 seconds to allow dialysate line to fully de-prime.

· /firmware/App/Modes/ModePostTreat.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Thu, 22 Dec 2022 16:26:40 -0800

Dara Navaei committed 3dcce98 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 296 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 22 Dec 2022 16:26:31 -0800

Dara Navaei committed ee94d41 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 296 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/Prime.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'staging' into DEN-14099-bubbles-in-dialysate-out-line-from-dg-to-cartridge

Dara Navaei — Thu, 22 Dec 2022 16:17:17 -0800

Dara Navaei committed 3e0d27b on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 297 more in hdfirmware

Merge branch 'staging' into DEN-14099-bubbles-in-dialysate-out-line-from-dg-to-cartridge

· /firmware/App/Modes/Prime.c

(-5, +4)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Thu, 22 Dec 2022 16:15:56 -0800

Dara Navaei committed b2c55dd on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 297 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 22 Dec 2022 16:15:47 -0800

Dara Navaei committed 2a368aa on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 297 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14007 merged staging and resolved the merge conflicts

Dara Navaei — Thu, 22 Dec 2022 16:09:57 -0800

Dara Navaei committed 44e745e on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 298 more in hdfirmware

DEN-14007 merged staging and resolved the merge conflicts

· /firmware/App/Controllers/BloodFlow.c	(-6, +8)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-27, +139)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-18, +43)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Thu, 22 Dec 2022 15:13:14 -0800

Dara Navaei committed 7abe027 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 298 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 22 Dec 2022 15:13:06 -0800

Dara Navaei committed 9d041b0 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 298 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/AlarmMgmt.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DIAL-219: Fixed bug in broadcast user alarm button blockers.

Sean Nash — Thu, 22 Dec 2022 11:51:48 -0800

Sean Nash committed d861abb on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 299 more in hdfirmware

DIAL-219: Fixed bug in broadcast user alarm button blockers.

· /firmware/App/Services/AlarmMgmt.c

(-6, +12)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14099 Change PURGE_AIR_TIME_OUT_COUNT to 4min. Remove debug output.

Wed, 21 Dec 2022 17:57:01 -0800

Darren Cox committed cafcc49 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 297 more in hdfirmware

DEN-14099 Change PURGE_AIR_TIME_OUT_COUNT to 4min. Remove debug output.

· /firmware/App/Modes/Prime.c

(-14, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14099 Bubble clear mods to state machine.

Wed, 21 Dec 2022 17:51:03 -0800

Darren Cox committed 33955d5 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 297 more in hdfirmware

DEN-14099 Bubble clear mods to state machine.

· /firmware/App/Modes/Prime.c

(-47, +81)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Wed, 21 Dec 2022 14:54:52 -0800

Dara Navaei committed 83ec588 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 299 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 21 Dec 2022 14:54:40 -0800

Dara Navaei committed 7584976 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 299 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DialInFlow.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DialOutFlow.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/Battery.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/Battery.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/SafetyShutdown.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/HDCommon.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeInitPOST.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmt.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Services/AlarmMgmtSWFaults.h

(-2, +2)

| History

| Source

| Diff

… 6 more files in changeset.

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14307-dg_hd_...

Sean Nash — Wed, 21 Dec 2022 14:09:16 -0800

Sean Nash committed 1a792c5 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 299 more in hdfirmware

Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14307: partial fix to DEN-14086.

Sean Nash — Wed, 21 Dec 2022 14:09:13 -0800

Sean Nash committed c615f21 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 299 more in hdfirmware

DEN-14307: partial fix to DEN-14086.

· /firmware/App/Controllers/DialInFlow.c

(-5, +22)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14307 addressed a code review comment

Dara Navaei — Wed, 21 Dec 2022 13:50:46 -0800

Dara Navaei committed 73b0006 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 299 more in hdfirmware

DEN-14307 addressed a code review comment

· /firmware/App/Services/AlarmMgmt.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14307 addressed the code review comments

Dara Navaei — Wed, 21 Dec 2022 13:12:23 -0800

Dara Navaei committed 6f935c2 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 299 more in hdfirmware

DEN-14307 addressed the code review comments

· /firmware/App/Services/AlarmMgmt.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14307-dg_hd_...

Sean Nash — Wed, 21 Dec 2022 09:47:05 -0800

Sean Nash committed d633046 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 299 more in hdfirmware

Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14307: Removed obsolete build switches.

Sean Nash — Wed, 21 Dec 2022 09:47:03 -0800

Sean Nash committed 0c439dd on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 299 more in hdfirmware

DEN-14307: Removed obsolete build switches.

· /firmware/App/Drivers/Battery.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-13, +8)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-9, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-107, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/WatchdogMgmt.c	(-5, +0)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14307 addressed code review comments

Dara Navaei — Wed, 21 Dec 2022 09:31:40 -0800

Dara Navaei committed ee17705 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 299 more in hdfirmware

DEN-14307 addressed code review comments

· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14007 Code Review comments update 2.

Tue, 20 Dec 2022 11:46:20 -0800

Darren Cox committed 648d1d3 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 298 more in hdfirmware

DEN-14007 Code Review comments update 2.

· /firmware/App/Modes/ModePostTreat.c

(-3, +2)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14007 Code Review comments update 1.

Mon, 19 Dec 2022 15:36:22 -0800

Darren Cox committed 0b8f332 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 298 more in hdfirmware

DEN-14007 Code Review comments update 1.

· /firmware/App/Controllers/BloodFlow.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePostTreat.c	(-18, +21)	\| History	\| Source	\| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14099 Code review comments: code cleanup from moving bubble clear pressurize.

Mon, 19 Dec 2022 14:36:01 -0800

Darren Cox committed 4db65dc on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 297 more in hdfirmware

DEN-14099 Code review comments: code cleanup from moving bubble clear pressurize.

· /firmware/App/Modes/Prime.c

(-5, +0)

| History

| Source

| Diff

hdfirmware (DEN-15436-dpi-tubing-comes-out-of-pump-track-during-dpi-reversal-in-post-treatment): DEN-14307: Fixed polarity issue with reported state based alarm button blockage. Renamed battery capacity remaining var...

Sean Nash — Mon, 19 Dec 2022 13:21:04 -0800

Sean Nash committed 53a25d6 on branch DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 299 more in hdfirmware

DEN-14307: Fixed polarity issue with reported state based alarm button blockage. Renamed battery capacity remaining variable to correct units. Stop disabling battery comm on build switch.

· /firmware/App/Drivers/Battery.c	(-13, +13)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/Battery.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-9, +9)	\| History	\| Source	\| Diff